All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@buildroot.org
Cc: Neal Frager <neal.frager@amd.com>
Subject: Re: [Buildroot] [PATCH] package/bootgen: add patch to fix builds on machines with modern flex versions
Date: Tue, 13 Jun 2023 23:54:28 +0200	[thread overview]
Message-ID: <87wn07t4dn.fsf@48ers.dk> (raw)
In-Reply-To: <20230612192648.859014-1-peter@korsgaard.com> (Peter Korsgaard's message of "Mon, 12 Jun 2023 21:26:47 +0200")

>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:

 > Fixes:
 > http://autobuild.buildroot.net/results/293/2936d9b054269b7055e66ab5a7f7c1f7f4926d48/

 > Bootgen embeds an old version of flex, but uses the system include syntax
 > (#include <>) to reference it, causing conflicts on systems with the
 > development headers for a modern flex version installed, leading to build
 > issues like:

 > ../bisonflex/cmdoptions.yy.cpp: In member function 'virtual int CO::FlexScanner::yylex()':
 > ../bisonflex/cmdoptions.yy.cpp:1362:18: error: no match for
 > 'operator=' (operand types are 'std::istream' {aka
 > 'std::basic_istream<char>'} and 'std::istream*' {aka
 > 'std::basic_istream<char>*'})

 > Fix it by using normal local includes (#include "") instead.

 > Notice: This was already fixed on master, but the cmdoptions.yy.cpp and
 > reginit.yy.cpp hunks were accidently dropped when the changes were squashed
 > for the 2023.1 release.

 > Signed-off-by: Peter Korsgaard <peter@korsgaard.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2023-06-13 21:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-12 19:26 [Buildroot] [PATCH] package/bootgen: add patch to fix builds on machines with modern flex versions Peter Korsgaard
2023-06-12 20:03 ` Frager, Neal via buildroot
2023-06-13 21:54 ` Peter Korsgaard [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-06-12 20:03 Frager, Neal via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wn07t4dn.fsf@48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@buildroot.org \
    --cc=neal.frager@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.