From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F145EC7EE23 for ; Thu, 1 Jun 2023 18:33:02 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4957C10E19E; Thu, 1 Jun 2023 18:33:02 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4D65E10E19E for ; Thu, 1 Jun 2023 18:32:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1685644379; x=1717180379; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=3CmWiCNHinvVoDMOGtvz7SSLeLwhBS0XeDZ+j4Q1970=; b=esGuyDV1WzjI6/lB4aIsZa1+/Evg6qk6AgQqYL1Os4OW6wh+dDBWieul 4laxEsBYc6A2vGIJZtgBFHJ/BE9XTjXuSkDR4VnvW4htAY9Un+1Fy8Gbb UBuRL+tIj3YC+BL6sTFUvR/YkXLtW5ZAaKBsZE668XQwoG/dCYiZZJ+Fo h5j3IO//WmPV3E/w+Fx9hVOJGwlJjmxK2t/aivj6O2Y/P3eH9diKI0M39 l83QI9PHIv5H4sUxP64yOs30QTZPW9WKyleEsvmaWXpCLTGNjrSEpM6+j s/LQO8finlZ9c5/ToVyx2uc67biHQWMxicFkguG0RvKG3mVsjC5qRH70e w==; X-IronPort-AV: E=McAfee;i="6600,9927,10728"; a="353143203" X-IronPort-AV: E=Sophos;i="6.00,210,1681196400"; d="scan'208";a="353143203" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jun 2023 11:32:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10728"; a="707463750" X-IronPort-AV: E=Sophos;i="6.00,210,1681196400"; d="scan'208";a="707463750" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.212.190.91]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jun 2023 11:32:18 -0700 Date: Thu, 01 Jun 2023 11:22:18 -0700 Message-ID: <87wn0nujol.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Matt Atwood In-Reply-To: <20230531213547.1525692-1-matthew.s.atwood@intel.com> References: <20230531213547.1525692-1-matthew.s.atwood@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH] drm/i915: sync I915_PMU_MAX_GTS to I915_MAX_GT X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, Andi Shyti Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, 31 May 2023 14:35:47 -0700, Matt Atwood wrote: > Hi Matt, > Set I915_PMU_MAX_GTS to value in I915_MAX_GT, theres no reason for these > values to be different. > > Cc: Tvrtko Ursulin > Cc: Umesh Nerlige Ramappa > Cc: Ashutosh Dixit I don't believe the mailer actually Cc'd us. I just saw this and am Cc'ing the people who authored/reviewed the previous series now. > Signed-off-by: Matt Atwood > --- > drivers/gpu/drm/i915/i915_pmu.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_pmu.h b/drivers/gpu/drm/i915/i915_pmu.h > index 33d80fbaab8b..aa929d8c224a 100644 > --- a/drivers/gpu/drm/i915/i915_pmu.h > +++ b/drivers/gpu/drm/i915/i915_pmu.h > @@ -38,7 +38,7 @@ enum { > __I915_NUM_PMU_SAMPLERS > }; > > -#define I915_PMU_MAX_GTS 2 > +#define I915_PMU_MAX_GTS 4 This was a discussed during the previous review and it was decided to keep the two values (I915_PMU_MAX_GTS and I915_MAX_GT) different. There are currently no platforms and there will be no i915 supported platforms with MAX_GT 4. So I prefer to leave the values as they currently are. Unless Umesh or Tvrtko agrees to this patch. Thanks. -- Ashutosh > > /* > * How many different events we track in the global PMU mask. > -- > 2.40.0 >