From: Kalle Valo <kvalo@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: "Álvaro Fernández Rojas" <noltari@gmail.com>,
f.fainelli@gmail.com, jonas.gorski@gmail.com, nbd@nbd.name,
toke@toke.dk, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, chunkeey@gmail.com,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: net: wireless: ath9k: document endian check
Date: Mon, 17 Apr 2023 12:38:54 +0300 [thread overview]
Message-ID: <87wn2ax2z5.fsf@kernel.org> (raw)
In-Reply-To: <dd1525de-fa91-965f-148a-f7f517ae48f9@kernel.org> (Krzysztof Kozlowski's message of "Mon, 17 Apr 2023 09:19:58 +0200")
Krzysztof Kozlowski <krzk@kernel.org> writes:
>> --- a/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml
>> +++ b/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml
>> @@ -44,6 +44,11 @@ properties:
>>
>> ieee80211-freq-limit: true
>>
>> + qca,endian-check:
>> + $ref: /schemas/types.yaml#/definitions/flag
>> + description:
>> + Indicates that the EEPROM endianness should be checked
>
> Does not look like hardware property. Do not instruct what driver should
> or should not do. It's not the purpose of DT.
Also the documentation is vague and is not really telling anything new
what could be figured out from the property name, I would not be able to
understand just from this what value should be used.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2023-04-17 9:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 5:35 [PATCH v2 0/2] ath9k: of_init: add endian check Álvaro Fernández Rojas
2023-04-17 5:35 ` [PATCH v2 1/2] dt-bindings: net: wireless: ath9k: document " Álvaro Fernández Rojas
2023-04-17 7:19 ` Krzysztof Kozlowski
2023-04-17 9:38 ` Kalle Valo [this message]
2023-04-17 17:43 ` Álvaro Fernández Rojas
2023-04-17 5:35 ` [PATCH v2 2/2] ath9k: of_init: add " Álvaro Fernández Rojas
2023-04-17 9:21 ` Toke Høiland-Jørgensen
2023-04-17 17:54 ` Álvaro Fernández Rojas
2023-04-17 22:56 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wn2ax2z5.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=chunkeey@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=jonas.gorski@gmail.com \
--cc=krzk@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=noltari@gmail.com \
--cc=pabeni@redhat.com \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.