From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1pIlgM-0006Je-Ur for mharc-qemu-riscv@gnu.org; Fri, 20 Jan 2023 02:19:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIlgB-0006EI-Qc for qemu-riscv@nongnu.org; Fri, 20 Jan 2023 02:19:21 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIlgA-0000MU-G1 for qemu-riscv@nongnu.org; Fri, 20 Jan 2023 02:19:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674199153; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6md71e2jNUouzTwyHjKhVyyvi8603ELUx+xgbZE07Qo=; b=NA4MitxSpWF7mNDJ4hUB2wMrFFzdVvkld0XmpZuS7OHDRE8JqujcPWomh+7V2xqtYEO5FB 5yhBLkow+KbCoT+7rFA0VuezzOq+VZgkzfHFfrt6H3j6BvJvUuuTmqiC+atf3d7DFUvjkL m7r8IWfAM8HpeUDj4ehhh70wmkdoLv8= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-138-dYftd6rBM2OUinGqeKSM9Q-1; Fri, 20 Jan 2023 02:19:07 -0500 X-MC-Unique: dYftd6rBM2OUinGqeKSM9Q-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C14B03802B82; Fri, 20 Jan 2023 07:19:06 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.70]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E696D1415113; Fri, 20 Jan 2023 07:19:05 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id CACB421E6A28; Fri, 20 Jan 2023 08:19:04 +0100 (CET) From: Markus Armbruster To: "Dr. David Alan Gilbert" Cc: qemu-devel@nongnu.org, richard.henderson@linaro.org, pbonzini@redhat.com, kwolf@redhat.com, hreitz@redhat.com, imp@bsdimp.com, kevans@freebsd.org, berrange@redhat.com, groug@kaod.org, qemu_oss@crudebyte.com, mst@redhat.com, philmd@linaro.org, peter.maydell@linaro.org, alistair@alistair23.me, jasowang@redhat.com, jonathan.cameron@huawei.com, kbastian@mail.uni-paderborn.de, quintela@redhat.com, michael.roth@amd.com, kkostiuk@redhat.com, tsimpson@quicinc.com, palmer@dabbelt.com, bin.meng@windriver.com, qemu-block@nongnu.org, qemu-arm@nongnu.org, qemu-riscv@nongnu.org Subject: Re: [PATCH v4 10/19] migration: Clean up includes References: <20230119065959.3104012-1-armbru@redhat.com> <20230119065959.3104012-11-armbru@redhat.com> <87wn5ivmru.fsf@pond.sub.org> Date: Fri, 20 Jan 2023 08:19:04 +0100 In-Reply-To: (David Alan Gilbert's message of "Thu, 19 Jan 2023 11:45:36 +0000") Message-ID: <87wn5hoeqf.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jan 2023 07:19:22 -0000 "Dr. David Alan Gilbert" writes: > * Markus Armbruster (armbru@redhat.com) wrote: >> "Dr. David Alan Gilbert" writes: >> >> > * Markus Armbruster (armbru@redhat.com) wrote: >> >> Clean up includes so that osdep.h is included first and headers >> >> which it implies are not included manually. >> > >> > That change doesn't seem to match the message; the patch is removing the >> > osdep.h include. >> >> It's the commit message scripts/clean-includes creates :) >> >> I can throw in another patch to the script so it mentions it also >> removes qemu/osdep.h from headers. > > Oh hmm it would be clearer; What about $GITSUBJ: Clean up includes Clean up includes so that osdep.h is included first in .c and not in .h, and headers which it implies are not included manually. This commit was created with scripts/clean-includes. > but OK then, so > > Reviewed-by: Dr. David Alan Gilbert Thanks!