Re: [PATCH v2] brcmfmac: Add support for BCM43596 PCIe Wi-Fi

[Kalle Valo <kvalo@kernel.org>]

Linus Walleij <linus.walleij@linaro.org> writes:

>> >> Instead of a directory path ("brcm/brcmfmac43596-pcie") why not provide
>> >> just the chipset name ("brcmfmac43596-pcie")? IMHO it's unnecessary to
>> >> have directory names in Device Tree.
>> >
>> > I think it's common practice to include a full $FIRMWARE_DIR-relative
>> > path when specifying firmware in DT, though here I left out the board
>> > name bit as that's assigned dynamically anyway. That said, if you don't
>> > like it, I can change it.
>>
>> It's just that I have understood that Device Tree is supposed to
>> describe hardware and to me a firmware directory "brcm/" is a software
>> property, not a hardware property. But this is really for the Device
>> Tree maintainers to decide, they know this best :)
>
> I would personally just minimize the amount of information
> put into the device tree to be exactly what is needed to find
> the right firmware.
>
> brcm,firmware-compatible = "43596";
>
> since the code already knows how to conjure the rest of the string.

FWIW I like this.

> But check with Rob/Krzysztof.

Indeed, they are the experts here.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches