From: Kalle Valo <kvalo@kernel.org>
To: Arend Van Spriel <arend.vanspriel@broadcom.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
"Chi-Hsien Lin" <chi-hsien.lin@cypress.com>,
Wright Feng <wright.feng@cypress.com>,
<linux-wireless@vger.kernel.org>,
<brcm80211-dev-list.pdl@broadcom.com>,
<brcm80211-dev-list@cypress.com>
Subject: Re: [PATCH] brcm80211: brcmsmac: Drop BMCMA consistency check
Date: Tue, 25 Oct 2022 23:09:23 +0300 [thread overview]
Message-ID: <87wn8ny8b0.fsf@kernel.org> (raw)
In-Reply-To: <1840a6374e8.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> (Arend Van Spriel's message of "Mon, 24 Oct 2022 16:26:42 +0200")
Arend Van Spriel <arend.vanspriel@broadcom.com> writes:
> On October 24, 2022 2:40:08 PM Linus Walleij <linus.walleij@linaro.org> wrote:
>
>> The driver looks up the BCMA parent GPIO driver and checks that
>> this succeeds, but then it goes on to use the deprecated GPIO
>> call gpio_is_valid() to check the consistency of the .base
>> member of the BCMA GPIO struct. Surely this belongs in the
>> BCMA driver: we cannot have all drivers performing cosistency
>
> Should be: consistency
>
>>
>> checks on the internals of things they are passed.
>
> Apart from the typo in the subject and missing wifi: prefix (replace
> 'brcm80211' by 'wifi')...
I can fix those.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2022-10-25 20:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 12:40 [PATCH] brcm80211: brcmsmac: Drop BMCMA consistency check Linus Walleij
2022-10-24 14:26 ` Arend Van Spriel
2022-10-25 20:09 ` Kalle Valo [this message]
2022-10-26 7:52 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wn8ny8b0.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=chi-hsien.lin@cypress.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=linus.walleij@linaro.org \
--cc=linux-wireless@vger.kernel.org \
--cc=wright.feng@cypress.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.