From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D50CC433EF for ; Fri, 17 Jun 2022 10:19:36 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 469A74B21A; Fri, 17 Jun 2022 06:19:36 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vH4MVkrBONny; Fri, 17 Jun 2022 06:19:35 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 2A9EB4B249; Fri, 17 Jun 2022 06:19:35 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 895564B0CE for ; Fri, 17 Jun 2022 06:19:33 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ME9eEnN8zwdv for ; Fri, 17 Jun 2022 06:19:32 -0400 (EDT) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 77AD449E33 for ; Fri, 17 Jun 2022 06:19:32 -0400 (EDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4490F61D15; Fri, 17 Jun 2022 10:19:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D79BC3411B; Fri, 17 Jun 2022 10:19:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655461170; bh=Fi1fXkSCde37ExR4DUqSeDudoUyXDrG53vkvT5PkC58=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nvTFaZtqputhz+v32EoYQ/9G1oRPZjWb0wkpDBe4ut+KAP6bFWL5JEr+/gEriLl9Z 9FEh3V9Q2WmSWbUWxX7bZZWXMsrmP8goWOwxGQVbn7ZrILLlZF1pzmjj2ZzEIHaVQY kpmIyxWyxmocbDRu3mgjHdDniOlcOy7N8Xh2ol0+lcbSzbMA/xVIIldV5TC1x0G+Bu Ws5X5aUlvOpi8/FcXygDmAVktIGDImcLGBCSX21du2V/wHTIXrC4vsjwiETN3Uybl1 t7rPkL76I/t82OPofkeBimPlIculcBBd+9ZzjubkH3YtwWokBj+kPGP6ZNWbg4y7Wj b5VSKN5TGU5EQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1o294a-001Gvd-F6; Fri, 17 Jun 2022 11:19:28 +0100 Date: Fri, 17 Jun 2022 11:19:28 +0100 Message-ID: <87wndf383z.wl-maz@kernel.org> From: Marc Zyngier To: Gavin Shan Subject: Re: [Question] remote_tlb_flush statistic is missed from kvm_flush_remote_tlbs() ? In-Reply-To: <25c7cc69-64ef-d42b-dc0b-968d7415b111@redhat.com> References: <25c7cc69-64ef-d42b-dc0b-968d7415b111@redhat.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: gshan@redhat.com, kvmarm@lists.cs.columbia.edu, will@kernel.org, drjones@redhat.com, jingzhangos@google.com, pbonzini@redhat.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: Paolo Bonzini , Will Deacon , "open list:KERNEL VIRTUAL MACHINE FOR ARM64 \(KVM/arm64\)" X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Fri, 17 Jun 2022 11:02:44 +0100, Gavin Shan wrote: > > Hi Folks, > > We're reviewing upstream commits and found that it seems that > ++kvm->stat.generic.remote_tlb_flush has been missed from > kvm_flush_remote_tlbs(). If I'm correct, we still need to > increase the statistic in kvm_flush_remote_tlbs()? > > History about the changes: > > ce6a7007048b staging: r8188eu: remove {read,write}_macreg > The changes were NOT there any more. > 419025b3b419 Merge branch kvm-arm64/misc-5.15 into kvmarm-master/next > The changes were still there > 38f703663d4c KVM: arm64: Count VMID-wide TLB invalidations > The changes were initially introduced by this commit, > to increase 'kvm->stat.generic.remote_tlb_flush' in > kvm_flush_remote_tlbs(). I'm not sure what you are asking. This change is definitely still present in the upstream kernel, and I don't get your point with the staging commit, which is totally unrelated. $ git describe --contains ce6a7007048b --match=v\* v5.15-rc1~154^2~11 $ git describe --contains 419025b3b419 --match=v\* v5.15-rc1~65^2~4^2 $ git describe --contains 38f703663d4c --match=v\* v5.15-rc1~65^2~4^2^2~13 As you can see, the commit fixing the statistics was merged after staging one (it appears closer to -rc1, as there is 6 days between the two merge commits from Linus). Puzzled, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm