All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: igt-dev@lists.freedesktop.org,
	Alexander Usyskin <alexander.usyskin@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t 2/2] lib/igt_kmod: Unload mei modules before unloading i915
Date: Thu, 31 Mar 2022 14:54:08 -0700	[thread overview]
Message-ID: <87wng9hjpb.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20220330183259.3003663-3-daniele.ceraolospurio@intel.com>

On Wed, 30 Mar 2022 11:32:59 -0700, Daniele Ceraolo Spurio wrote:
>
> mei_gsc binds to an aux device exposed by i915, so it depends on it and
> need to be removed before we can unload i915.
> On platforms with a GSC, the mei components (pxp, hdcp) depend on
> mei_gsc, so those need to be unloaded first.

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Cc: Alexander Usyskin <alexander.usyskin@intel.com>
> ---
>  lib/igt_kmod.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c
> index d2ac8a56..28ffe515 100644
> --- a/lib/igt_kmod.c
> +++ b/lib/igt_kmod.c
> @@ -400,6 +400,10 @@ int __igt_i915_driver_unload(const char **who)
>	const char *aux[] = {
>		/* gen5: ips uses symbol_get() so only a soft module dependency */
>		"intel_ips",
> +		/* mei_gsc uses an i915 aux dev and the other mei mods depend on it */
> +		"mei_pxp",
> +		"mei_hdcp",
> +		"mei_gsc",
>		NULL,
>	};
>
> --
> 2.25.1
>

  reply	other threads:[~2022-03-31 21:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-30 18:32 [igt-dev] [PATCH i-g-t 0/2] Unload mei_gsc before i915 Daniele Ceraolo Spurio
2022-03-30 18:32 ` [igt-dev] [PATCH i-g-t 1/2] lib/igt_kmod: Wait for a kmod to finish its probe before unloding it Daniele Ceraolo Spurio
2022-03-31 22:52   ` Dixit, Ashutosh
2022-03-31 23:09     ` Ceraolo Spurio, Daniele
2022-04-01  1:18       ` Dixit, Ashutosh
2022-04-01  2:03   ` Dixit, Ashutosh
2022-04-01  2:11     ` Ceraolo Spurio, Daniele
2022-04-01  2:21       ` Dixit, Ashutosh
2022-03-30 18:32 ` [igt-dev] [PATCH i-g-t 2/2] lib/igt_kmod: Unload mei modules before unloading i915 Daniele Ceraolo Spurio
2022-03-31 21:54   ` Dixit, Ashutosh [this message]
2022-04-01  1:23     ` Dixit, Ashutosh
2022-04-01  2:04       ` Ceraolo Spurio, Daniele
2022-03-30 18:51 ` [igt-dev] ✗ GitLab.Pipeline: warning for Unload mei_gsc before i915 Patchwork
2022-03-30 19:25 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2022-03-30 22:33 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wng9hjpb.wl-ashutosh.dixit@intel.com \
    --to=ashutosh.dixit@intel.com \
    --cc=alexander.usyskin@intel.com \
    --cc=daniele.ceraolospurio@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.