From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CDBBC433F5 for ; Wed, 27 Oct 2021 13:05:30 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DB49560F39 for ; Wed, 27 Oct 2021 13:05:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DB49560F39 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 16DF56E7D9; Wed, 27 Oct 2021 13:05:29 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 52DDC6E7D9 for ; Wed, 27 Oct 2021 13:05:27 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10149"; a="253704712" X-IronPort-AV: E=Sophos;i="5.87,186,1631602800"; d="scan'208";a="253704712" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2021 06:05:15 -0700 X-IronPort-AV: E=Sophos;i="5.87,186,1631602800"; d="scan'208";a="497857247" Received: from smaharan-mobl.gar.corp.intel.com (HELO localhost) ([10.251.214.195]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2021 06:05:11 -0700 From: Jani Nikula To: Arnd Bergmann Cc: Daniel Vetter , Kees Cook , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Arnd Bergmann , Alex Deucher , Christian =?utf-8?Q?K=C3=B6nig?= , dri-devel , Linux Kernel Mailing List , Javier Martinez Canillas Subject: Re: [PATCH] [RESEND] drm: fb_helper: fix CONFIG_FB dependency In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20210927142816.2069269-1-arnd@kernel.org> <202109270923.97AFDE89DB@keescook> <878ryeit9i.fsf@intel.com> Date: Wed, 27 Oct 2021 16:05:08 +0300 Message-ID: <87wnlyhb3v.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, 27 Oct 2021, Arnd Bergmann wrote: > On a related note, I did manage to sort out the backlight dependency issue > (intel_panel.c:(.text+0x2f58): undefined reference to > `backlight_device_register'), > but haven't sent that one again yet, but I can if you like. This one changes > DRM_I915 and all of drivers/video/fbdev from 'select BACKLIGHT_CLASS_DEVICE' > to 'depends on', which I think moves everything into broadly the right > direction. > > Let me know if you would like me to send those now, or have a look at the > top 3 patches in [1] if you are interested. This has passed a few > thousand randconfig > builds and should not depend on additional patches. FWIW, Acked-by: Jani Nikula on the patches. I think I've sent patches before to do the same change from "select" to "depends on", but they went nowhere. IIRC the opposition was that people wanted to be able to find and enable their driver in menuconfig without first having to enable BACKLIGHT_CLASS_DEVICE. BR, Jani. > > Arnd > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git/log/?h=randconfig-5.16-next -- Jani Nikula, Intel Open Source Graphics Center