All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@linux-m68k.org>
To: opensbi@lists.infradead.org
Subject: [PATCH V2 1/2] lib: sbi: add some macros to detect BUG at runtime
Date: Wed, 15 Sep 2021 11:27:13 +0200	[thread overview]
Message-ID: <87wnni42a6.fsf@igel.home> (raw)
In-Reply-To: <20210915090330.23354-1-wxjstz@126.com> (Xiang W.'s message of "Wed, 15 Sep 2021 17:03:29 +0800")

On Sep 15 2021, Xiang W wrote:

> +#define BUG_ON(cond) do { \
> +	if (!(cond))	\
> +		BUG(); \

Isn't that backwards?

Andreas.

-- 
Andreas Schwab, schwab at linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."


  parent reply	other threads:[~2021-09-15  9:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-15  9:03 [PATCH V2 1/2] lib: sbi: add some macros to detect BUG at runtime Xiang W
2021-09-15  9:03 ` [PATCH V2 2/2] lib: sbi: Add runtime bug detection for csr_read_num/csr_write_num/misa_string Xiang W
2021-09-15  9:27 ` Andreas Schwab [this message]
2021-09-15 10:07   ` [PATCH V2 1/2] lib: sbi: add some macros to detect BUG at runtime Xiang W
2021-09-15 12:39 ` 杜东
2021-09-15 13:56   ` Xiang W
2021-09-15 14:41     ` Mitchell Horne
2021-09-15 14:49       ` Jessica Clarke
2021-09-16  4:38         ` Xiang W

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wnni42a6.fsf@igel.home \
    --to=schwab@linux-m68k.org \
    --cc=opensbi@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.