From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E24FFC4338F for ; Mon, 9 Aug 2021 10:09:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C966F6108C for ; Mon, 9 Aug 2021 10:09:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233772AbhHIKJt (ORCPT ); Mon, 9 Aug 2021 06:09:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:54478 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233565AbhHIKJt (ORCPT ); Mon, 9 Aug 2021 06:09:49 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6B7906105A; Mon, 9 Aug 2021 10:09:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628503768; bh=J2hgy7rffX4798inBReCwp7jM4tx7ZvQ+GBmSpYvg00=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=g559DSd3DEpiOrFxVR96qasiZUlInlmcQYsXZW6ry305yP9TSUQILYdWmtXm2zT3N ozUb+m1i52iaOeAsDuaBmUCphKRCEnkfJgBmdXwz3trK1Mk2R2wSOBjAhich7Ryebh GRfTyXSNj41XDPH8ZqVVHWMOabmGu//N2gnjrkjRAeFUue26SMFBlz5PGJrXs6YEPz IovLGxLHyD2sROWJp5rpk8IT4YbvJ9V0miD/WkYeWb03X++KTrK5iXVES2PUCYY1Cz p0baA+iS9ezVNdHda11j0h6FAd5HbOrGs0TisLldPB1bbaIsxMCaFWaI5osYPhSark JNiHvnGJXWdbw== References: <717ddd7c-22cd-d82c-e43d-80254718c801@omp.ru> User-agent: mu4e 1.6.2; emacs 27.2 From: Felipe Balbi To: Sergey Shtylyov Cc: linux-usb@vger.kernel.org, Greg Kroah-Hartman , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH 4/9] usb: gadget: udc: s3c2410: add IRQ check Date: Mon, 09 Aug 2021 13:09:07 +0300 In-reply-to: Message-ID: <87wnovj5ey.fsf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org Sergey Shtylyov writes: > The driver neglects to check the result of platform_get_irq()'s call and > blithely passes the negative error codes to devm_request_irq() (which takes > *unsigned* IRQ #), causing it to fail with -EINVAL, overriding an original > error code. Stop calling devm_request_irq() with the invalid IRQ #s. > > Fixes: 8b2e76687b39 ("USB: AT91 UDC updates, mostly power management") > Signed-off-by: Sergey Shtylyov Acked-by: Felipe Balbi -- balbi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBF6FC4338F for ; Mon, 9 Aug 2021 10:11:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7D96E61076 for ; Mon, 9 Aug 2021 10:11:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7D96E61076 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-reply-to: Date:Subject:Cc:To:From:References:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VC4669But4XhjTqK/uEYxaVDVpABgSoUh/qhz9Pfcb0=; b=ondyGoTff83tK9 Rrpn/9Mh/UC/e0aNls8X3CXu/xT2jfR6TgjNAYqTa6L/4JkCdKUVV+cN6Z3gLc4zWSs5RSX6d/xag mlWleSMJhBUHUJx980Fv0nEldmn8mf1DNpS5P2BbZh8VfbUW+cOhlrtylRw9y+IdsnoP++DWE5Wxv TM7eDtTzd2cjl9GWRp7rcCLJSzmnsmjsGRi2x4HQmGosPG8etPoVUpzQHU7ZvSWp7NW9njOoqYFIR cc/wnNOeIp8YancREaJNVsUggqhMONOnRLg5cvWfbCOhzvy2pPsNPLg2rleLWzG386bx8rQek1SCf qNHSzG5tgvTNqnrBtRYw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mD2Dt-0009Qa-L5; Mon, 09 Aug 2021 10:09:33 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mD2Dp-0009PU-5N for linux-arm-kernel@lists.infradead.org; Mon, 09 Aug 2021 10:09:30 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6B7906105A; Mon, 9 Aug 2021 10:09:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628503768; bh=J2hgy7rffX4798inBReCwp7jM4tx7ZvQ+GBmSpYvg00=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=g559DSd3DEpiOrFxVR96qasiZUlInlmcQYsXZW6ry305yP9TSUQILYdWmtXm2zT3N ozUb+m1i52iaOeAsDuaBmUCphKRCEnkfJgBmdXwz3trK1Mk2R2wSOBjAhich7Ryebh GRfTyXSNj41XDPH8ZqVVHWMOabmGu//N2gnjrkjRAeFUue26SMFBlz5PGJrXs6YEPz IovLGxLHyD2sROWJp5rpk8IT4YbvJ9V0miD/WkYeWb03X++KTrK5iXVES2PUCYY1Cz p0baA+iS9ezVNdHda11j0h6FAd5HbOrGs0TisLldPB1bbaIsxMCaFWaI5osYPhSark JNiHvnGJXWdbw== References: <717ddd7c-22cd-d82c-e43d-80254718c801@omp.ru> User-agent: mu4e 1.6.2; emacs 27.2 From: Felipe Balbi To: Sergey Shtylyov Cc: linux-usb@vger.kernel.org, Greg Kroah-Hartman , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH 4/9] usb: gadget: udc: s3c2410: add IRQ check Date: Mon, 09 Aug 2021 13:09:07 +0300 In-reply-to: Message-ID: <87wnovj5ey.fsf@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210809_030929_289694_6F1C23A3 X-CRM114-Status: UNSURE ( 6.80 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Sergey Shtylyov writes: > The driver neglects to check the result of platform_get_irq()'s call and > blithely passes the negative error codes to devm_request_irq() (which takes > *unsigned* IRQ #), causing it to fail with -EINVAL, overriding an original > error code. Stop calling devm_request_irq() with the invalid IRQ #s. > > Fixes: 8b2e76687b39 ("USB: AT91 UDC updates, mostly power management") > Signed-off-by: Sergey Shtylyov Acked-by: Felipe Balbi -- balbi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel