Re: [igt-dev] [PATCH i-g-t] tests/kms: Return false in gem_has_lmem for kernels not having DRM_I915_QUERY_MEMORY_REGIONS support

From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Vidya Srinivas <vidya.srinivas@intel.com>
Cc: kunal1.joshi@intel.com, petri.latvala@intel.com,
	igt-dev@lists.freedesktop.org, juha-pekka.heikkila@intel.com,
	Lin Charlton <charlton.lin@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms: Return false in gem_has_lmem for kernels not having DRM_I915_QUERY_MEMORY_REGIONS support
Date: Sat, 24 Jul 2021 14:20:19 -0700	[thread overview]
Message-ID: <87wnpfo1d8.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20210724165317.32000-1-vidya.srinivas@intel.com>

On Sat, 24 Jul 2021 09:53:17 -0700, Vidya Srinivas wrote:
>
> @@ -164,6 +175,9 @@ uint8_t gem_get_lmem_region_count(int fd)
>   */
>  bool gem_has_lmem(int fd)
>  {
> +	int ret = gem_has_memregion_query_support(fd);
> +	if (ret == ENOSYS || ret == ENOTSUP)
> +		return false;
>	return gem_get_lmem_region_count(fd) > 0;

gem_get_query_memory_regions is still broken. So we should use
__i915_query_items there.

The patch title also should not say tests/kms.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev