diff for duplicates of <87wnqqopp9.fsf@linux.ibm.com> diff --git a/a/1.txt b/N1/1.txt index c751940..c714548 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -338,7 +338,7 @@ Nitpick: esi_attrs. > + * and save a HCALL > + */ > + for (idx = 0; idx < be64_to_cpu(em_buf->num_attr); idx++) { -> + if (pattr->id = be64_to_cpu(ea[idx].attr_id)) { +> + if (pattr->id == be64_to_cpu(ea[idx].attr_id)) { > + ret = sprintf(buf, "%s\n", ea[idx].attr_desc); > + if (ret < 0) > + ret = -EIO; @@ -359,7 +359,7 @@ Nitpick: esi_attrs. > + int data_offset, ret = 0; > + > + t_buf = kmalloc(sizeof(*t_buf), GFP_KERNEL); -> + if (t_buf = NULL) +> + if (t_buf == NULL) > + return -ENOMEM; > + > + ret = plpar_hcall_norets(H_GET_ENERGY_SCALE_INFO, 0, @@ -403,7 +403,7 @@ be 0. So there is no point doing this arithmetic. > + int data_offset, ret = 0; > + > + t_buf = kmalloc(sizeof(*t_buf), GFP_KERNEL); -> + if (t_buf = NULL) +> + if (t_buf == NULL) > + return -ENOMEM; > + > + ret = plpar_hcall_norets(H_GET_ENERGY_SCALE_INFO, 0, @@ -474,7 +474,7 @@ be 0. So there is no point doing this arithmetic. > + int ret, idx, i, data_offset; > + > + em_buf = kmalloc(sizeof(*em_buf), GFP_KERNEL); -> + if (em_buf = NULL) +> + if (em_buf == NULL) > + return -ENOMEM; > + /* > + * hcall( @@ -555,7 +555,7 @@ function. > + pgs[idx].pg.name = buf; > + > + /* Do not add the value description if it does not exist */ -> + if (strlen(ea[idx].attr_value_desc) = 0) +> + if (strlen(ea[idx].attr_value_desc) == 0) > + show_val_desc = false; > + > + if (add_attr_group(be64_to_cpu(ea[idx].attr_id), diff --git a/a/content_digest b/N1/content_digest index 914b2c8..bcaff17 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\020210616134240.62195-2-psampat@linux.ibm.com\0" "From\0Fabiano Rosas <farosas@linux.ibm.com>\0" "Subject\0Re: [PATCH 1/1] powerpc/pseries: Interface to represent PAPR firmware attributes\0" - "Date\0Fri, 18 Jun 2021 20:58:10 +0000\0" + "Date\0Fri, 18 Jun 2021 17:58:10 -0300\0" "To\0Pratik R. Sampat <psampat@linux.ibm.com>" mpe@ellerman.id.au benh@kernel.crashing.org @@ -354,7 +354,7 @@ "> +\t * and save a HCALL\n" "> +\t */\n" "> +\tfor (idx = 0; idx < be64_to_cpu(em_buf->num_attr); idx++) {\n" - "> +\t\tif (pattr->id = be64_to_cpu(ea[idx].attr_id)) {\n" + "> +\t\tif (pattr->id == be64_to_cpu(ea[idx].attr_id)) {\n" "> +\t\t\tret = sprintf(buf, \"%s\\n\", ea[idx].attr_desc);\n" "> +\t\t\tif (ret < 0)\n" "> +\t\t\t\tret = -EIO;\n" @@ -375,7 +375,7 @@ "> +\tint data_offset, ret = 0;\n" "> +\n" "> +\tt_buf = kmalloc(sizeof(*t_buf), GFP_KERNEL);\n" - "> +\tif (t_buf = NULL)\n" + "> +\tif (t_buf == NULL)\n" "> +\t\treturn -ENOMEM;\n" "> +\n" "> +\tret = plpar_hcall_norets(H_GET_ENERGY_SCALE_INFO, 0,\n" @@ -419,7 +419,7 @@ "> +\tint data_offset, ret = 0;\n" "> +\n" "> +\tt_buf = kmalloc(sizeof(*t_buf), GFP_KERNEL);\n" - "> +\tif (t_buf = NULL)\n" + "> +\tif (t_buf == NULL)\n" "> +\t\treturn -ENOMEM;\n" "> +\n" "> +\tret = plpar_hcall_norets(H_GET_ENERGY_SCALE_INFO, 0,\n" @@ -490,7 +490,7 @@ "> +\tint ret, idx, i, data_offset;\n" "> +\n" "> +\tem_buf = kmalloc(sizeof(*em_buf), GFP_KERNEL);\n" - "> +\tif (em_buf = NULL)\n" + "> +\tif (em_buf == NULL)\n" "> +\t\treturn -ENOMEM;\n" "> +\t/*\n" "> +\t * hcall(\n" @@ -571,7 +571,7 @@ "> +\t\tpgs[idx].pg.name = buf;\n" "> +\n" "> +\t\t/* Do not add the value description if it does not exist */\n" - "> +\t\tif (strlen(ea[idx].attr_value_desc) = 0)\n" + "> +\t\tif (strlen(ea[idx].attr_value_desc) == 0)\n" "> +\t\t\tshow_val_desc = false;\n" "> +\n" "> +\t\tif (add_attr_group(be64_to_cpu(ea[idx].attr_id),\n" @@ -603,4 +603,4 @@ "> +\n" > +machine_device_initcall(pseries, papr_init); -f46129d572fd516658ed5c52fb9b0c86ab75122ded8173a588b68b85aeca052e +c05689cd6468bda395c4ec7096329138e8413b89f1f35734da974d3242c5c2ba
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.