From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3018C433E0 for ; Fri, 19 Mar 2021 09:34:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 76E4C64EFC for ; Fri, 19 Mar 2021 09:34:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229519AbhCSJeI convert rfc822-to-8bit (ORCPT ); Fri, 19 Mar 2021 05:34:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:35896 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229914AbhCSJdv (ORCPT ); Fri, 19 Mar 2021 05:33:51 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BDD0264F6B; Fri, 19 Mar 2021 09:33:50 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lNBVs-002Zft-R7; Fri, 19 Mar 2021 09:33:49 +0000 Date: Fri, 19 Mar 2021 09:33:47 +0000 Message-ID: <87wnu3h4hw.wl-maz@kernel.org> From: Marc Zyngier To: Marcin Wojtas Cc: Gregory CLEMENT , Sven Auhagen , axboe@kernel.dk, Hans de Goede , Rob Herring , Thomas Gleixner , Andrew Lunn , devicetree@vger.kernel.org, Antoine Tenart , viresh.kumar@linaro.org, rjw@rjwysocki.net, Maxime Chevallier , linux-ide@vger.kernel.org, Thomas Petazzoni , =?UTF-8?B?TWlxdcOobA==?= Raynal , linux-arm-kernel@lists.infradead.org, Grzegorz Jaszczyk , upstream@semihalf.com Subject: Re: [PATCH v3 0/9] Armada8k enable per-port SATA interrupts and drop a hack in the IRQ subsystem In-Reply-To: References: <20201109173948.96663-1-sven.auhagen@voleatech.de> <20210227105723.7i42cw376qmnozcp@SvensMacBookAir-2.local> <87czvviok9.fsf@BL-laptop> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: mw@semihalf.com, gregory.clement@bootlin.com, sven.auhagen@voleatech.de, axboe@kernel.dk, hdegoede@redhat.com, robh+dt@kernel.org, tglx@linutronix.de, andrew@lunn.ch, devicetree@vger.kernel.org, antoine.tenart@bootlin.com, viresh.kumar@linaro.org, rjw@rjwysocki.net, maxime.chevallier@bootlin.com, linux-ide@vger.kernel.org, thomas.petazzoni@bootlin.com, miquel.raynal@bootlin.com, linux-arm-kernel@lists.infradead.org, jaz@semihalf.com, upstream@semihalf.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org On Fri, 19 Mar 2021 08:08:34 +0000, Marcin Wojtas wrote: > > HI Gregory, > > pt., 19 mar 2021 o 08:35 Gregory CLEMENT > napisał(a): > > > > Hello Marcin, > > > > > [Resend in plain text] > > > > > > Hi, > > > > > > Just letting everyone know - merging only the DT part of this patchset > > > broke AHCI on all Marvell Armada 7k8k / CN913x platforms in v5.11 > > > release. > > > > It's unfortunate that we didn't know this when v5.11-rc1 was > > released. However it is still time for a fix, I will submit it. > > As I explained in the other email when I applied this I really though > > that the driver part will be applied, I don't know what happened here. > > > > Sure, looking at the thread it looks more of a communication issue. I > am also surprised the breakage went unnoticed for a while (unless > everyone is using edk2, like myself :) ). I think it would be good to > revert the change on top of v5.11.x. The drivers adoption would have to > land before v5.12 though, so that not to repeat the problem during next release. > > Small rant: > A general issue with the DT binding changes of this kind (previously > clocks, ICU, etc.) that I have, is a side effect of incompatibility > with older kernels/other OSs. The latter must follow the > modifications, but you can forget of booting e.g. Debian Buster with > the ToT device tree. Therefore in edk2 I do not update the device tree > fork to often and need to tweak it in order to have the widest support > coverage. Unfortunately, this has been the case for this machine since it became available. I can happily boot any kernel on other systems of the same vintage without touching anything firmware related, which is crucial to identify regressions. The A8k requires instead a per-kernel DT, something that only works if you treat it as an embedded system, and not a standard system (which is why mine has been collecting dust for some time now). I don't think the maintainers have ever been interested in solving this problem. As for ACPI, that'd probably be the best thing that can happen to this platform. Not sure that's remotely possible though, given how "interesting" the HW is. M. -- Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61544C433E0 for ; Fri, 19 Mar 2021 09:35:39 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E74E664F68 for ; Fri, 19 Mar 2021 09:35:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E74E664F68 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Subject:Cc:To: From:Message-ID:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2yf4tlSEYLXDkIBn9smtSTM5UwGjPmmCeROh90ryBic=; b=rN3plGUp5qrmbnAm/IEV+1VJf Rr26OkdOey1XNn7p6arUqipFAm/GTWVgKwY6U5R993iU52SfkyX9+u82fALpygegbjwP2g0WSoM1y PJaKyu33qi9Tsq606Fjz7D6Kh24LnpQBo7KWpKcHuCyFTg7nD31Qg8SB1pFQBMh8v5YG6FKqpiDy1 KOZRuhihqWdGdw0oJ3FjinUZQqC1wvyvuy0Dcqz/wSP0iuFs6eEs1s8V3+6TEaVdapnBtebNiFtkj Sjt1neibzhYIvJAjR1JVP6M4Lutgst3r41YBBzih0mvGQbFy66A5Gg1T1hbxIyKkMwESZT2wOv8RK qh/XUF07g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lNBW2-006xJG-71; Fri, 19 Mar 2021 09:33:58 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lNBVx-006xIx-EV for linux-arm-kernel@lists.infradead.org; Fri, 19 Mar 2021 09:33:55 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BDD0264F6B; Fri, 19 Mar 2021 09:33:50 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lNBVs-002Zft-R7; Fri, 19 Mar 2021 09:33:49 +0000 Date: Fri, 19 Mar 2021 09:33:47 +0000 Message-ID: <87wnu3h4hw.wl-maz@kernel.org> From: Marc Zyngier To: Marcin Wojtas Cc: Gregory CLEMENT , Sven Auhagen , axboe@kernel.dk, Hans de Goede , Rob Herring , Thomas Gleixner , Andrew Lunn , devicetree@vger.kernel.org, Antoine Tenart , viresh.kumar@linaro.org, rjw@rjwysocki.net, Maxime Chevallier , linux-ide@vger.kernel.org, Thomas Petazzoni , =?UTF-8?B?TWlxdcOobA==?= Raynal , linux-arm-kernel@lists.infradead.org, Grzegorz Jaszczyk , upstream@semihalf.com Subject: Re: [PATCH v3 0/9] Armada8k enable per-port SATA interrupts and drop a hack in the IRQ subsystem In-Reply-To: References: <20201109173948.96663-1-sven.auhagen@voleatech.de> <20210227105723.7i42cw376qmnozcp@SvensMacBookAir-2.local> <87czvviok9.fsf@BL-laptop> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: mw@semihalf.com, gregory.clement@bootlin.com, sven.auhagen@voleatech.de, axboe@kernel.dk, hdegoede@redhat.com, robh+dt@kernel.org, tglx@linutronix.de, andrew@lunn.ch, devicetree@vger.kernel.org, antoine.tenart@bootlin.com, viresh.kumar@linaro.org, rjw@rjwysocki.net, maxime.chevallier@bootlin.com, linux-ide@vger.kernel.org, thomas.petazzoni@bootlin.com, miquel.raynal@bootlin.com, linux-arm-kernel@lists.infradead.org, jaz@semihalf.com, upstream@semihalf.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210319_093353_872372_0996B9D9 X-CRM114-Status: GOOD ( 32.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCAxOSBNYXIgMjAyMSAwODowODozNCArMDAwMCwKTWFyY2luIFdvanRhcyA8bXdAc2Vt aWhhbGYuY29tPiB3cm90ZToKPiAKPiBISSBHcmVnb3J5LAo+IAo+IHB0LiwgMTkgbWFyIDIwMjEg byAwODozNSBHcmVnb3J5IENMRU1FTlQgPGdyZWdvcnkuY2xlbWVudEBib290bGluLmNvbT4KPiBu YXBpc2HFgihhKToKPiA+Cj4gPiBIZWxsbyBNYXJjaW4sCj4gPgo+ID4gPiBbUmVzZW5kIGluIHBs YWluIHRleHRdCj4gPiA+Cj4gPiA+IEhpLAo+ID4gPgo+ID4gPiBKdXN0IGxldHRpbmcgZXZlcnlv bmUga25vdyAtIG1lcmdpbmcgb25seSB0aGUgRFQgcGFydCBvZiB0aGlzIHBhdGNoc2V0Cj4gPiA+ IGJyb2tlIEFIQ0kgb24gYWxsIE1hcnZlbGwgQXJtYWRhIDdrOGsgLyBDTjkxM3ggcGxhdGZvcm1z IGluIHY1LjExCj4gPiA+IHJlbGVhc2UuCj4gPgo+ID4gSXQncyB1bmZvcnR1bmF0ZSB0aGF0IHdl IGRpZG4ndCBrbm93IHRoaXMgd2hlbiB2NS4xMS1yYzEgd2FzCj4gPiByZWxlYXNlZC4gSG93ZXZl ciBpdCBpcyBzdGlsbCB0aW1lIGZvciBhIGZpeCwgSSB3aWxsIHN1Ym1pdCBpdC4KPiA+IEFzIEkg ZXhwbGFpbmVkIGluIHRoZSBvdGhlciBlbWFpbCB3aGVuIEkgYXBwbGllZCB0aGlzIEkgcmVhbGx5 IHRob3VnaAo+ID4gdGhhdCB0aGUgZHJpdmVyIHBhcnQgd2lsbCBiZSBhcHBsaWVkLCBJIGRvbid0 IGtub3cgd2hhdCBoYXBwZW5lZCBoZXJlLgo+ID4KPiAKPiBTdXJlLCBsb29raW5nIGF0IHRoZSB0 aHJlYWQgaXQgbG9va3MgbW9yZSBvZiBhIGNvbW11bmljYXRpb24gaXNzdWUuIEkKPiBhbSBhbHNv IHN1cnByaXNlZCB0aGUgYnJlYWthZ2Ugd2VudCB1bm5vdGljZWQgZm9yIGEgd2hpbGUgKHVubGVz cwo+IGV2ZXJ5b25lIGlzIHVzaW5nIGVkazIsIGxpa2UgbXlzZWxmIDopICkuIEkgdGhpbmsgaXQg d291bGQgYmUgZ29vZCB0bwo+IHJldmVydCB0aGUgY2hhbmdlIG9uIHRvcCBvZiB2NS4xMS54LiBU aGUgZHJpdmVycyBhZG9wdGlvbiB3b3VsZCBoYXZlIHRvCj4gbGFuZCBiZWZvcmUgdjUuMTIgdGhv dWdoLCBzbyB0aGF0IG5vdCB0byByZXBlYXQgdGhlIHByb2JsZW0gZHVyaW5nIG5leHQgcmVsZWFz ZS4KPiAKPiBTbWFsbCByYW50Ogo+IEEgZ2VuZXJhbCBpc3N1ZSB3aXRoIHRoZSBEVCBiaW5kaW5n IGNoYW5nZXMgb2YgdGhpcyBraW5kIChwcmV2aW91c2x5Cj4gY2xvY2tzLCBJQ1UsIGV0Yy4pIHRo YXQgSSBoYXZlLCBpcyBhIHNpZGUgZWZmZWN0IG9mIGluY29tcGF0aWJpbGl0eQo+IHdpdGggb2xk ZXIga2VybmVscy9vdGhlciBPU3MuIFRoZSBsYXR0ZXIgbXVzdCBmb2xsb3cgdGhlCj4gbW9kaWZp Y2F0aW9ucywgYnV0IHlvdSBjYW4gZm9yZ2V0IG9mIGJvb3RpbmcgZS5nLiBEZWJpYW4gQnVzdGVy IHdpdGgKPiB0aGUgVG9UIGRldmljZSB0cmVlLiBUaGVyZWZvcmUgaW4gZWRrMiBJIGRvIG5vdCB1 cGRhdGUgdGhlIGRldmljZSB0cmVlCj4gZm9yayB0byBvZnRlbiBhbmQgbmVlZCB0byB0d2VhayBp dCBpbiBvcmRlciB0byBoYXZlIHRoZSB3aWRlc3Qgc3VwcG9ydAo+IGNvdmVyYWdlLgoKVW5mb3J0 dW5hdGVseSwgdGhpcyBoYXMgYmVlbiB0aGUgY2FzZSBmb3IgdGhpcyBtYWNoaW5lIHNpbmNlIGl0 IGJlY2FtZQphdmFpbGFibGUuIEkgY2FuIGhhcHBpbHkgYm9vdCBhbnkga2VybmVsIG9uIG90aGVy IHN5c3RlbXMgb2YgdGhlIHNhbWUKdmludGFnZSB3aXRob3V0IHRvdWNoaW5nIGFueXRoaW5nIGZp cm13YXJlIHJlbGF0ZWQsIHdoaWNoIGlzIGNydWNpYWwKdG8gaWRlbnRpZnkgcmVncmVzc2lvbnMu CgpUaGUgQThrIHJlcXVpcmVzIGluc3RlYWQgYSBwZXIta2VybmVsIERULCBzb21ldGhpbmcgdGhh dCBvbmx5IHdvcmtzIGlmCnlvdSB0cmVhdCBpdCBhcyBhbiBlbWJlZGRlZCBzeXN0ZW0sIGFuZCBu b3QgYSBzdGFuZGFyZCBzeXN0ZW0gKHdoaWNoCmlzIHdoeSBtaW5lIGhhcyBiZWVuIGNvbGxlY3Rp bmcgZHVzdCBmb3Igc29tZSB0aW1lIG5vdykuIEkgZG9uJ3QgdGhpbmsKdGhlIG1haW50YWluZXJz IGhhdmUgZXZlciBiZWVuIGludGVyZXN0ZWQgaW4gc29sdmluZyB0aGlzIHByb2JsZW0uCgpBcyBm b3IgQUNQSSwgdGhhdCdkIHByb2JhYmx5IGJlIHRoZSBiZXN0IHRoaW5nIHRoYXQgY2FuIGhhcHBl biB0byB0aGlzCnBsYXRmb3JtLiBOb3Qgc3VyZSB0aGF0J3MgcmVtb3RlbHkgcG9zc2libGUgdGhv dWdoLCBnaXZlbiBob3cKImludGVyZXN0aW5nIiB0aGUgSFcgaXMuCgoJTS4KCi0tIApXaXRob3V0 IGRldmlhdGlvbiBmcm9tIHRoZSBub3JtLCBwcm9ncmVzcyBpcyBub3QgcG9zc2libGUuCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2Vy bmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVs Cg==