All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/tcpdump: remove duplicated binary
Date: Tue, 16 Feb 2021 21:46:41 +0200	[thread overview]
Message-ID: <87wnv77q3i.fsf@tarshish> (raw)
In-Reply-To: <20210216125031.2244-1-patrickdepinguin@gmail.com>

Hi Thomas,

On Tue, Feb 16 2021, Thomas De Schampheleire wrote:

> From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
>
> Since tcpdump 4.99.0, the 'tcpdump' binary is no longer installed in
> /usr/sbin but in /usr/bin. This change invalidates the Buildroot hook
> 'TCPDUMP_REMOVE_DUPLICATED_BINARY', causing a fairly large rootfs size
> increase as a result.
>
> Update the path inside this hook.
>
> Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>

Acked-by: Baruch Siach <baruch@tkos.co.il>

Thanks,
baruch

> ---
>  package/tcpdump/tcpdump.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/tcpdump/tcpdump.mk b/package/tcpdump/tcpdump.mk
> index f8ea6576ee..c562034a4e 100644
> --- a/package/tcpdump/tcpdump.mk
> +++ b/package/tcpdump/tcpdump.mk
> @@ -22,7 +22,7 @@ TCPDUMP_SELINUX_MODULES = netutils
>  
>  # make install installs an unneeded extra copy of the tcpdump binary
>  define TCPDUMP_REMOVE_DUPLICATED_BINARY
> -	rm -f $(TARGET_DIR)/usr/sbin/tcpdump.$(TCPDUMP_VERSION)
> +	rm -f $(TARGET_DIR)/usr/bin/tcpdump.$(TCPDUMP_VERSION)
>  endef
>  
>  TCPDUMP_POST_INSTALL_TARGET_HOOKS += TCPDUMP_REMOVE_DUPLICATED_BINARY


-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

      parent reply	other threads:[~2021-02-16 19:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-16 12:50 [Buildroot] [PATCH] package/tcpdump: remove duplicated binary Thomas De Schampheleire
2021-02-16 19:46 ` Peter Korsgaard
2021-02-16 19:46 ` Baruch Siach [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wnv77q3i.fsf@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.