From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE6A7C433DB for ; Sun, 10 Jan 2021 17:15:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 87C5D22B2C for ; Sun, 10 Jan 2021 17:15:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726768AbhAJRPC convert rfc822-to-8bit (ORCPT ); Sun, 10 Jan 2021 12:15:02 -0500 Received: from guitar.tcltek.co.il ([192.115.133.116]:42430 "EHLO mx.tkos.co.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726228AbhAJRPB (ORCPT ); Sun, 10 Jan 2021 12:15:01 -0500 Received: from tarshish (unknown [10.0.8.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.tkos.co.il (Postfix) with ESMTPS id DD3584400C5; Sun, 10 Jan 2021 19:14:17 +0200 (IST) References: <22d1fe7b2137e3a2660ab2e6f1f127d41493fb16.1609917364.git.baruch@tkos.co.il> <20210107142953.ifg5yuy3dsblgsju@pengutronix.de> User-agent: mu4e 1.4.13; emacs 27.1 From: Baruch Siach To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Thierry Reding , Lee Jones , Linus Walleij , Bartosz Golaszewski , Rob Herring , Russell King , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Thomas Petazzoni , Chris Packham , Sascha Hauer , Ralph Sennhauser , linux-pwm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH v6 1/4] gpio: mvebu: fix pwm get_state period calculation In-reply-to: <20210107142953.ifg5yuy3dsblgsju@pengutronix.de> Date: Sun, 10 Jan 2021 19:14:17 +0200 Message-ID: <87wnwkyas6.fsf@tarshish> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi Uwe, Thanks for your review comments. On Thu, Jan 07 2021, Uwe Kleine-König wrote: > On Wed, Jan 06, 2021 at 09:37:37AM +0200, Baruch Siach wrote: >> The period is the sum of on and off values. >> >> Reported-by: Russell King >> Fixes: 757642f9a584e ("gpio: mvebu: Add limited PWM support") >> Signed-off-by: Baruch Siach >> --- >> v6: divide (on + off) sum to reduce rounding error (RMK) >> --- >> drivers/gpio/gpio-mvebu.c | 19 ++++++++----------- >> 1 file changed, 8 insertions(+), 11 deletions(-) >> >> diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c >> index 672681a976f5..a912a8fed197 100644 >> --- a/drivers/gpio/gpio-mvebu.c >> +++ b/drivers/gpio/gpio-mvebu.c >> @@ -676,20 +676,17 @@ static void mvebu_pwm_get_state(struct pwm_chip *chip, >> else >> state->duty_cycle = 1; >> >> + val = (unsigned long long) u; /* on duration */ >> regmap_read(mvpwm->regs, mvebu_pwmreg_blink_off_duration(mvpwm), &u); >> - val = (unsigned long long) u * NSEC_PER_SEC; >> + val += (unsigned long long) u; /* period = on + off duration */ >> + val *= NSEC_PER_SEC; >> do_div(val, mvpwm->clk_rate); >> - if (val < state->duty_cycle) { >> + if (val > UINT_MAX) >> + state->period = UINT_MAX; > > state->period is an u64, so there is no reason to not use values greater > than UINT_MAX. I'll post a patch for that. >> + else if (val) >> + state->period = val; >> + else >> state->period = 1; > > This case assigning 1 looks strange. An explanation in a comment would > be great. I wonder if this is a hardware property or if it is only used > to not report 0 in case that mvpwm->clk_rate is high. I guess that this is because 0 period does not make sense for pwm. It is like a zero divisor. What is the common behavior? > I found a few further shortcommings in the mvebu_pwm implementation while > looking through it: > > a) The rounding problem that RMK found is also present in .apply > > There we have: > > val = clk_rate * (period - duty_cycle) / NSEC_PER_SEC > > while > > val = clk_rate * period / NSEC_PER_SEC - on > > would be more exact. I'll post a patch for that. > b) To make > > pwm_get_state(pwm, &state); > pwm_apply_state(pwm, &state); > > idempotent .get_state should round up the division results. I'll post a patch for that as well. > c) .apply also has a check for val being zero and configures at least 1 > cycle for the on and off intervals. Is this a hardware imposed > limitation? Not sure what was the original intention. Maybe Andrew can explain. On my hardware (Armada 8040), zero 'on' value does not work as expected. There is a blink once in a long while. Maybe this is the reason? As I understand, all these issues should not block this patch, right? BTW, the key you used to sign your message is expired since 2020-01-10 on the key server I use (keys.gnupg.net). Where can I find your updated key? Thanks, baruch -- ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il - From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFD43C433E0 for ; Sun, 10 Jan 2021 17:16:19 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9F241224D2 for ; Sun, 10 Jan 2021 17:16:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9F241224D2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=tkos.co.il Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:In-reply-to:Subject:To: From:References:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bKkx/QD/1w7Rq3nk/pQ0CUsMCouDx+7GrlMQSOhsDRw=; b=loa4bBoRWsxrNM5J0bbFeZvKH kL1dJHwuq6aB9e4V90WPOAtD1Cwzcm8Hp9VlOEtUMt9QQqJs4fwyBW0o+KzfhBxPMWMRL2C+J3I/I CJ1TFhgybUabXJHU/g7TnY+1hhl3uaag8db9yzMLnO28jpZw8Z8qzhbJPpYkp6+NMdp0h331pf0hy O+0kCRt3LL+GxRykg/sgG/p5TmbuCi6VU6dBAXthCecCk3sFSr9rWur1erQSJctSIHwaHEIEdZorg xMWIMci3GAL5u6dbOXG52rw0eYm6d5tOyrNX4CdsLm4FYUKJxUBUsPlbQoL4VUJP/t51QaCFoF3Q7 kzELw9klg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kyeIM-0002A9-Pv; Sun, 10 Jan 2021 17:14:26 +0000 Received: from guitar.tcltek.co.il ([192.115.133.116] helo=mx.tkos.co.il) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kyeIJ-00028U-Ha for linux-arm-kernel@lists.infradead.org; Sun, 10 Jan 2021 17:14:25 +0000 Received: from tarshish (unknown [10.0.8.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.tkos.co.il (Postfix) with ESMTPS id DD3584400C5; Sun, 10 Jan 2021 19:14:17 +0200 (IST) References: <22d1fe7b2137e3a2660ab2e6f1f127d41493fb16.1609917364.git.baruch@tkos.co.il> <20210107142953.ifg5yuy3dsblgsju@pengutronix.de> User-agent: mu4e 1.4.13; emacs 27.1 From: Baruch Siach To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Subject: Re: [PATCH v6 1/4] gpio: mvebu: fix pwm get_state period calculation In-reply-to: <20210107142953.ifg5yuy3dsblgsju@pengutronix.de> Date: Sun, 10 Jan 2021 19:14:17 +0200 Message-ID: <87wnwkyas6.fsf@tarshish> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210110_121424_053286_6FAC4817 X-CRM114-Status: GOOD ( 31.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Sascha Hauer , linux-pwm@vger.kernel.org, Linus Walleij , Chris Packham , Russell King , Rob Herring , Bartosz Golaszewski , devicetree@vger.kernel.org, Thierry Reding , Thomas Petazzoni , linux-gpio@vger.kernel.org, Ralph Sennhauser , Lee Jones , Gregory Clement , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgVXdlLAoKVGhhbmtzIGZvciB5b3VyIHJldmlldyBjb21tZW50cy4KCk9uIFRodSwgSmFuIDA3 IDIwMjEsIFV3ZSBLbGVpbmUtS8O2bmlnIHdyb3RlOgo+IE9uIFdlZCwgSmFuIDA2LCAyMDIxIGF0 IDA5OjM3OjM3QU0gKzAyMDAsIEJhcnVjaCBTaWFjaCB3cm90ZToKPj4gVGhlIHBlcmlvZCBpcyB0 aGUgc3VtIG9mIG9uIGFuZCBvZmYgdmFsdWVzLgo+PiAKPj4gUmVwb3J0ZWQtYnk6IFJ1c3NlbGwg S2luZyA8bGludXhAYXJtbGludXgub3JnLnVrPgo+PiBGaXhlczogNzU3NjQyZjlhNTg0ZSAoImdw aW86IG12ZWJ1OiBBZGQgbGltaXRlZCBQV00gc3VwcG9ydCIpCj4+IFNpZ25lZC1vZmYtYnk6IEJh cnVjaCBTaWFjaCA8YmFydWNoQHRrb3MuY28uaWw+Cj4+IC0tLQo+PiB2NjogZGl2aWRlIChvbiAr IG9mZikgc3VtIHRvIHJlZHVjZSByb3VuZGluZyBlcnJvciAoUk1LKQo+PiAtLS0KPj4gIGRyaXZl cnMvZ3Bpby9ncGlvLW12ZWJ1LmMgfCAxOSArKysrKysrKy0tLS0tLS0tLS0tCj4+ICAxIGZpbGUg Y2hhbmdlZCwgOCBpbnNlcnRpb25zKCspLCAxMSBkZWxldGlvbnMoLSkKPj4gCj4+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwaW8vZ3Bpby1tdmVidS5jIGIvZHJpdmVycy9ncGlvL2dwaW8tbXZlYnUu Ywo+PiBpbmRleCA2NzI2ODFhOTc2ZjUuLmE5MTJhOGZlZDE5NyAxMDA2NDQKPj4gLS0tIGEvZHJp dmVycy9ncGlvL2dwaW8tbXZlYnUuYwo+PiArKysgYi9kcml2ZXJzL2dwaW8vZ3Bpby1tdmVidS5j Cj4+IEBAIC02NzYsMjAgKzY3NiwxNyBAQCBzdGF0aWMgdm9pZCBtdmVidV9wd21fZ2V0X3N0YXRl KHN0cnVjdCBwd21fY2hpcCAqY2hpcCwKPj4gIAllbHNlCj4+ICAJCXN0YXRlLT5kdXR5X2N5Y2xl ID0gMTsKPj4gIAo+PiArCXZhbCA9ICh1bnNpZ25lZCBsb25nIGxvbmcpIHU7IC8qIG9uIGR1cmF0 aW9uICovCj4+ICAJcmVnbWFwX3JlYWQobXZwd20tPnJlZ3MsIG12ZWJ1X3B3bXJlZ19ibGlua19v ZmZfZHVyYXRpb24obXZwd20pLCAmdSk7Cj4+IC0JdmFsID0gKHVuc2lnbmVkIGxvbmcgbG9uZykg dSAqIE5TRUNfUEVSX1NFQzsKPj4gKwl2YWwgKz0gKHVuc2lnbmVkIGxvbmcgbG9uZykgdTsgLyog cGVyaW9kID0gb24gKyBvZmYgZHVyYXRpb24gKi8KPj4gKwl2YWwgKj0gTlNFQ19QRVJfU0VDOwo+ PiAgCWRvX2Rpdih2YWwsIG12cHdtLT5jbGtfcmF0ZSk7Cj4+IC0JaWYgKHZhbCA8IHN0YXRlLT5k dXR5X2N5Y2xlKSB7Cj4+ICsJaWYgKHZhbCA+IFVJTlRfTUFYKQo+PiArCQlzdGF0ZS0+cGVyaW9k ID0gVUlOVF9NQVg7Cj4KPiBzdGF0ZS0+cGVyaW9kIGlzIGFuIHU2NCwgc28gdGhlcmUgaXMgbm8g cmVhc29uIHRvIG5vdCB1c2UgdmFsdWVzIGdyZWF0ZXIKPiB0aGFuIFVJTlRfTUFYLgoKSSdsbCBw b3N0IGEgcGF0Y2ggZm9yIHRoYXQuCgo+PiArCWVsc2UgaWYgKHZhbCkKPj4gKwkJc3RhdGUtPnBl cmlvZCA9IHZhbDsKPj4gKwllbHNlCj4+ICAJCXN0YXRlLT5wZXJpb2QgPSAxOwo+Cj4gVGhpcyBj YXNlIGFzc2lnbmluZyAxIGxvb2tzIHN0cmFuZ2UuIEFuIGV4cGxhbmF0aW9uIGluIGEgY29tbWVu dCB3b3VsZAo+IGJlIGdyZWF0LiBJIHdvbmRlciBpZiB0aGlzIGlzIGEgaGFyZHdhcmUgcHJvcGVy dHkgb3IgaWYgaXQgaXMgb25seSB1c2VkCj4gdG8gbm90IHJlcG9ydCAwIGluIGNhc2UgdGhhdCBt dnB3bS0+Y2xrX3JhdGUgaXMgaGlnaC4KCkkgZ3Vlc3MgdGhhdCB0aGlzIGlzIGJlY2F1c2UgMCBw ZXJpb2QgZG9lcyBub3QgbWFrZSBzZW5zZSBmb3IgcHdtLiBJdCBpcwpsaWtlIGEgemVybyBkaXZp c29yLiBXaGF0IGlzIHRoZSBjb21tb24gYmVoYXZpb3I/Cgo+IEkgZm91bmQgYSBmZXcgZnVydGhl ciBzaG9ydGNvbW1pbmdzIGluIHRoZSBtdmVidV9wd20gaW1wbGVtZW50YXRpb24gd2hpbGUKPiBs b29raW5nIHRocm91Z2ggaXQ6Cj4KPiAgYSkgVGhlIHJvdW5kaW5nIHByb2JsZW0gdGhhdCBSTUsg Zm91bmQgaXMgYWxzbyBwcmVzZW50IGluIC5hcHBseQo+Cj4gICAgIFRoZXJlIHdlIGhhdmU6Cj4K PiAgICAgCXZhbCA9IGNsa19yYXRlICogKHBlcmlvZCAtIGR1dHlfY3ljbGUpIC8gTlNFQ19QRVJf U0VDCj4KPiAgICAgd2hpbGUKPgo+ICAgICAJdmFsID0gY2xrX3JhdGUgKiBwZXJpb2QgLyBOU0VD X1BFUl9TRUMgLSBvbgo+Cj4gICAgIHdvdWxkIGJlIG1vcmUgZXhhY3QuCgpJJ2xsIHBvc3QgYSBw YXRjaCBmb3IgdGhhdC4KCj4gIGIpIFRvIG1ha2UKPgo+ICAJcHdtX2dldF9zdGF0ZShwd20sICZz dGF0ZSk7Cj4gCXB3bV9hcHBseV9zdGF0ZShwd20sICZzdGF0ZSk7Cj4KPiAgICAgaWRlbXBvdGVu dCAuZ2V0X3N0YXRlIHNob3VsZCByb3VuZCB1cCB0aGUgZGl2aXNpb24gcmVzdWx0cy4KCkknbGwg cG9zdCBhIHBhdGNoIGZvciB0aGF0IGFzIHdlbGwuCgo+ICBjKSAuYXBwbHkgYWxzbyBoYXMgYSBj aGVjayBmb3IgdmFsIGJlaW5nIHplcm8gYW5kIGNvbmZpZ3VyZXMgYXQgbGVhc3QgMQo+ICAgICBj eWNsZSBmb3IgdGhlIG9uIGFuZCBvZmYgaW50ZXJ2YWxzLiBJcyB0aGlzIGEgaGFyZHdhcmUgaW1w b3NlZAo+ICAgICBsaW1pdGF0aW9uPyAKCk5vdCBzdXJlIHdoYXQgd2FzIHRoZSBvcmlnaW5hbCBp bnRlbnRpb24uIE1heWJlIEFuZHJldyBjYW4gZXhwbGFpbi4KCk9uIG15IGhhcmR3YXJlIChBcm1h ZGEgODA0MCksIHplcm8gJ29uJyB2YWx1ZSBkb2VzIG5vdCB3b3JrIGFzCmV4cGVjdGVkLiBUaGVy ZSBpcyBhIGJsaW5rIG9uY2UgaW4gYSBsb25nIHdoaWxlLiBNYXliZSB0aGlzIGlzIHRoZQpyZWFz b24/CgpBcyBJIHVuZGVyc3RhbmQsIGFsbCB0aGVzZSBpc3N1ZXMgc2hvdWxkIG5vdCBibG9jayB0 aGlzIHBhdGNoLCByaWdodD8KCkJUVywgdGhlIGtleSB5b3UgdXNlZCB0byBzaWduIHlvdXIgbWVz c2FnZSBpcyBleHBpcmVkIHNpbmNlIDIwMjAtMDEtMTAKb24gdGhlIGtleSBzZXJ2ZXIgSSB1c2Ug KGtleXMuZ251cGcubmV0KS4gV2hlcmUgY2FuIEkgZmluZCB5b3VyIHVwZGF0ZWQKa2V5PwoKVGhh bmtzLApiYXJ1Y2gKCi0tIAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIH4uIC5+ICAgVGsgT3BlbiBTeXN0ZW1zCj19LS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tb29PLS1VLS1Pb28tLS0tLS0tLS0tLS17PQog ICAtIGJhcnVjaEB0a29zLmNvLmlsIC0gdGVsOiArOTcyLjUyLjM2OC40NjU2LCBodHRwOi8vd3d3 LnRrb3MuY28uaWwgLQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0 cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGlu Zm8vbGludXgtYXJtLWtlcm5lbAo=