From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31233C433DB for ; Fri, 8 Jan 2021 13:15:20 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CA4BC23788 for ; Fri, 8 Jan 2021 13:15:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CA4BC23788 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EECB76E48D; Fri, 8 Jan 2021 13:15:18 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id BA73A6E32A for ; Fri, 8 Jan 2021 13:15:17 +0000 (UTC) IronPort-SDR: 7LlbwrSRf/5JveoY2WaGUt4tQSJmJw5/AuRfKWLFy9AHDZJ4aL+mHqf09fFgimIJwWjtwNoP8R uodNliHmLkEA== X-IronPort-AV: E=McAfee;i="6000,8403,9857"; a="177691016" X-IronPort-AV: E=Sophos;i="5.79,331,1602572400"; d="scan'208";a="177691016" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jan 2021 05:15:17 -0800 IronPort-SDR: 1SaHjesLBWGeBpjY92wdZttqeq0XLCTXAX8wAyWIjCLp2gifUd+chPqW7Z4UMIJaULhgnRQLgo 0VVqOh28wh0A== X-IronPort-AV: E=Sophos;i="5.79,331,1602572400"; d="scan'208";a="380120904" Received: from rgwhiteh-mobl.ger.corp.intel.com (HELO localhost) ([10.213.205.160]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jan 2021 05:15:15 -0800 From: Jani Nikula To: "Nautiyal\, Ankit K" , Chris Wilson , intel-gfx@lists.freedesktop.org In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20201223103917.14687-1-chris@chris-wilson.co.uk> <87a6u4okvl.fsf@intel.com> Date: Fri, 08 Jan 2021 15:15:12 +0200 Message-ID: <87wnwny3hb.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: Bitwise or the conversion colour specifier together X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, 24 Dec 2020, "Nautiyal, Ankit K" wrote: > Thanks Chris to catch this. > > This definitely should be bitwise Operator, as mentioned by Jani is > right thing to do. > > The PCON which I had access to, had the F/W which was using 303Ch > (previously proposed) for color conversion capability, instead of what > is latest mentioned in the spec ie. 83h. > > While testing, I had to skip this line of code, and hardcoded to older > register ie. 303Ch. > > I Will get this patch tested and update. In the mean time, the topic/dp-hdmi-2.1-pcon branch has been merged to drm-next and backmerged to drm-intel-next. So drm-intel-next is where the fixes should now land. BR, Jani. > > > Thanks & Regards, > > Ankit > > > On 12/23/2020 4:21 PM, Jani Nikula wrote: >> On Wed, 23 Dec 2020, Chris Wilson wrote: >>> drivers/gpu/drm/i915/display/intel_dp.c:6922 intel_dp_update_420() warn: should this be a bitwise op? >>> drivers/gpu/drm/i915/display/intel_dp.c:6922 intel_dp_update_420() warn: should this be a bitwise op? >>> drivers/gpu/drm/i915/display/intel_dp.c:6923 intel_dp_update_420() warn: should this be a bitwise op? >>> >>> Inside drm_dp_downstream_rgb_to_ycbcr_conversion(), that paramter >>> 'color_spc' is used as return port_cap[3] & color_spc, implying that it >>> is indeed a mask and not a boolean value. >> So this one belongs in topic/dp-hdmi-2.1-pcon branch. >> >> Purely based on the context this is the right thing to do, so: >> >> Reviewed-by: Jani Nikula >> >> Ankit, please test the patch in case it uncovers some other >> issues. It'll impact the RGB to YCbCr conversion. >> >> BR, >> Jani. >> >> >>> Fixes: 522508b665df ("drm/i915/display: Let PCON convert from RGB to YCbCr if it can") >>> Signed-off-by: Chris Wilson >>> Cc: Uma Shankar >>> Cc: Ankit Nautiyal >>> Cc: Jani Nikula >>> --- >>> drivers/gpu/drm/i915/display/intel_dp.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c >>> index 8b4b2ea52859..157a850a83a7 100644 >>> --- a/drivers/gpu/drm/i915/display/intel_dp.c >>> +++ b/drivers/gpu/drm/i915/display/intel_dp.c >>> @@ -6918,8 +6918,8 @@ intel_dp_update_420(struct intel_dp *intel_dp) >>> intel_dp->downstream_ports); >>> rgb_to_ycbcr = drm_dp_downstream_rgb_to_ycbcr_conversion(intel_dp->dpcd, >>> intel_dp->downstream_ports, >>> - DP_DS_HDMI_BT601_RGB_YCBCR_CONV || >>> - DP_DS_HDMI_BT709_RGB_YCBCR_CONV || >>> + DP_DS_HDMI_BT601_RGB_YCBCR_CONV | >>> + DP_DS_HDMI_BT709_RGB_YCBCR_CONV | >>> DP_DS_HDMI_BT2020_RGB_YCBCR_CONV); >>> >>> if (INTEL_GEN(i915) >= 11) { > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx