From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F241DC433FE for ; Wed, 9 Dec 2020 15:24:30 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ADF4B23AA8 for ; Wed, 9 Dec 2020 15:24:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ADF4B23AA8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5B0936EA8A; Wed, 9 Dec 2020 15:24:30 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id E0E046EA8A for ; Wed, 9 Dec 2020 15:24:28 +0000 (UTC) IronPort-SDR: 1jqTXMQaFzEfACAnue8SXWziO81Q5NUMh9tJIiUiSw0ET/jmHBHC+b6/QFuFfbDK8NF1tUcZx/ ZoqkssNpHRGw== X-IronPort-AV: E=McAfee;i="6000,8403,9829"; a="170583688" X-IronPort-AV: E=Sophos;i="5.78,405,1599548400"; d="scan'208";a="170583688" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Dec 2020 07:24:28 -0800 IronPort-SDR: xEvkaOO2zmfCqIN8XLHjzaeODfDz83wzSHP2MGOZ9q3su1bvojSlEK1VsPEts9zpnvitInEAOB hTvth+DsbrDg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,405,1599548400"; d="scan'208";a="364179008" Received: from gaia.fi.intel.com ([10.237.72.192]) by orsmga008.jf.intel.com with ESMTP; 09 Dec 2020 07:24:27 -0800 Received: by gaia.fi.intel.com (Postfix, from userid 1000) id BC3805C2003; Wed, 9 Dec 2020 17:22:11 +0200 (EET) From: Mika Kuoppala To: Chris Wilson , intel-gfx@lists.freedesktop.org In-Reply-To: <20201208231834.24812-2-chris@chris-wilson.co.uk> References: <20201208231834.24812-1-chris@chris-wilson.co.uk> <20201208231834.24812-2-chris@chris-wilson.co.uk> Date: Wed, 09 Dec 2020 17:22:11 +0200 Message-ID: <87wnxrknrw.fsf@gaia.fi.intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH 2/3] drm/i915: Sleep around performing iommu unmaps on Tigerlake X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chris Wilson Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Chris Wilson writes: > Tigerlake is plagued by spontaneous DMAR faults [reason 7, next page > table ptr is invalid] which lead to GPU hangs. These faults occur when > an iommu map is immediately reused. Adding further clflushes and > barriers around either the GTT PTE or iommu PTE updates do not prevent > the faults. So far the only effect has been from inducing a delay > between reuse of the iommu on the GPU. > > Signed-off-by: Chris Wilson > Cc: Mika Kuoppala Acked-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/gt/intel_ggtt.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_ggtt.c b/drivers/gpu/drm/i915/gt/intel_ggtt.c > index cf94525be2c1..f5b981443117 100644 > --- a/drivers/gpu/drm/i915/gt/intel_ggtt.c > +++ b/drivers/gpu/drm/i915/gt/intel_ggtt.c > @@ -101,7 +101,16 @@ static bool needs_idle_maps(struct drm_i915_private *i915) > * Query intel_iommu to see if we need the workaround. Presumably that > * was loaded first. > */ > - return IS_GEN(i915, 5) && IS_MOBILE(i915) && intel_vtd_active(); > + if (!intel_vtd_active()) > + return false; > + > + if (IS_GEN(i915, 5) && IS_MOBILE(i915)) > + return true; > + > + if (IS_GEN(i915, 12)) > + return true; /* XXX DMAR fault reason 7 */ > + > + return false; > } > > void i915_ggtt_suspend(struct i915_ggtt *ggtt) > -- > 2.20.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx