From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F91FC388F9 for ; Tue, 27 Oct 2020 12:44:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8F84120757 for ; Tue, 27 Oct 2020 12:44:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gzd1e5d5"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="Ck9y9jNd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F84120757 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6mkAhY4MAaeykVeh2uELLHKAf/SYJqiI0etLcL89G88=; b=gzd1e5d5sC0/CUXA75W1cOuF5 YP217qJm+IHLHSiG/dYiTYpanCW0fsHyPidQ+uDyQ1FFPPaxUeWBNV4BIGCejl9pR4ZK0rzj1ssTj r0WYy4StXw8a/M0SfhfFsM+CcVECrCyoYLeWrAwsavFh4G1z5KYV28U26a/x6sPt+3x+urQSEeWdu TROiHjcXXIl9gSuss4FYItC7m8QHqwIIEYj0/PBzE9BHB+5pgbosW/TlwL4m5CGVnQaAQaPeTYkKX 38BMdoLO8c66eKd8Q7gm8kcMzI4qD5ZkTKCRAjr8zaA18zwiIkn7ioc/HLtM5vT7m+fho4Rw0jcNw ki7cGBeew==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXOKn-0006Xe-8q; Tue, 27 Oct 2020 12:44:17 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXOKk-0006VH-HF for linux-mediatek@lists.infradead.org; Tue, 27 Oct 2020 12:44:16 +0000 Received: by mail-wr1-x442.google.com with SMTP id b8so1784966wrn.0 for ; Tue, 27 Oct 2020 05:44:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=HBFttdYAiRM1KfFacsdZju3R8FEz52UG6psn2mn812k=; b=Ck9y9jNdJH1H9KVu2owJyTBu42rV4XSWLdMUbByrEIQhakBN7YO3viBNE7ywGE3yJV 21nxkfIOqKJYmVR7phi6Mzl7xabBrqCSHVDvC6wQjQdXQwgh7fpBlxLd0spJm6TD1f/z i8rfkkdL3rv1kNNzjwl5ccwoTqDMuUQz+sXBzzY6oWTJcr7pbtuUho/VDBaGCbA+JUFy 8rFIc0Mph/wTGNCdJiEdu+j+TUPeGOqq7vp55s9RrKz7oPhApmbGbRXD5yrp3Ko8tRiS uvrWHwR+8dFXWShuf4c5KsxIDyJiXxw78K3ZGM/ChFHu1dDwpDKmBilfGofXcucVgkOj pjKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=HBFttdYAiRM1KfFacsdZju3R8FEz52UG6psn2mn812k=; b=G3dYcU9PhyBACB9E6hrb4wfoyt01opf7zwuoKzsciHUP5Ccmlziwdy+MxiVWtdPbTh 1h9Huz+qBRdm2E2XsTvUJyevBSIGHJHsljKFWGb7MpAKNcGHwcxBo2DC6EIr6jq2jMxR mTLyJ8lr+wnAUuVF443DUEE9nPAZDI1oNOBtQEQKfZmzCxkCEnQrNPSi1BC8PdW/xbZ9 evMgvb7XwAzPSnY1Rv2YvmfaIua9xADeW1HjqRmNoWjkR+bswtSsnL4YMEq8JxVq2VJH ixC0CUKwEw2475mXnRamhR+9hGeHhS7UdrLDoqTJvksY2yCmOyZhVDnBhO8PxeW479B9 KdkQ== X-Gm-Message-State: AOAM532GZUleefFiQRpq4QkCusdYpfZ06NQaHX0laA7s3w6gAjUWF8Fk De72pYIjEsnpX1tI+/J3yW75MA== X-Google-Smtp-Source: ABdhPJxGIvXpfpZxv774x6oG+TdKSVGildynsy97gcSuNQ0khyKnhSHNQjEj6Ais+Xmhl4PIo0XW7A== X-Received: by 2002:adf:84a5:: with SMTP id 34mr2855003wrg.152.1603802651408; Tue, 27 Oct 2020 05:44:11 -0700 (PDT) Received: from localhost ([2a01:cb19:8ae7:9d00:68a3:7a03:6c11:8947]) by smtp.gmail.com with ESMTPSA id m14sm1891082wro.43.2020.10.27.05.44.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2020 05:44:10 -0700 (PDT) From: Mattijs Korpershoek To: Ulf Hansson , Fabien Parent , Yong Mao , Chaotian Jing Subject: Re: [PATCH] mmc: host: mtk-sd: enable recheck_sdio_irq for MT8516 SoC In-Reply-To: References: <20201023122950.60903-1-fparent@baylibre.com> Date: Tue, 27 Oct 2020 13:44:08 +0100 Message-ID: <87wnzbg7on.fsf@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201027_084414_820924_46311399 X-CRM114-Status: GOOD ( 21.78 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Matthias Brugger , "moderated list:ARM/Mediatek SoC support" , "linux-mmc@vger.kernel.org" , Linux Kernel Mailing List , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Ulf, Ulf Hansson writes: > + Yong Mao, Chaotian Jing > > On Fri, 23 Oct 2020 at 14:29, Fabien Parent wrote: >> >> MT8516 SoC suffers from sometimes losing SDIO IRQs, this makes SDIO >> devices sometimes unstable. Make use of the new property >> recheck_sdio_irq to fix the SDIO stability issues on MT8516. >> >> Signed-off-by: Fabien Parent > > Maybe this is a common problem, thus I am thinking that potentially we > should enable the workaround for all variants? Not sure if this is of any help, but: we use the btmtksdio driver on a MT8183 soc with an Android kernel based on upstream. With that kernel, we did not to apply this work-around in order to have a stable bluetooth experience (pairing with a remote controller) However, on the MT8516 SoC, it's impossible for us to use btmtksdio without Fabien's fix. > > I have looped in Yong Mao (who invented the workaround) and Chaotian > Jing, to see if they can advise us how to proceed. > > In any case, I think we should add a stable tag and a fixes tag. > > Kind regards > Uffe > >> --- >> drivers/mmc/host/mtk-sd.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c >> index a704745e5882..3dc102eefe49 100644 >> --- a/drivers/mmc/host/mtk-sd.c >> +++ b/drivers/mmc/host/mtk-sd.c >> @@ -524,7 +524,7 @@ static const struct mtk_mmc_compatible mt7622_compat = { >> >> static const struct mtk_mmc_compatible mt8516_compat = { >> .clk_div_bits = 12, >> - .recheck_sdio_irq = false, >> + .recheck_sdio_irq = true, >> .hs400_tune = false, >> .pad_tune_reg = MSDC_PAD_TUNE0, >> .async_fifo = true, >> -- >> 2.28.0 >> > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14012C55179 for ; Tue, 27 Oct 2020 12:44:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A4CEF21D24 for ; Tue, 27 Oct 2020 12:44:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="Ck9y9jNd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2440592AbgJ0MoP (ORCPT ); Tue, 27 Oct 2020 08:44:15 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:40698 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2440548AbgJ0MoO (ORCPT ); Tue, 27 Oct 2020 08:44:14 -0400 Received: by mail-wr1-f67.google.com with SMTP id h5so1734856wrv.7 for ; Tue, 27 Oct 2020 05:44:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=HBFttdYAiRM1KfFacsdZju3R8FEz52UG6psn2mn812k=; b=Ck9y9jNdJH1H9KVu2owJyTBu42rV4XSWLdMUbByrEIQhakBN7YO3viBNE7ywGE3yJV 21nxkfIOqKJYmVR7phi6Mzl7xabBrqCSHVDvC6wQjQdXQwgh7fpBlxLd0spJm6TD1f/z i8rfkkdL3rv1kNNzjwl5ccwoTqDMuUQz+sXBzzY6oWTJcr7pbtuUho/VDBaGCbA+JUFy 8rFIc0Mph/wTGNCdJiEdu+j+TUPeGOqq7vp55s9RrKz7oPhApmbGbRXD5yrp3Ko8tRiS uvrWHwR+8dFXWShuf4c5KsxIDyJiXxw78K3ZGM/ChFHu1dDwpDKmBilfGofXcucVgkOj pjKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=HBFttdYAiRM1KfFacsdZju3R8FEz52UG6psn2mn812k=; b=pf62aOz+BNV6QuZWOm+fVwUFZxegbD7x9IOKllGpue6DpFaSUw/1xPEWaWJJ0q8qIR XRuKqhgjPt6ZC5loVuFCG2sirgQfRC1ksk1spwMcIv6NxuinggDVpeJQBkBNLmvKB8Bt G9QHyIJDk60WO6wLu+B0HgTuSWrn+j1pbgs9Y6xUi0A5olO4pZ4roKvW/4R2JUWnfmg7 fXHtXe9fbTn/kl/P5ZoI8L0Fu9ffCdrSY3y5DzLQJLUHoTLKBkx264GPNP2TiTuEiOGP C8qC0NQdm2RK7L8N/xeyRI1HjSIjXFAlbFrFO3MgLE0bG9Vw7bwMDulxqv2tTblK3WhL /o8w== X-Gm-Message-State: AOAM533wAKJ0iVWJ5/3kS0GxJGe+E9vwChzCU38bXX6BSYHR4O7A7Ah4 i6vzhTtI5g8+1y2/Ih64yWe3kQ== X-Google-Smtp-Source: ABdhPJxGIvXpfpZxv774x6oG+TdKSVGildynsy97gcSuNQ0khyKnhSHNQjEj6Ais+Xmhl4PIo0XW7A== X-Received: by 2002:adf:84a5:: with SMTP id 34mr2855003wrg.152.1603802651408; Tue, 27 Oct 2020 05:44:11 -0700 (PDT) Received: from localhost ([2a01:cb19:8ae7:9d00:68a3:7a03:6c11:8947]) by smtp.gmail.com with ESMTPSA id m14sm1891082wro.43.2020.10.27.05.44.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2020 05:44:10 -0700 (PDT) From: Mattijs Korpershoek To: Ulf Hansson , Fabien Parent , Yong Mao , Chaotian Jing Cc: Matthias Brugger , "linux-mmc\@vger.kernel.org" , "moderated list\:ARM\/Mediatek SoC support" , Linux Kernel Mailing List , Linux ARM Subject: Re: [PATCH] mmc: host: mtk-sd: enable recheck_sdio_irq for MT8516 SoC In-Reply-To: References: <20201023122950.60903-1-fparent@baylibre.com> Date: Tue, 27 Oct 2020 13:44:08 +0100 Message-ID: <87wnzbg7on.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org Hi Ulf, Ulf Hansson writes: > + Yong Mao, Chaotian Jing > > On Fri, 23 Oct 2020 at 14:29, Fabien Parent wrote: >> >> MT8516 SoC suffers from sometimes losing SDIO IRQs, this makes SDIO >> devices sometimes unstable. Make use of the new property >> recheck_sdio_irq to fix the SDIO stability issues on MT8516. >> >> Signed-off-by: Fabien Parent > > Maybe this is a common problem, thus I am thinking that potentially we > should enable the workaround for all variants? Not sure if this is of any help, but: we use the btmtksdio driver on a MT8183 soc with an Android kernel based on upstream. With that kernel, we did not to apply this work-around in order to have a stable bluetooth experience (pairing with a remote controller) However, on the MT8516 SoC, it's impossible for us to use btmtksdio without Fabien's fix. > > I have looped in Yong Mao (who invented the workaround) and Chaotian > Jing, to see if they can advise us how to proceed. > > In any case, I think we should add a stable tag and a fixes tag. > > Kind regards > Uffe > >> --- >> drivers/mmc/host/mtk-sd.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c >> index a704745e5882..3dc102eefe49 100644 >> --- a/drivers/mmc/host/mtk-sd.c >> +++ b/drivers/mmc/host/mtk-sd.c >> @@ -524,7 +524,7 @@ static const struct mtk_mmc_compatible mt7622_compat = { >> >> static const struct mtk_mmc_compatible mt8516_compat = { >> .clk_div_bits = 12, >> - .recheck_sdio_irq = false, >> + .recheck_sdio_irq = true, >> .hs400_tune = false, >> .pad_tune_reg = MSDC_PAD_TUNE0, >> .async_fifo = true, >> -- >> 2.28.0 >> > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D0BDC55178 for ; Tue, 27 Oct 2020 12:45:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 89E0420757 for ; Tue, 27 Oct 2020 12:45:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="w0FNCBAq"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="Ck9y9jNd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 89E0420757 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sQwPl1HGwm9P5359dH+iZGp+WRLwtg0IrsNqYuXcqmc=; b=w0FNCBAqpm5D4yaUN0/Q1izXq FLxs/meHcBLnv6dvWd83JxJW20d6TeieY3mBlf8RPZhQ3YtrZkhISCyuYOVPTAFkLcNf6HCa3DnMS jmanBOaxdBh9wSwprD7OF2vjImx+0TgOgCEKbSkUE7p7zq6NA6+MBVUsnoVnNPwEvT6lPis+GV9tK bSCEbRVtMRrbTPerXAtrrlCO94Waf1mxAOlYZS7zA0VdR5vIA+8KQDqWyZ6BL8L8s6GpNEUN8J2ga tt8iy6HCaZICtZHQqwQsD9hAkvcqo2ofBvl0Rk7xC630bzotu60vscbXerTC6TEDnNKrmPLZzkm59 2gY1wcxcQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXOKr-0006YR-0s; Tue, 27 Oct 2020 12:44:21 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXOKk-0006VI-Jf for linux-arm-kernel@lists.infradead.org; Tue, 27 Oct 2020 12:44:16 +0000 Received: by mail-wr1-x443.google.com with SMTP id j7so1725245wrt.9 for ; Tue, 27 Oct 2020 05:44:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=HBFttdYAiRM1KfFacsdZju3R8FEz52UG6psn2mn812k=; b=Ck9y9jNdJH1H9KVu2owJyTBu42rV4XSWLdMUbByrEIQhakBN7YO3viBNE7ywGE3yJV 21nxkfIOqKJYmVR7phi6Mzl7xabBrqCSHVDvC6wQjQdXQwgh7fpBlxLd0spJm6TD1f/z i8rfkkdL3rv1kNNzjwl5ccwoTqDMuUQz+sXBzzY6oWTJcr7pbtuUho/VDBaGCbA+JUFy 8rFIc0Mph/wTGNCdJiEdu+j+TUPeGOqq7vp55s9RrKz7oPhApmbGbRXD5yrp3Ko8tRiS uvrWHwR+8dFXWShuf4c5KsxIDyJiXxw78K3ZGM/ChFHu1dDwpDKmBilfGofXcucVgkOj pjKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=HBFttdYAiRM1KfFacsdZju3R8FEz52UG6psn2mn812k=; b=q+g1uoMi3UYIdNdDbaSoiPLdQ+fhPQpLiYFnwVQ+cnIEWqT1QH7JkihI/IHUXc3HfV GGKxjmP/KtJ9cY6mSEv6PjeoqMzUDcUOHczYEz8m79aduQcfs3P9bhBeoopBCxGKOtpu cfB64eR+4wN8atTPuRMimvHsum8I6eB0cUTmMKEEy0HBifMsnNFLckLc70iWvNoIvfEr ZjoOw4OBxqCGjJZig20swX7PhJaR9S7NNwl02k6bjM8N9mibW95l+Pmnb6Y2evwjZxBa LB332Ens7GENP2DTxvmAQOEtst+llccmQd44EtKTtI/ZTRSlYXX9I9XEgfZq5+ZZOACK 9+oQ== X-Gm-Message-State: AOAM530s5ZYDcQAUZxStlNwN9Dy0uo41b2tA2PdM5CB0H978vNO84uS+ YtzpnwWQ6j26nouzJxxLJRIEug== X-Google-Smtp-Source: ABdhPJxGIvXpfpZxv774x6oG+TdKSVGildynsy97gcSuNQ0khyKnhSHNQjEj6Ais+Xmhl4PIo0XW7A== X-Received: by 2002:adf:84a5:: with SMTP id 34mr2855003wrg.152.1603802651408; Tue, 27 Oct 2020 05:44:11 -0700 (PDT) Received: from localhost ([2a01:cb19:8ae7:9d00:68a3:7a03:6c11:8947]) by smtp.gmail.com with ESMTPSA id m14sm1891082wro.43.2020.10.27.05.44.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2020 05:44:10 -0700 (PDT) From: Mattijs Korpershoek To: Ulf Hansson , Fabien Parent , Yong Mao , Chaotian Jing Subject: Re: [PATCH] mmc: host: mtk-sd: enable recheck_sdio_irq for MT8516 SoC In-Reply-To: References: <20201023122950.60903-1-fparent@baylibre.com> Date: Tue, 27 Oct 2020 13:44:08 +0100 Message-ID: <87wnzbg7on.fsf@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201027_084414_823005_7EC111E4 X-CRM114-Status: GOOD ( 23.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Matthias Brugger , "moderated list:ARM/Mediatek SoC support" , "linux-mmc@vger.kernel.org" , Linux Kernel Mailing List , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Ulf, Ulf Hansson writes: > + Yong Mao, Chaotian Jing > > On Fri, 23 Oct 2020 at 14:29, Fabien Parent wrote: >> >> MT8516 SoC suffers from sometimes losing SDIO IRQs, this makes SDIO >> devices sometimes unstable. Make use of the new property >> recheck_sdio_irq to fix the SDIO stability issues on MT8516. >> >> Signed-off-by: Fabien Parent > > Maybe this is a common problem, thus I am thinking that potentially we > should enable the workaround for all variants? Not sure if this is of any help, but: we use the btmtksdio driver on a MT8183 soc with an Android kernel based on upstream. With that kernel, we did not to apply this work-around in order to have a stable bluetooth experience (pairing with a remote controller) However, on the MT8516 SoC, it's impossible for us to use btmtksdio without Fabien's fix. > > I have looped in Yong Mao (who invented the workaround) and Chaotian > Jing, to see if they can advise us how to proceed. > > In any case, I think we should add a stable tag and a fixes tag. > > Kind regards > Uffe > >> --- >> drivers/mmc/host/mtk-sd.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c >> index a704745e5882..3dc102eefe49 100644 >> --- a/drivers/mmc/host/mtk-sd.c >> +++ b/drivers/mmc/host/mtk-sd.c >> @@ -524,7 +524,7 @@ static const struct mtk_mmc_compatible mt7622_compat = { >> >> static const struct mtk_mmc_compatible mt8516_compat = { >> .clk_div_bits = 12, >> - .recheck_sdio_irq = false, >> + .recheck_sdio_irq = true, >> .hs400_tune = false, >> .pad_tune_reg = MSDC_PAD_TUNE0, >> .async_fifo = true, >> -- >> 2.28.0 >> > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel