Re: [PATCH 5/7] tcg: Use tcg_gen_gvec_dup_imm in logical simplifications

["Alex Bennée" <alex.bennee@linaro.org>]

Richard Henderson <richard.henderson@linaro.org> writes:

> Replace the outgoing interface.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

> ---
>  tcg/tcg-op-gvec.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tcg/tcg-op-gvec.c b/tcg/tcg-op-gvec.c
> index 593bb4542e..de16c027b3 100644
> --- a/tcg/tcg-op-gvec.c
> +++ b/tcg/tcg-op-gvec.c
> @@ -2326,7 +2326,7 @@ void tcg_gen_gvec_xor(unsigned vece, uint32_t dofs, uint32_t aofs,
>      };
>  
>      if (aofs == bofs) {
> -        tcg_gen_gvec_dup8i(dofs, oprsz, maxsz, 0);
> +        tcg_gen_gvec_dup_imm(MO_64, dofs, oprsz, maxsz, 0);
>      } else {
>          tcg_gen_gvec_3(dofs, aofs, bofs, oprsz, maxsz, &g);
>      }
> @@ -2343,7 +2343,7 @@ void tcg_gen_gvec_andc(unsigned vece, uint32_t dofs, uint32_t aofs,
>      };
>  
>      if (aofs == bofs) {
> -        tcg_gen_gvec_dup8i(dofs, oprsz, maxsz, 0);
> +        tcg_gen_gvec_dup_imm(MO_64, dofs, oprsz, maxsz, 0);
>      } else {
>          tcg_gen_gvec_3(dofs, aofs, bofs, oprsz, maxsz, &g);
>      }
> @@ -2360,7 +2360,7 @@ void tcg_gen_gvec_orc(unsigned vece, uint32_t dofs, uint32_t aofs,
>      };
>  
>      if (aofs == bofs) {
> -        tcg_gen_gvec_dup8i(dofs, oprsz, maxsz, -1);
> +        tcg_gen_gvec_dup_imm(MO_64, dofs, oprsz, maxsz, -1);
>      } else {
>          tcg_gen_gvec_3(dofs, aofs, bofs, oprsz, maxsz, &g);
>      }
> @@ -2411,7 +2411,7 @@ void tcg_gen_gvec_eqv(unsigned vece, uint32_t dofs, uint32_t aofs,
>      };
>  
>      if (aofs == bofs) {
> -        tcg_gen_gvec_dup8i(dofs, oprsz, maxsz, -1);
> +        tcg_gen_gvec_dup_imm(MO_64, dofs, oprsz, maxsz, -1);
>      } else {
>          tcg_gen_gvec_3(dofs, aofs, bofs, oprsz, maxsz, &g);
>      }


-- 
Alex Bennée