From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18A0BC2BA19 for ; Wed, 15 Apr 2020 11:08:15 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E7B0A20737 for ; Wed, 15 Apr 2020 11:08:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E7B0A20737 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 808826E18F; Wed, 15 Apr 2020 11:08:14 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6373F6E18F for ; Wed, 15 Apr 2020 11:08:13 +0000 (UTC) IronPort-SDR: 7oLrJmRwam/HNMbqlZqBEDHfwIySeakME999IBJQJCpzVEj6BFDzN/HMnq1qbIlDE/GmcsdLiX VeP/8fjxF/dA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2020 04:08:12 -0700 IronPort-SDR: BZXnIPANfxHMleBNJB4CsI9i+SY7oeORZG8Ot6Rkl0q3E5LfykmMiz4msbDZhHz9YaYsws3Ur9 ay9seH4LZDsA== X-IronPort-AV: E=Sophos;i="5.72,386,1580803200"; d="scan'208";a="427397085" Received: from ssolodk-mobl1.ccr.corp.intel.com (HELO localhost) ([10.252.48.37]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2020 04:08:11 -0700 From: Jani Nikula To: Chris Wilson , intel-gfx@lists.freedesktop.org In-Reply-To: <158693408746.6629.2921157837798575131@build.alporthouse.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20200402114819.17232-1-jani.nikula@intel.com> <20200402114819.17232-16-jani.nikula@intel.com> <158693408746.6629.2921157837798575131@build.alporthouse.com> Date: Wed, 15 Apr 2020 14:08:08 +0300 Message-ID: <87wo6h3t2f.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH 16/17] drm/i915/gt: prefer struct drm_device based logging X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Wambui Karuga Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, 15 Apr 2020, Chris Wilson wrote: > Quoting Jani Nikula (2020-04-02 12:48:18) >> Prefer struct drm_device based logging over struct device based logging. >> >> No functional changes. >> >> Cc: Wambui Karuga >> Signed-off-by: Jani Nikula > > Please, please remove the added [drm] crap. And what exactly is the problem with that? I'm increasingly frustrated with the whole logging stuff, and beginning to regret I got involved with any of it. It's the perfect bikeshed minefield. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx