From: Michael Ellerman <mpe@ellerman.id.au>
To: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>,
Balamuruhan S <bala24@linux.ibm.com>,
Segher Boessenkool <segher@kernel.crashing.org>
Cc: jniethe5@gmail.com, linuxppc-dev@lists.ozlabs.org,
sandipan@linux.ibm.com, paulus@samba.org,
ravi.bangoria@linux.ibm.com
Subject: Re: [PATCH] powerpc xmon: drop the option `i` in cacheflush
Date: Tue, 24 Mar 2020 14:52:21 +1100 [thread overview]
Message-ID: <87wo7axvd6.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <1584968594.gguy53jubt.naveen@linux.ibm.com>
"Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> writes:
> Segher Boessenkool wrote:
>> On Mon, Mar 23, 2020 at 04:55:48PM +0530, Balamuruhan S wrote:
>>> Data Cache Block Invalidate (dcbi) instruction implemented in 32-bit
>>> designs prior to PowerPC architecture version 2.01 and got obsolete
>>> from version 2.01.
We still support 32-bit ...
>> It was added back in 2.03. It also exists in 64-bit designs (using
>> category embedded), in 2.07 still even.
>
> Indeed, it has been part of Book3e.
>
> It isn't clear if this is still useful in this context (xmon) though,
> since 'dcbf' seems to be equivalent in most respects. At the very least,
> we should restrict this to Book3e, if it is of value there.
Looking at the ISA it looks like dcbf is more or less equivalent and we
could probably drop the explicit invalidate command.
But the simplest option is probably to just ifdef it out for
PPC_BOOK3S_64.
cheers
next prev parent reply other threads:[~2020-03-24 3:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 11:25 [PATCH] powerpc xmon: drop the option `i` in cacheflush Balamuruhan S
2020-03-23 12:46 ` Segher Boessenkool
2020-03-23 13:22 ` Naveen N. Rao
2020-03-24 3:52 ` Michael Ellerman [this message]
2020-03-24 6:15 ` Balamuruhan S
2020-03-24 6:08 ` Balamuruhan S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wo7axvd6.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=bala24@linux.ibm.com \
--cc=jniethe5@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=paulus@samba.org \
--cc=ravi.bangoria@linux.ibm.com \
--cc=sandipan@linux.ibm.com \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.