From: Kalle Valo <kvalo@codeaurora.org>
To: Brian Norris <briannorris@chromium.org>
Cc: Justin Capella <justincapella@gmail.com>,
Chris Chiu <chiu@endlessm.com>,
Tony Chuang <yhchuang@realtek.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] rtw88: disable TX-AMSDU on 2.4G band
Date: Sat, 08 Feb 2020 12:09:27 +0200 [thread overview]
Message-ID: <87wo8xxueg.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CA+ASDXPHXFquF2iXvdxZXhkkLPndkACgenLJwMR_9ON7zZZM3w@mail.gmail.com> (Brian Norris's message of "Fri, 7 Feb 2020 12:53:26 -0800")
Brian Norris <briannorris@chromium.org> writes:
> On Fri, Feb 7, 2020 at 12:48 PM Justin Capella <justincapella@gmail.com> wrote:
>> I understand, I'm suggesting disable by default but option to re-enable
>
> Ah, OK. Seems reasonable, I suppose, although I don't recall Kalle
> having a particularly-high opinion of module parameters for tweaking
> core 802.11 protocol behaviors.
Yeah, exactly. And the number of module parameters a driver has should
be minimised. I know out-of-tree vendor drivers have ini files with 100
different knobs, but I don't think module parameters should be
equivalent to ini files.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-02-08 10:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 12:06 [PATCH] rtw88: disable TX-AMSDU on 2.4G band yhchuang
2020-02-07 2:21 ` Chris Chiu
2020-02-07 19:40 ` Justin Capella
2020-02-07 20:41 ` Brian Norris
[not found] ` <CAMrEMU93LScySw4mpidAC5pVHV_NOShP1_GMMsvsAk1QBhdJjQ@mail.gmail.com>
2020-02-07 20:53 ` Brian Norris
2020-02-08 10:09 ` Kalle Valo [this message]
[not found] ` <CAMrEMU-nM1O_iJPVgGg2pL6JYWMdRKdPGe5N2rkfOihdmTeMaw@mail.gmail.com>
2020-02-12 2:55 ` Tony Chuang
2020-02-20 19:04 ` Brian Norris
2020-03-02 13:43 ` Kalle Valo
2020-02-12 16:22 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wo8xxueg.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=briannorris@chromium.org \
--cc=chiu@endlessm.com \
--cc=justincapella@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.