From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13FE1C2D0C0 for ; Mon, 23 Dec 2019 11:21:12 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D79E4206D3 for ; Mon, 23 Dec 2019 11:21:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D79E4206D3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5B2E66E260; Mon, 23 Dec 2019 11:21:11 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7B4CE6E260 for ; Mon, 23 Dec 2019 11:21:09 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Dec 2019 03:21:09 -0800 X-IronPort-AV: E=Sophos;i="5.69,347,1571727600"; d="scan'208";a="207247953" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Dec 2019 03:21:06 -0800 From: Jani Nikula To: Sam Ravnborg , Joe Perches Subject: Re: [PATCH v1 6/8] drm/print: add drm_dev_* logging functions In-Reply-To: <20191221144854.GA25386@ravnborg.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20191221095553.13332-1-sam@ravnborg.org> <20191221095553.13332-7-sam@ravnborg.org> <20191221144854.GA25386@ravnborg.org> Date: Mon, 23 Dec 2019 13:21:04 +0200 Message-ID: <87woanuw2n.fsf@intel.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sean Paul , dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sat, 21 Dec 2019, Sam Ravnborg wrote: > Hi Joe. > >> > +#define __drm_dev_cat_printk(dev, cat, type, fmt, ...) \ >> > +({ \ >> > + if (drm_debug_enabled(cat)) \ >> > + dev_dbg##type((dev), "[drm] " fmt, ##__VA_ARGS__); \ >> >> trivia: The parentheses around dev aren't necessary. >> >> > +}) >> > + >> > +#define drm_dev_info(dev, fmt, ...) \ >> > + __drm_dev_printk((dev), info,, fmt, ##__VA_ARGS__) >> >> etc... > > I was not really sure so I just added them. > Will remove in v2 in all relevent patches - thanks! FWIW, they are necessary in the drm_device variants due to the macros doing the dereferencing. BR, Jani. > > Sam -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel