From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1ACC3C43215 for ; Mon, 2 Dec 2019 11:53:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EDCDF215E5 for ; Mon, 2 Dec 2019 11:53:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727354AbfLBLxO (ORCPT ); Mon, 2 Dec 2019 06:53:14 -0500 Received: from mga07.intel.com ([134.134.136.100]:31447 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726149AbfLBLxO (ORCPT ); Mon, 2 Dec 2019 06:53:14 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Dec 2019 03:53:13 -0800 X-IronPort-AV: E=Sophos;i="5.69,268,1571727600"; d="scan'208";a="204529220" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Dec 2019 03:53:08 -0800 From: Jani Nikula To: Linus Walleij , Hans de Goede Cc: Joonas Lahtinen , Rodrigo Vivi , Ville =?utf-8?B?U3lyasOkbMOk?= , Mika Westerberg , Andy Shevchenko , Bartosz Golaszewski , intel-gfx , "open list\:DRM PANEL DRIVERS" , "open list\:GPIO SUBSYSTEM" , ACPI Devel Maling List Subject: Re: [PATCH 2/2] drm/i915/vlv_dsi: Control panel and backlight enable GPIOs on BYT In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20191129185836.2789-1-hdegoede@redhat.com> <20191129185836.2789-3-hdegoede@redhat.com> Date: Mon, 02 Dec 2019 13:53:04 +0200 Message-ID: <87wobfj65b.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon, 02 Dec 2019, Linus Walleij wrote: > Hi Hans, > > thank you for your patch! > > On Fri, Nov 29, 2019 at 7:58 PM Hans de Goede wrote: > >> - /* GPIO Desc for CRC based Panel control */ >> + /* GPIO Desc for panel and backlight control */ >> struct gpio_desc *gpio_panel; >> + struct gpio_desc *gpio_backlight; > > I think what happens here is that you reimplement > drivers/video/backlight/gpio_backlight.c > > The existing power control GPIO also reimplements > drivers/regulator/fixed.c in a sense but I am under the > impression that x86 in general and ACPI in particular > has a problem with the regulator subsystem so I am > uncertain about that one. > > When I look at the code I get more confused because > nominally panels should have their own drivers in > drivers/gpu/drm/panel/* especially DSI panels, and the > panels control their own GPIOs or regulators for power > and backlight. > > I was under the impression that Heikki's and Dmitry's > recent additions to software nodes would make it > possible to actually spawn devices like the GPIO backlight > and/or fixed regulator and put references to them so > that the drivers can pick them up from the respective > frameworks and manage them? > > Maybe I misunderstood things here though, I am a bit > under the impression that elder DRM drivers are > considered "elder gods" and do not need to use separate > panel drivers, backlight abstraction etc, and in that > case just go ahead, I guess. > > But I suspect some separation > would help the day the i915 driver wants to reuse some > really complex DSI panel from drivers/gpu/drm/panel/* > though. Sadly I don't think that's going to happen, though. For i915 the panels are described by VBT, or Video BIOS Tables. We don't really know the make or model of the panels, we just get the timings and sequences etc. from there. There's no info to probe a separate panel driver. So we just have a "generic" DSI driver that's part of i915 which uses the data from the VBT to drive all the possible panels. We do use some of the drm DSI framework as a library to abstract things a bit better, but that's about it. The sequences should include details about GPIOs to toggle as well, so in that sense I feel like the gpio calls should be bolted there. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 2/2] drm/i915/vlv_dsi: Control panel and backlight enable GPIOs on BYT Date: Mon, 02 Dec 2019 13:53:04 +0200 Message-ID: <87wobfj65b.fsf@intel.com> References: <20191129185836.2789-1-hdegoede@redhat.com> <20191129185836.2789-3-hdegoede@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Linus Walleij , Hans de Goede Cc: ACPI Devel Maling List , "open list:GPIO SUBSYSTEM" , intel-gfx , "open list:DRM PANEL DRIVERS" , Bartosz Golaszewski , Andy Shevchenko , Mika Westerberg List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCAwMiBEZWMgMjAxOSwgTGludXMgV2FsbGVpaiA8bGludXMud2FsbGVpakBsaW5hcm8u b3JnPiB3cm90ZToKPiBIaSBIYW5zLAo+Cj4gdGhhbmsgeW91IGZvciB5b3VyIHBhdGNoIQo+Cj4g T24gRnJpLCBOb3YgMjksIDIwMTkgYXQgNzo1OCBQTSBIYW5zIGRlIEdvZWRlIDxoZGVnb2VkZUBy ZWRoYXQuY29tPiB3cm90ZToKPgo+PiAtICAgICAgIC8qIEdQSU8gRGVzYyBmb3IgQ1JDIGJhc2Vk IFBhbmVsIGNvbnRyb2wgKi8KPj4gKyAgICAgICAvKiBHUElPIERlc2MgZm9yIHBhbmVsIGFuZCBi YWNrbGlnaHQgY29udHJvbCAqLwo+PiAgICAgICAgIHN0cnVjdCBncGlvX2Rlc2MgKmdwaW9fcGFu ZWw7Cj4+ICsgICAgICAgc3RydWN0IGdwaW9fZGVzYyAqZ3Bpb19iYWNrbGlnaHQ7Cj4KPiBJIHRo aW5rIHdoYXQgaGFwcGVucyBoZXJlIGlzIHRoYXQgeW91IHJlaW1wbGVtZW50Cj4gZHJpdmVycy92 aWRlby9iYWNrbGlnaHQvZ3Bpb19iYWNrbGlnaHQuYwo+Cj4gVGhlIGV4aXN0aW5nIHBvd2VyIGNv bnRyb2wgR1BJTyBhbHNvIHJlaW1wbGVtZW50cwo+IGRyaXZlcnMvcmVndWxhdG9yL2ZpeGVkLmMg aW4gYSBzZW5zZSBidXQgSSBhbSB1bmRlciB0aGUKPiBpbXByZXNzaW9uIHRoYXQgeDg2IGluIGdl bmVyYWwgYW5kIEFDUEkgaW4gcGFydGljdWxhcgo+IGhhcyBhIHByb2JsZW0gd2l0aCB0aGUgcmVn dWxhdG9yIHN1YnN5c3RlbSBzbyBJIGFtCj4gdW5jZXJ0YWluIGFib3V0IHRoYXQgb25lLgo+Cj4g V2hlbiBJIGxvb2sgYXQgdGhlIGNvZGUgSSBnZXQgbW9yZSBjb25mdXNlZCBiZWNhdXNlCj4gbm9t aW5hbGx5IHBhbmVscyBzaG91bGQgaGF2ZSB0aGVpciBvd24gZHJpdmVycyBpbgo+IGRyaXZlcnMv Z3B1L2RybS9wYW5lbC8qIGVzcGVjaWFsbHkgRFNJIHBhbmVscywgYW5kIHRoZQo+IHBhbmVscyBj b250cm9sIHRoZWlyIG93biBHUElPcyBvciByZWd1bGF0b3JzIGZvciBwb3dlcgo+IGFuZCBiYWNr bGlnaHQuCj4KPiBJIHdhcyB1bmRlciB0aGUgaW1wcmVzc2lvbiB0aGF0IEhlaWtraSdzIGFuZCBE bWl0cnkncwo+IHJlY2VudCBhZGRpdGlvbnMgdG8gc29mdHdhcmUgbm9kZXMgd291bGQgbWFrZSBp dAo+IHBvc3NpYmxlIHRvIGFjdHVhbGx5IHNwYXduIGRldmljZXMgbGlrZSB0aGUgR1BJTyBiYWNr bGlnaHQKPiBhbmQvb3IgZml4ZWQgcmVndWxhdG9yIGFuZCBwdXQgcmVmZXJlbmNlcyB0byB0aGVt IHNvCj4gdGhhdCB0aGUgZHJpdmVycyBjYW4gcGljayB0aGVtIHVwIGZyb20gdGhlIHJlc3BlY3Rp dmUKPiBmcmFtZXdvcmtzIGFuZCBtYW5hZ2UgdGhlbT8KPgo+IE1heWJlIEkgbWlzdW5kZXJzdG9v ZCB0aGluZ3MgaGVyZSB0aG91Z2gsIEkgYW0gYSBiaXQKPiB1bmRlciB0aGUgaW1wcmVzc2lvbiB0 aGF0IGVsZGVyIERSTSBkcml2ZXJzIGFyZQo+IGNvbnNpZGVyZWQgImVsZGVyIGdvZHMiIGFuZCBk byBub3QgbmVlZCB0byB1c2Ugc2VwYXJhdGUKPiBwYW5lbCBkcml2ZXJzLCBiYWNrbGlnaHQgYWJz dHJhY3Rpb24gZXRjLCBhbmQgaW4gdGhhdAo+IGNhc2UganVzdCBnbyBhaGVhZCwgSSBndWVzcy4K Pgo+IEJ1dCBJIHN1c3BlY3Qgc29tZSBzZXBhcmF0aW9uCj4gd291bGQgaGVscCB0aGUgZGF5IHRo ZSBpOTE1IGRyaXZlciB3YW50cyB0byByZXVzZSBzb21lCj4gcmVhbGx5IGNvbXBsZXggRFNJIHBh bmVsIGZyb20gZHJpdmVycy9ncHUvZHJtL3BhbmVsLyoKPiB0aG91Z2guCgpTYWRseSBJIGRvbid0 IHRoaW5rIHRoYXQncyBnb2luZyB0byBoYXBwZW4sIHRob3VnaC4KCkZvciBpOTE1IHRoZSBwYW5l bHMgYXJlIGRlc2NyaWJlZCBieSBWQlQsIG9yIFZpZGVvIEJJT1MgVGFibGVzLiBXZSBkb24ndApy ZWFsbHkga25vdyB0aGUgbWFrZSBvciBtb2RlbCBvZiB0aGUgcGFuZWxzLCB3ZSBqdXN0IGdldCB0 aGUgdGltaW5ncyBhbmQKc2VxdWVuY2VzIGV0Yy4gZnJvbSB0aGVyZS4gVGhlcmUncyBubyBpbmZv IHRvIHByb2JlIGEgc2VwYXJhdGUgcGFuZWwKZHJpdmVyLiBTbyB3ZSBqdXN0IGhhdmUgYSAiZ2Vu ZXJpYyIgRFNJIGRyaXZlciB0aGF0J3MgcGFydCBvZiBpOTE1IHdoaWNoCnVzZXMgdGhlIGRhdGEg ZnJvbSB0aGUgVkJUIHRvIGRyaXZlIGFsbCB0aGUgcG9zc2libGUgcGFuZWxzLgoKV2UgZG8gdXNl IHNvbWUgb2YgdGhlIGRybSBEU0kgZnJhbWV3b3JrIGFzIGEgbGlicmFyeSB0byBhYnN0cmFjdCB0 aGluZ3MKYSBiaXQgYmV0dGVyLCBidXQgdGhhdCdzIGFib3V0IGl0LgoKVGhlIHNlcXVlbmNlcyBz aG91bGQgaW5jbHVkZSBkZXRhaWxzIGFib3V0IEdQSU9zIHRvIHRvZ2dsZSBhcyB3ZWxsLCBzbwpp biB0aGF0IHNlbnNlIEkgZmVlbCBsaWtlIHRoZSBncGlvIGNhbGxzIHNob3VsZCBiZSBib2x0ZWQg dGhlcmUuCgpCUiwKSmFuaS4KCgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIEdy YXBoaWNzIENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n Zng= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39B86C432C3 for ; Mon, 2 Dec 2019 11:53:17 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 195A220833 for ; Mon, 2 Dec 2019 11:53:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 195A220833 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D88DB89E26; Mon, 2 Dec 2019 11:53:15 +0000 (UTC) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7136689C1B; Mon, 2 Dec 2019 11:53:14 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Dec 2019 03:53:13 -0800 X-IronPort-AV: E=Sophos;i="5.69,268,1571727600"; d="scan'208";a="204529220" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Dec 2019 03:53:08 -0800 From: Jani Nikula To: Linus Walleij , Hans de Goede Subject: Re: [PATCH 2/2] drm/i915/vlv_dsi: Control panel and backlight enable GPIOs on BYT In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20191129185836.2789-1-hdegoede@redhat.com> <20191129185836.2789-3-hdegoede@redhat.com> Date: Mon, 02 Dec 2019 13:53:04 +0200 Message-ID: <87wobfj65b.fsf@intel.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ACPI Devel Maling List , "open list:GPIO SUBSYSTEM" , intel-gfx , "open list:DRM PANEL DRIVERS" , Bartosz Golaszewski , Rodrigo Vivi , Andy Shevchenko , Mika Westerberg Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191202115304.-_1Qu2LW86o0Xgugw3Y544hAVE_gIgFxivhv7KrgwDY@z> T24gTW9uLCAwMiBEZWMgMjAxOSwgTGludXMgV2FsbGVpaiA8bGludXMud2FsbGVpakBsaW5hcm8u b3JnPiB3cm90ZToKPiBIaSBIYW5zLAo+Cj4gdGhhbmsgeW91IGZvciB5b3VyIHBhdGNoIQo+Cj4g T24gRnJpLCBOb3YgMjksIDIwMTkgYXQgNzo1OCBQTSBIYW5zIGRlIEdvZWRlIDxoZGVnb2VkZUBy ZWRoYXQuY29tPiB3cm90ZToKPgo+PiAtICAgICAgIC8qIEdQSU8gRGVzYyBmb3IgQ1JDIGJhc2Vk IFBhbmVsIGNvbnRyb2wgKi8KPj4gKyAgICAgICAvKiBHUElPIERlc2MgZm9yIHBhbmVsIGFuZCBi YWNrbGlnaHQgY29udHJvbCAqLwo+PiAgICAgICAgIHN0cnVjdCBncGlvX2Rlc2MgKmdwaW9fcGFu ZWw7Cj4+ICsgICAgICAgc3RydWN0IGdwaW9fZGVzYyAqZ3Bpb19iYWNrbGlnaHQ7Cj4KPiBJIHRo aW5rIHdoYXQgaGFwcGVucyBoZXJlIGlzIHRoYXQgeW91IHJlaW1wbGVtZW50Cj4gZHJpdmVycy92 aWRlby9iYWNrbGlnaHQvZ3Bpb19iYWNrbGlnaHQuYwo+Cj4gVGhlIGV4aXN0aW5nIHBvd2VyIGNv bnRyb2wgR1BJTyBhbHNvIHJlaW1wbGVtZW50cwo+IGRyaXZlcnMvcmVndWxhdG9yL2ZpeGVkLmMg aW4gYSBzZW5zZSBidXQgSSBhbSB1bmRlciB0aGUKPiBpbXByZXNzaW9uIHRoYXQgeDg2IGluIGdl bmVyYWwgYW5kIEFDUEkgaW4gcGFydGljdWxhcgo+IGhhcyBhIHByb2JsZW0gd2l0aCB0aGUgcmVn dWxhdG9yIHN1YnN5c3RlbSBzbyBJIGFtCj4gdW5jZXJ0YWluIGFib3V0IHRoYXQgb25lLgo+Cj4g V2hlbiBJIGxvb2sgYXQgdGhlIGNvZGUgSSBnZXQgbW9yZSBjb25mdXNlZCBiZWNhdXNlCj4gbm9t aW5hbGx5IHBhbmVscyBzaG91bGQgaGF2ZSB0aGVpciBvd24gZHJpdmVycyBpbgo+IGRyaXZlcnMv Z3B1L2RybS9wYW5lbC8qIGVzcGVjaWFsbHkgRFNJIHBhbmVscywgYW5kIHRoZQo+IHBhbmVscyBj b250cm9sIHRoZWlyIG93biBHUElPcyBvciByZWd1bGF0b3JzIGZvciBwb3dlcgo+IGFuZCBiYWNr bGlnaHQuCj4KPiBJIHdhcyB1bmRlciB0aGUgaW1wcmVzc2lvbiB0aGF0IEhlaWtraSdzIGFuZCBE bWl0cnkncwo+IHJlY2VudCBhZGRpdGlvbnMgdG8gc29mdHdhcmUgbm9kZXMgd291bGQgbWFrZSBp dAo+IHBvc3NpYmxlIHRvIGFjdHVhbGx5IHNwYXduIGRldmljZXMgbGlrZSB0aGUgR1BJTyBiYWNr bGlnaHQKPiBhbmQvb3IgZml4ZWQgcmVndWxhdG9yIGFuZCBwdXQgcmVmZXJlbmNlcyB0byB0aGVt IHNvCj4gdGhhdCB0aGUgZHJpdmVycyBjYW4gcGljayB0aGVtIHVwIGZyb20gdGhlIHJlc3BlY3Rp dmUKPiBmcmFtZXdvcmtzIGFuZCBtYW5hZ2UgdGhlbT8KPgo+IE1heWJlIEkgbWlzdW5kZXJzdG9v ZCB0aGluZ3MgaGVyZSB0aG91Z2gsIEkgYW0gYSBiaXQKPiB1bmRlciB0aGUgaW1wcmVzc2lvbiB0 aGF0IGVsZGVyIERSTSBkcml2ZXJzIGFyZQo+IGNvbnNpZGVyZWQgImVsZGVyIGdvZHMiIGFuZCBk byBub3QgbmVlZCB0byB1c2Ugc2VwYXJhdGUKPiBwYW5lbCBkcml2ZXJzLCBiYWNrbGlnaHQgYWJz dHJhY3Rpb24gZXRjLCBhbmQgaW4gdGhhdAo+IGNhc2UganVzdCBnbyBhaGVhZCwgSSBndWVzcy4K Pgo+IEJ1dCBJIHN1c3BlY3Qgc29tZSBzZXBhcmF0aW9uCj4gd291bGQgaGVscCB0aGUgZGF5IHRo ZSBpOTE1IGRyaXZlciB3YW50cyB0byByZXVzZSBzb21lCj4gcmVhbGx5IGNvbXBsZXggRFNJIHBh bmVsIGZyb20gZHJpdmVycy9ncHUvZHJtL3BhbmVsLyoKPiB0aG91Z2guCgpTYWRseSBJIGRvbid0 IHRoaW5rIHRoYXQncyBnb2luZyB0byBoYXBwZW4sIHRob3VnaC4KCkZvciBpOTE1IHRoZSBwYW5l bHMgYXJlIGRlc2NyaWJlZCBieSBWQlQsIG9yIFZpZGVvIEJJT1MgVGFibGVzLiBXZSBkb24ndApy ZWFsbHkga25vdyB0aGUgbWFrZSBvciBtb2RlbCBvZiB0aGUgcGFuZWxzLCB3ZSBqdXN0IGdldCB0 aGUgdGltaW5ncyBhbmQKc2VxdWVuY2VzIGV0Yy4gZnJvbSB0aGVyZS4gVGhlcmUncyBubyBpbmZv IHRvIHByb2JlIGEgc2VwYXJhdGUgcGFuZWwKZHJpdmVyLiBTbyB3ZSBqdXN0IGhhdmUgYSAiZ2Vu ZXJpYyIgRFNJIGRyaXZlciB0aGF0J3MgcGFydCBvZiBpOTE1IHdoaWNoCnVzZXMgdGhlIGRhdGEg ZnJvbSB0aGUgVkJUIHRvIGRyaXZlIGFsbCB0aGUgcG9zc2libGUgcGFuZWxzLgoKV2UgZG8gdXNl IHNvbWUgb2YgdGhlIGRybSBEU0kgZnJhbWV3b3JrIGFzIGEgbGlicmFyeSB0byBhYnN0cmFjdCB0 aGluZ3MKYSBiaXQgYmV0dGVyLCBidXQgdGhhdCdzIGFib3V0IGl0LgoKVGhlIHNlcXVlbmNlcyBz aG91bGQgaW5jbHVkZSBkZXRhaWxzIGFib3V0IEdQSU9zIHRvIHRvZ2dsZSBhcyB3ZWxsLCBzbwpp biB0aGF0IHNlbnNlIEkgZmVlbCBsaWtlIHRoZSBncGlvIGNhbGxzIHNob3VsZCBiZSBib2x0ZWQg dGhlcmUuCgpCUiwKSmFuaS4KCgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIEdy YXBoaWNzIENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2 ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22872C432C3 for ; Mon, 2 Dec 2019 11:53:16 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 028D720833 for ; Mon, 2 Dec 2019 11:53:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 028D720833 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 734E189C1B; Mon, 2 Dec 2019 11:53:15 +0000 (UTC) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7136689C1B; Mon, 2 Dec 2019 11:53:14 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Dec 2019 03:53:13 -0800 X-IronPort-AV: E=Sophos;i="5.69,268,1571727600"; d="scan'208";a="204529220" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Dec 2019 03:53:08 -0800 From: Jani Nikula To: Linus Walleij , Hans de Goede In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20191129185836.2789-1-hdegoede@redhat.com> <20191129185836.2789-3-hdegoede@redhat.com> Date: Mon, 02 Dec 2019 13:53:04 +0200 Message-ID: <87wobfj65b.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/vlv_dsi: Control panel and backlight enable GPIOs on BYT X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ACPI Devel Maling List , "open list:GPIO SUBSYSTEM" , intel-gfx , "open list:DRM PANEL DRIVERS" , Bartosz Golaszewski , Andy Shevchenko , Mika Westerberg Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Message-ID: <20191202115304.poIUeZa8N5TydV5zNV7mfHnFUY710YxS_T-lBWR30pc@z> T24gTW9uLCAwMiBEZWMgMjAxOSwgTGludXMgV2FsbGVpaiA8bGludXMud2FsbGVpakBsaW5hcm8u b3JnPiB3cm90ZToKPiBIaSBIYW5zLAo+Cj4gdGhhbmsgeW91IGZvciB5b3VyIHBhdGNoIQo+Cj4g T24gRnJpLCBOb3YgMjksIDIwMTkgYXQgNzo1OCBQTSBIYW5zIGRlIEdvZWRlIDxoZGVnb2VkZUBy ZWRoYXQuY29tPiB3cm90ZToKPgo+PiAtICAgICAgIC8qIEdQSU8gRGVzYyBmb3IgQ1JDIGJhc2Vk IFBhbmVsIGNvbnRyb2wgKi8KPj4gKyAgICAgICAvKiBHUElPIERlc2MgZm9yIHBhbmVsIGFuZCBi YWNrbGlnaHQgY29udHJvbCAqLwo+PiAgICAgICAgIHN0cnVjdCBncGlvX2Rlc2MgKmdwaW9fcGFu ZWw7Cj4+ICsgICAgICAgc3RydWN0IGdwaW9fZGVzYyAqZ3Bpb19iYWNrbGlnaHQ7Cj4KPiBJIHRo aW5rIHdoYXQgaGFwcGVucyBoZXJlIGlzIHRoYXQgeW91IHJlaW1wbGVtZW50Cj4gZHJpdmVycy92 aWRlby9iYWNrbGlnaHQvZ3Bpb19iYWNrbGlnaHQuYwo+Cj4gVGhlIGV4aXN0aW5nIHBvd2VyIGNv bnRyb2wgR1BJTyBhbHNvIHJlaW1wbGVtZW50cwo+IGRyaXZlcnMvcmVndWxhdG9yL2ZpeGVkLmMg aW4gYSBzZW5zZSBidXQgSSBhbSB1bmRlciB0aGUKPiBpbXByZXNzaW9uIHRoYXQgeDg2IGluIGdl bmVyYWwgYW5kIEFDUEkgaW4gcGFydGljdWxhcgo+IGhhcyBhIHByb2JsZW0gd2l0aCB0aGUgcmVn dWxhdG9yIHN1YnN5c3RlbSBzbyBJIGFtCj4gdW5jZXJ0YWluIGFib3V0IHRoYXQgb25lLgo+Cj4g V2hlbiBJIGxvb2sgYXQgdGhlIGNvZGUgSSBnZXQgbW9yZSBjb25mdXNlZCBiZWNhdXNlCj4gbm9t aW5hbGx5IHBhbmVscyBzaG91bGQgaGF2ZSB0aGVpciBvd24gZHJpdmVycyBpbgo+IGRyaXZlcnMv Z3B1L2RybS9wYW5lbC8qIGVzcGVjaWFsbHkgRFNJIHBhbmVscywgYW5kIHRoZQo+IHBhbmVscyBj b250cm9sIHRoZWlyIG93biBHUElPcyBvciByZWd1bGF0b3JzIGZvciBwb3dlcgo+IGFuZCBiYWNr bGlnaHQuCj4KPiBJIHdhcyB1bmRlciB0aGUgaW1wcmVzc2lvbiB0aGF0IEhlaWtraSdzIGFuZCBE bWl0cnkncwo+IHJlY2VudCBhZGRpdGlvbnMgdG8gc29mdHdhcmUgbm9kZXMgd291bGQgbWFrZSBp dAo+IHBvc3NpYmxlIHRvIGFjdHVhbGx5IHNwYXduIGRldmljZXMgbGlrZSB0aGUgR1BJTyBiYWNr bGlnaHQKPiBhbmQvb3IgZml4ZWQgcmVndWxhdG9yIGFuZCBwdXQgcmVmZXJlbmNlcyB0byB0aGVt IHNvCj4gdGhhdCB0aGUgZHJpdmVycyBjYW4gcGljayB0aGVtIHVwIGZyb20gdGhlIHJlc3BlY3Rp dmUKPiBmcmFtZXdvcmtzIGFuZCBtYW5hZ2UgdGhlbT8KPgo+IE1heWJlIEkgbWlzdW5kZXJzdG9v ZCB0aGluZ3MgaGVyZSB0aG91Z2gsIEkgYW0gYSBiaXQKPiB1bmRlciB0aGUgaW1wcmVzc2lvbiB0 aGF0IGVsZGVyIERSTSBkcml2ZXJzIGFyZQo+IGNvbnNpZGVyZWQgImVsZGVyIGdvZHMiIGFuZCBk byBub3QgbmVlZCB0byB1c2Ugc2VwYXJhdGUKPiBwYW5lbCBkcml2ZXJzLCBiYWNrbGlnaHQgYWJz dHJhY3Rpb24gZXRjLCBhbmQgaW4gdGhhdAo+IGNhc2UganVzdCBnbyBhaGVhZCwgSSBndWVzcy4K Pgo+IEJ1dCBJIHN1c3BlY3Qgc29tZSBzZXBhcmF0aW9uCj4gd291bGQgaGVscCB0aGUgZGF5IHRo ZSBpOTE1IGRyaXZlciB3YW50cyB0byByZXVzZSBzb21lCj4gcmVhbGx5IGNvbXBsZXggRFNJIHBh bmVsIGZyb20gZHJpdmVycy9ncHUvZHJtL3BhbmVsLyoKPiB0aG91Z2guCgpTYWRseSBJIGRvbid0 IHRoaW5rIHRoYXQncyBnb2luZyB0byBoYXBwZW4sIHRob3VnaC4KCkZvciBpOTE1IHRoZSBwYW5l bHMgYXJlIGRlc2NyaWJlZCBieSBWQlQsIG9yIFZpZGVvIEJJT1MgVGFibGVzLiBXZSBkb24ndApy ZWFsbHkga25vdyB0aGUgbWFrZSBvciBtb2RlbCBvZiB0aGUgcGFuZWxzLCB3ZSBqdXN0IGdldCB0 aGUgdGltaW5ncyBhbmQKc2VxdWVuY2VzIGV0Yy4gZnJvbSB0aGVyZS4gVGhlcmUncyBubyBpbmZv IHRvIHByb2JlIGEgc2VwYXJhdGUgcGFuZWwKZHJpdmVyLiBTbyB3ZSBqdXN0IGhhdmUgYSAiZ2Vu ZXJpYyIgRFNJIGRyaXZlciB0aGF0J3MgcGFydCBvZiBpOTE1IHdoaWNoCnVzZXMgdGhlIGRhdGEg ZnJvbSB0aGUgVkJUIHRvIGRyaXZlIGFsbCB0aGUgcG9zc2libGUgcGFuZWxzLgoKV2UgZG8gdXNl IHNvbWUgb2YgdGhlIGRybSBEU0kgZnJhbWV3b3JrIGFzIGEgbGlicmFyeSB0byBhYnN0cmFjdCB0 aGluZ3MKYSBiaXQgYmV0dGVyLCBidXQgdGhhdCdzIGFib3V0IGl0LgoKVGhlIHNlcXVlbmNlcyBz aG91bGQgaW5jbHVkZSBkZXRhaWxzIGFib3V0IEdQSU9zIHRvIHRvZ2dsZSBhcyB3ZWxsLCBzbwpp biB0aGF0IHNlbnNlIEkgZmVlbCBsaWtlIHRoZSBncGlvIGNhbGxzIHNob3VsZCBiZSBib2x0ZWQg dGhlcmUuCgpCUiwKSmFuaS4KCgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIEdy YXBoaWNzIENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n Zng=