From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 854E4C4360C for ; Wed, 16 Oct 2019 10:09:06 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5AE9C218DE for ; Wed, 16 Oct 2019 10:09:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5AE9C218DE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40370 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKgEr-00054j-IY for qemu-devel@archiver.kernel.org; Wed, 16 Oct 2019 06:09:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60953) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKgE0-0004e7-Eb for qemu-devel@nongnu.org; Wed, 16 Oct 2019 06:08:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKgDy-00083i-3K for qemu-devel@nongnu.org; Wed, 16 Oct 2019 06:08:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42854) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iKgDx-00083D-Ua for qemu-devel@nongnu.org; Wed, 16 Oct 2019 06:08:10 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 738C918C427E for ; Wed, 16 Oct 2019 10:08:08 +0000 (UTC) Received: from redhat.com (ovpn-117-4.ams2.redhat.com [10.36.117.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C8EF6601AC; Wed, 16 Oct 2019 10:08:05 +0000 (UTC) From: Juan Quintela To: Peter Xu Subject: Re: [PATCH v2 4/4] migration: Check in savevm_state_handler_insert for dups In-Reply-To: <20191016022933.7276-5-peterx@redhat.com> (Peter Xu's message of "Wed, 16 Oct 2019 10:29:33 +0800") References: <20191016022933.7276-1-peterx@redhat.com> <20191016022933.7276-5-peterx@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Date: Wed, 16 Oct 2019 12:08:03 +0200 Message-ID: <87wod5ovek.fsf@trasno.org> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.62]); Wed, 16 Oct 2019 10:08:08 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: quintela@redhat.com Cc: Paolo Bonzini , "Dr . David Alan Gilbert" , qemu-devel@nongnu.org, Eduardo Habkost , Igor Mammedov Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Peter Xu wrote: > Before finally register one SaveStateEntry, we detect for duplicated > entries. This could be helpful to notify us asap instead of get > silent migration failures which could be hard to diagnose. > > For example, this patch will generate a message like this (if without > previous fixes on x2apic) as long as we wants to boot a VM instance > with "-smp 200,maxcpus=288,sockets=2,cores=72,threads=2" and QEMU will > bail out even before VM starts: > > savevm_state_handler_insert: Detected duplicate SaveStateEntry: id=apic, instance_id=0x0 > > Suggested-by: Dr. David Alan Gilbert > Signed-off-by: Peter Xu Reviewed-by: Juan Quintela