From: NeilBrown <neilb@suse.de>
To: "J . Bruce Fields" <bfields@fieldses.org>,
Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Anna Schumaker <anna.schumaker@netapp.com>,
Chuck Lever <chuck.lever@oracle.com>,
Neil F Brown <nfbrown@suse.com>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-nfs\@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"netdev\@vger.kernel.org" <netdev@vger.kernel.org>,
Konstantin Khorenko <khorenko@virtuozzo.com>,
Vasiliy Averin <vvs@virtuozzo.com>
Subject: Re: [PATCH] sunrpc: fix crash when cache_head become valid before update
Date: Wed, 09 Oct 2019 09:51:23 +1100 [thread overview]
Message-ID: <87wodergus.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <20191008202332.GB9151@fieldses.org>
[-- Attachment #1: Type: text/plain, Size: 547 bytes --]
On Tue, Oct 08 2019, J . Bruce Fields wrote:
> On Tue, Oct 08, 2019 at 10:02:53AM +0000, Pavel Tikhomirov wrote:
>> Add Neil to CC, sorry, had lost it somehow...
>
> Always happy when we can fix a bug by deleting code, and your
> explanation makes sense to me, but I'll give Neil a chance to look it
> over if he wants.
Yes, it makes sense to me. But I'm not sure that is worth much. The
original fix got a Reviewed-by from me but was wrong.
Acked-by: NeilBrown <neilb@suse.de>
'Acked' is weaker than 'reviewed' - isn't it? :-)
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2019-10-08 22:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 8:03 [PATCH] sunrpc: fix crash when cache_head become valid before update Pavel Tikhomirov
2019-10-08 10:02 ` Pavel Tikhomirov
2019-10-08 20:23 ` J . Bruce Fields
2019-10-08 22:51 ` NeilBrown [this message]
2019-10-11 17:15 ` J . Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wodergus.fsf@notabene.neil.brown.name \
--to=neilb@suse.de \
--cc=anna.schumaker@netapp.com \
--cc=bfields@fieldses.org \
--cc=chuck.lever@oracle.com \
--cc=davem@davemloft.net \
--cc=khorenko@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nfbrown@suse.com \
--cc=ptikhomirov@virtuozzo.com \
--cc=trond.myklebust@hammerspace.com \
--cc=vvs@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.