All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Jack Wang <jack.wang.usish@gmail.com>
Cc: Nadav Amit <nadav.amit@gmail.com>, kvm list <kvm@vger.kernel.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Sean Christopherson <sean.j.christopherson@intel.com>,
	cavery@redhat.com
Subject: Re: KVM-unit-tests on AMD
Date: Tue, 08 Oct 2019 17:06:01 +0200	[thread overview]
Message-ID: <87wodfz38m.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <CA+res+QTrLv7Hr9RcGZDua6JAdaC3tfZXRM4e9+_kbsU72OfdA@mail.gmail.com>

Jack Wang <jack.wang.usish@gmail.com> writes:

> Vitaly Kuznetsov <vkuznets@redhat.com> 于2019年10月8日周二 下午2:20写道:
>>
>> Nadav Amit <nadav.amit@gmail.com> writes:
>>
>> > Is kvm-unit-test supposed to pass on AMD machines or AMD VMs?.
>> >
>>
>> It is supposed to but it doesn't :-) Actually, not only kvm-unit-tests
>> but the whole SVM would appreciate some love ...
>>
>> > Clearly, I ask since they do not pass on AMD on bare-metal.
>>
>> On my AMD EPYC 7401P 24-Core Processor bare metal I get the following
>> failures:
>>
>> FAIL vmware_backdoors (11 tests, 8 unexpected failures)
>>
>> (Why can't we just check
>> /sys/module/kvm/parameters/enable_vmware_backdoor btw???)
>>
>> FAIL svm (15 tests, 1 unexpected failures)
>>
>> There is a patch for that:
>>
>> https://lore.kernel.org/kvm/d3eeb3b5-13d7-34d2-4ce0-fdd534f2bcc3@redhat.com/T/#t
>>
>
>> Are you seeing different failures?
>>
>> --
>> Vitaly
> On my test machine AMD Opteron(tm) Processor 6386 SE, bare metal:
> I got similar result:
> vmware_backdoors (11 tests, 8 unexpected failures)
> svm (13 tests, 1 unexpected failures), it failed on
> FAIL: tsc_adjust
>     Latency VMRUN : max: 181451 min: 13150 avg: 13288
>     Latency VMEXIT: max: 270048 min: 13455 avg: 13623

Right you are,

the failing test is also 'tsc_adjust' for me, npt_rsvd_pfwalk (which
Cathy fixed) is not being executed because we do '-cpu qemu64' for it.

With the following:

diff --git a/x86/unittests.cfg b/x86/unittests.cfg
index b4865ac..5ecb9bb 100644
--- a/x86/unittests.cfg
+++ b/x86/unittests.cfg
@@ -198,7 +198,7 @@ arch = x86_64
 [svm]
 file = svm.flat
 smp = 2
-extra_params = -cpu qemu64,+svm
+extra_params = -cpu host,+svm
 arch = x86_64
 
 [taskswitch]

everything passes, including tsc_adjust:

PASS: tsc_adjust
    Latency VMRUN : max: 43240 min: 3720 avg: 3830
    Latency VMEXIT: max: 36300 min: 3540 avg: 3648

-- 
Vitaly

  reply	other threads:[~2019-10-08 15:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-07 23:47 KVM-unit-tests on AMD Nadav Amit
2019-10-08 12:19 ` Vitaly Kuznetsov
2019-10-08 14:09   ` Jack Wang
2019-10-08 15:06     ` Vitaly Kuznetsov [this message]
2019-10-08 15:55       ` Jack Wang
2019-10-08 16:01       ` Paolo Bonzini
2019-10-08 16:30   ` Nadav Amit
2019-10-08 20:02     ` Nadav Amit
2019-10-09 11:39       ` Cathy Avery
2019-10-09 17:32         ` Nadav Amit
2019-10-09 18:53           ` Cathy Avery
2019-10-09 19:00             ` Nadav Amit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wodfz38m.fsf@vitty.brq.redhat.com \
    --to=vkuznets@redhat.com \
    --cc=cavery@redhat.com \
    --cc=jack.wang.usish@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=nadav.amit@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=sean.j.christopherson@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.