All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Thomas Huth <thuth@redhat.com>,
	qemu-devel@nongnu.org, qemu-block@nongnu.org,
	Max Reitz <mreitz@redhat.com>
Subject: Re: [PATCH] iotests: Do not run the iotests during "make check" anymore
Date: Wed, 02 Oct 2019 18:32:10 +0100	[thread overview]
Message-ID: <87wodnjbol.fsf@linaro.org> (raw)
In-Reply-To: <20191002150329.GA30342@redhat.com>


Daniel P. Berrangé <berrange@redhat.com> writes:

> On Wed, Oct 02, 2019 at 04:21:46PM +0200, Thomas Huth wrote:
>> Running the iotests during "make check" is causing more headaches than
>> benefits for the block layer maintainers, so let's disable the iotests
>> during "make check" again.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>>  tests/Makefile.include   | 2 +-
>>  tests/qemu-iotests/group | 2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> I don't have any objection to removing from 'make check', but I feel
> like this commit should be modifying the travis.yml config so that
> it explicitly runs the block tests, otherwise we're loosing automated
> CI and the block tests will increase their rate of bitrot again.

I think we run a subset on gitlab as well. Do the iotests need any
particular build of QEMU? Lets try and avoid adding unneeded targets.

I must admit I've been out of the loop here. What headaches are they
causing? Too many false positives?


>
>
> Regards,
> Daniel


--
Alex Bennée


  parent reply	other threads:[~2019-10-02 17:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-02 14:21 [PATCH] iotests: Do not run the iotests during "make check" anymore Thomas Huth
2019-10-02 14:39 ` Max Reitz
2019-10-02 15:03 ` Daniel P. Berrangé
2019-10-02 15:10   ` Thomas Huth
2019-10-02 15:50     ` Max Reitz
2019-10-02 23:51       ` John Snow
2019-10-07 13:03         ` Max Reitz
2019-10-07 19:10           ` John Snow
2019-10-02 17:32   ` Alex Bennée [this message]
2019-10-02 17:46     ` Thomas Huth
2019-10-07 10:00 ` Max Reitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wodnjbol.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=berrange@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.