From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: Vladimir Oltean <olteanv@gmail.com>, davem@davemloft.net
Cc: jhs@mojatatu.com, xiyou.wangcong@gmail.com,
netdev@vger.kernel.org, Vladimir Oltean <olteanv@gmail.com>
Subject: Re: [PATCH v2 net] net: sched: taprio: Fix potential integer overflow in taprio_set_picos_per_byte
Date: Mon, 30 Sep 2019 10:19:32 -0700 [thread overview]
Message-ID: <87wodp7lcr.fsf@linux.intel.com> (raw)
In-Reply-To: <20190928230139.4027-1-olteanv@gmail.com>
Vladimir Oltean <olteanv@gmail.com> writes:
> The speed divisor is used in a context expecting an s64, but it is
> evaluated using 32-bit arithmetic.
>
> To avoid that happening, instead of multiplying by 1,000,000 in the
> first place, simplify the fraction and do a standard 32 bit division
> instead.
>
> Fixes: f04b514c0ce2 ("taprio: Set default link speed to 10 Mbps in taprio_set_picos_per_byte")
> Reported-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> Suggested-by: Eric Dumazet <eric.dumazet@gmail.com>
> Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
> ---
Acked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
next prev parent reply other threads:[~2019-09-30 20:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-28 23:01 [PATCH v2 net] net: sched: taprio: Fix potential integer overflow in taprio_set_picos_per_byte Vladimir Oltean
2019-09-30 17:19 ` Vinicius Costa Gomes [this message]
2019-10-01 1:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wodp7lcr.fsf@linux.intel.com \
--to=vinicius.gomes@intel.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.