From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH] drm/i915/execlists: Ignore lost completion events Date: Wed, 04 Sep 2019 10:16:30 +0300 Message-ID: <87woeotttd.fsf@gaia.fi.intel.com> References: <20190831082520.30155-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id B3B11891D7 for ; Wed, 4 Sep 2019 07:16:40 +0000 (UTC) In-Reply-To: <20190831082520.30155-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gSWNlbGFr ZSBoaXQgYW4gaXNzdWUgd2hlcmUgaXQgbWlzc2VkIHJlcG9ydGluZyBhIGNvbXBsZXRpb24gZXZl bnQgYW5kCj4gaW5zdGVhZCBqdW1wZWQgc3RyYWlnaHQgdG8gYSBpZGxlLT5hY3RpdmUgZXZlbnQg KHNraXBwaW5nIG92ZXIgdGhlCj4gYWN0aXZlLT5pZGxlIGFuZCBub3QgZXZlbiBoaXR0aW5nIHRo ZSBsaXRlLXJlc3RvcmUgcHJlZW1wdGlvbikuCj4KPiA2NjE0OTc1MTF1cyA6IHByb2Nlc3NfY3Ni OiByY3MwIGNzLWlycSBoZWFkPTExLCB0YWlsPTAKPiA2NjE0OTc1MTJ1cyA6IHByb2Nlc3NfY3Ni OiByY3MwIGNzYlswXTogc3RhdHVzPTB4MTAwMDgwMDI6MHgwMDAwMDAyMCBbbGl0ZS1yZXN0b3Jl XQo+IDY2MTQ5NzUxMnVzIDogdHJhY2VfcG9ydHM6IHJjczA6IHByZWVtcHRlZCB7IDI4Y2M4OjEx MDUyLCAwOjAgfQo+IDY2MTQ5NzUxM3VzIDogdHJhY2VfcG9ydHM6IHJjczA6IHByb21vdGUgeyAy OGNjODoxMTA1NCwgMDowIH0KPiA2NjE0OTc1MTR1cyA6IF9faTkxNV9yZXF1ZXN0X3N1Ym1pdDog cmNzMCBmZW5jZSAyOGNjODoxMTA1NiwgY3VycmVudCAxMTA1Mgo+IDY2MTQ5NzUxNHVzIDogX19l eGVjbGlzdHNfc3VibWlzc2lvbl90YXNrbGV0OiByY3MwOiBxdWV1ZV9wcmlvcml0eV9oaW50Oi0y MTQ3NDgzNjQ4LCBzdWJtaXQ6eWVzCj4gNjYxNDk3NTE1dXMgOiB0cmFjZV9wb3J0czogcmNzMDog c3VibWl0IHsgMjhjYzg6MTEwNTYsIDA6MCB9Cj4gNjYxNDk3NTMwdXMgOiBwcm9jZXNzX2NzYjog cmNzMCBjcy1pcnEgaGVhZD0wLCB0YWlsPTEKPiA2NjE0OTc1MzB1cyA6IHByb2Nlc3NfY3NiOiBy Y3MwIGNzYlsxXTogc3RhdHVzPTB4MTAwMDgwMDI6MHgwMDAwMDAyMCBbbGl0ZS1yZXN0b3JlXQo+ IDY2MTQ5NzUzMXVzIDogdHJhY2VfcG9ydHM6IHJjczA6IHByZWVtcHRlZCB7IDI4Y2M4OjExMDU0 ISwgMDowIH0KPiA2NjE0OTc1MzV1cyA6IHRyYWNlX3BvcnRzOiByY3MwOiBwcm9tb3RlIHsgMjhj Yzg6MTEwNTYsIDA6MCB9Cj4gNjYxNDk3NTQwdXMgOiBfX2k5MTVfcmVxdWVzdF9zdWJtaXQ6IHJj czAgZmVuY2UgMjhjYzg6MTEwNTgsIGN1cnJlbnQgMTEwNTQKPiA2NjE0OTc1NDR1cyA6IF9fZXhl Y2xpc3RzX3N1Ym1pc3Npb25fdGFza2xldDogcmNzMDogcXVldWVfcHJpb3JpdHlfaGludDotMjE0 NzQ4MzY0OCwgc3VibWl0Onllcwo+IDY2MTQ5NzU0NXVzIDogdHJhY2VfcG9ydHM6IHJjczA6IHN1 Ym1pdCB7IDI4Y2M4OjExMDU4LCAwOjAgfQo+IDY2MTQ5NzU1M3VzIDogcHJvY2Vzc19jc2I6IHJj czAgY3MtaXJxIGhlYWQ9MSwgdGFpbD0yCj4gNjYxNDk3NTUzdXMgOiBwcm9jZXNzX2NzYjogcmNz MCBjc2JbMl06IHN0YXR1cz0weDEwMDAwMDAxOjB4MDAwMDAwMDAgW2lkbGUtPmFjdGl2ZV0KPiA2 NjE0OTc1NzR1cyA6IHByb2Nlc3NfY3NiOiBwcm9jZXNzX2NzYjoxNTM4IEdFTV9CVUdfT04oKmV4 ZWNsaXN0cy0+YWN0aXZlKQo+CgpJbiBDST8gKHJlZikKCj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMg V2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gQ2M6IE1pa2EgS3VvcHBhbGEgPG1p a2Eua3VvcHBhbGFAbGludXguaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkx NS9ndC9pbnRlbF9scmMuYyB8IDYzICsrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gIDEg ZmlsZSBjaGFuZ2VkLCAxOCBpbnNlcnRpb25zKCspLCA0NSBkZWxldGlvbnMoLSkKPgo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9ndC9pbnRlbF9scmMuYyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2d0L2ludGVsX2xyYy5jCj4gaW5kZXggMGUyODI2M2M3Yjg3Li45ZDUwZmQzYjg5 NmMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3QvaW50ZWxfbHJjLmMKPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9ndC9pbnRlbF9scmMuYwo+IEBAIC02OTMsNiArNjkz LDkgQEAgdHJhY2VfcG9ydHMoY29uc3Qgc3RydWN0IGludGVsX2VuZ2luZV9leGVjbGlzdHMgKmV4 ZWNsaXN0cywKPiAgCWNvbnN0IHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSA9Cj4gIAkJ Y29udGFpbmVyX29mKGV4ZWNsaXN0cywgdHlwZW9mKCplbmdpbmUpLCBleGVjbGlzdHMpOwo+ICAK PiArCWlmICghcG9ydHNbMF0pCj4gKwkJcmV0dXJuOwo+ICsKPiAgCUdFTV9UUkFDRSgiJXM6ICVz IHsgJWxseDolbGxkJXMsICVsbHg6JWxsZCB9XG4iLAo+ICAJCSAgZW5naW5lLT5uYW1lLCBtc2cs Cj4gIAkJICBwb3J0c1swXS0+ZmVuY2UuY29udGV4dCwKPiBAQCAtMTM3MSwxMyArMTM3NCw2IEBA IHJlc2V0X2luX3Byb2dyZXNzKGNvbnN0IHN0cnVjdCBpbnRlbF9lbmdpbmVfZXhlY2xpc3RzICpl eGVjbGlzdHMpCj4gIAlyZXR1cm4gdW5saWtlbHkoIV9fdGFza2xldF9pc19lbmFibGVkKCZleGVj bGlzdHMtPnRhc2tsZXQpKTsKPiAgfQo+ICAKPiAtZW51bSBjc2Jfc3RlcCB7Cj4gLQlDU0JfTk9Q LAo+IC0JQ1NCX1BST01PVEUsCj4gLQlDU0JfUFJFRU1QVCwKPiAtCUNTQl9DT01QTEVURSwKPiAt fTsKPiAtCj4gIC8qCj4gICAqIFN0YXJ0aW5nIHdpdGggR2VuMTIsIHRoZSBzdGF0dXMgaGFzIGEg bmV3IGZvcm1hdDoKPiAgICoKPiBAQCAtMTQwNCw3ICsxNDAwLDcgQEAgZW51bSBjc2Jfc3RlcCB7 Cj4gICAqICAgICBiaXRzIDQ3LTU3OiBzdyBjb250ZXh0IGlkIG9mIHRoZSBscmMgdGhlIEdUIHN3 aXRjaGVkIGF3YXkgZnJvbQo+ICAgKiAgICAgYml0cyA1OC02Mzogc3cgY291bnRlciBvZiB0aGUg bHJjIHRoZSBHVCBzd2l0Y2hlZCBhd2F5IGZyb20KPiAgICovCj4gLXN0YXRpYyBpbmxpbmUgZW51 bSBjc2Jfc3RlcAo+ICtzdGF0aWMgaW5saW5lIGJvb2wKPiAgZ2VuMTJfY3NiX3BhcnNlKGNvbnN0 IHN0cnVjdCBpbnRlbF9lbmdpbmVfZXhlY2xpc3RzICpleGVjbGlzdHMsIGNvbnN0IHUzMiAqY3Ni KQoKc2hvdWxkIGl0IGJlIGdlbjExX3Nob3VsZF9wcm9tb3RlIG5vdz8KLU1pa2EKCj4gIHsKPiAg CXUzMiBsb3dlcl9kdyA9IGNzYlswXTsKPiBAQCAtMTQxNCw3ICsxNDEwLDcgQEAgZ2VuMTJfY3Ni X3BhcnNlKGNvbnN0IHN0cnVjdCBpbnRlbF9lbmdpbmVfZXhlY2xpc3RzICpleGVjbGlzdHMsIGNv bnN0IHUzMiAqY3NiKQo+ICAJYm9vbCBuZXdfcXVldWUgPSBsb3dlcl9kdyAmIEdFTjEyX0NUWF9T VEFUVVNfU1dJVENIRURfVE9fTkVXX1FVRVVFOwo+ICAKPiAgCWlmICghY3R4X2F3YXlfdmFsaWQg JiYgY3R4X3RvX3ZhbGlkKQo+IC0JCXJldHVybiBDU0JfUFJPTU9URTsKPiArCQlyZXR1cm4gdHJ1 ZTsKPiAgCj4gIAkvKgo+ICAJICogVGhlIGNvbnRleHQgc3dpdGNoIGRldGFpbCBpcyBub3QgZ3Vh cmFudGVlZCB0byBiZSA1IHdoZW4gYSBwcmVlbXB0aW9uCj4gQEAgLTE0MjQsNyArMTQyMCw3IEBA IGdlbjEyX2NzYl9wYXJzZShjb25zdCBzdHJ1Y3QgaW50ZWxfZW5naW5lX2V4ZWNsaXN0cyAqZXhl Y2xpc3RzLCBjb25zdCB1MzIgKmNzYikKPiAgCSAqIHdvdWxkIHJlcXVpcmUgc29tZSBleHRyYSBo YW5kbGluZywgYnV0IHdlIGRvbid0IHN1cHBvcnQgdGhhdC4KPiAgCSAqLwo+ICAJaWYgKG5ld19x dWV1ZSAmJiBjdHhfYXdheV92YWxpZCkKPiAtCQlyZXR1cm4gQ1NCX1BSRUVNUFQ7Cj4gKwkJcmV0 dXJuIHRydWU7Cj4gIAo+ICAJLyoKPiAgCSAqIHN3aXRjaCBkZXRhaWwgPSA1IGlzIGNvdmVyZWQg YnkgdGhlIGNhc2UgYWJvdmUgYW5kIHdlIGRvIG5vdCBleHBlY3QgYQo+IEBAIC0xNDMzLDI5ICsx NDI5LDEzIEBAIGdlbjEyX2NzYl9wYXJzZShjb25zdCBzdHJ1Y3QgaW50ZWxfZW5naW5lX2V4ZWNs aXN0cyAqZXhlY2xpc3RzLCBjb25zdCB1MzIgKmNzYikKPiAgCSAqLwo+ICAJR0VNX0JVR19PTihH RU4xMl9DVFhfU1dJVENIX0RFVEFJTCh1cHBlcl9kdykpOwo+ICAKPiAtCWlmICgqZXhlY2xpc3Rz LT5hY3RpdmUpIHsKPiAtCQlHRU1fQlVHX09OKCFjdHhfYXdheV92YWxpZCk7Cj4gLQkJcmV0dXJu IENTQl9DT01QTEVURTsKPiAtCX0KPiAtCj4gLQlyZXR1cm4gQ1NCX05PUDsKPiArCXJldHVybiBm YWxzZTsKPiAgfQo+ICAKPiAtc3RhdGljIGlubGluZSBlbnVtIGNzYl9zdGVwCj4gK3N0YXRpYyBp bmxpbmUgYm9vbAo+ICBnZW44X2NzYl9wYXJzZShjb25zdCBzdHJ1Y3QgaW50ZWxfZW5naW5lX2V4 ZWNsaXN0cyAqZXhlY2xpc3RzLCBjb25zdCB1MzIgKmNzYikKPiAgewo+IC0JdW5zaWduZWQgaW50 IHN0YXR1cyA9ICpjc2I7Cj4gLQo+IC0JaWYgKHN0YXR1cyAmIEdFTjhfQ1RYX1NUQVRVU19JRExF X0FDVElWRSkKPiAtCQlyZXR1cm4gQ1NCX1BST01PVEU7Cj4gLQo+IC0JaWYgKHN0YXR1cyAmIEdF TjhfQ1RYX1NUQVRVU19QUkVFTVBURUQpCj4gLQkJcmV0dXJuIENTQl9QUkVFTVBUOwo+IC0KPiAt CWlmICgqZXhlY2xpc3RzLT5hY3RpdmUpCj4gLQkJcmV0dXJuIENTQl9DT01QTEVURTsKPiAtCj4g LQlyZXR1cm4gQ1NCX05PUDsKPiArCXJldHVybiAqY3NiICYgKEdFTjhfQ1RYX1NUQVRVU19JRExF X0FDVElWRSB8IEdFTjhfQ1RYX1NUQVRVU19QUkVFTVBURUQpOwo+ICB9Cj4gIAo+ICBzdGF0aWMg dm9pZCBwcm9jZXNzX2NzYihzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gQEAgLTE0 OTQsNyArMTQ3NCw3IEBAIHN0YXRpYyB2b2lkIHByb2Nlc3NfY3NiKHN0cnVjdCBpbnRlbF9lbmdp bmVfY3MgKmVuZ2luZSkKPiAgCXJtYigpOwo+ICAKPiAgCWRvIHsKPiAtCQllbnVtIGNzYl9zdGVw IGNzYl9zdGVwOwo+ICsJCWJvb2wgcHJvbW90ZTsKPiAgCj4gIAkJaWYgKCsraGVhZCA9PSBudW1f ZW50cmllcykKPiAgCQkJaGVhZCA9IDA7Cj4gQEAgLTE1MjIsMjAgKzE1MDIsMTYgQEAgc3RhdGlj IHZvaWQgcHJvY2Vzc19jc2Ioc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAJCQkg IGJ1ZlsyICogaGVhZCArIDBdLCBidWZbMiAqIGhlYWQgKyAxXSk7Cj4gIAo+ICAJCWlmIChJTlRF TF9HRU4oZW5naW5lLT5pOTE1KSA+PSAxMikKPiAtCQkJY3NiX3N0ZXAgPSBnZW4xMl9jc2JfcGFy c2UoZXhlY2xpc3RzLCBidWYgKyAyICogaGVhZCk7Cj4gKwkJCXByb21vdGUgPSBnZW4xMl9jc2Jf cGFyc2UoZXhlY2xpc3RzLCBidWYgKyAyICogaGVhZCk7Cj4gIAkJZWxzZQo+IC0JCQljc2Jfc3Rl cCA9IGdlbjhfY3NiX3BhcnNlKGV4ZWNsaXN0cywgYnVmICsgMiAqIGhlYWQpOwo+IC0KPiAtCQlz d2l0Y2ggKGNzYl9zdGVwKSB7Cj4gLQkJY2FzZSBDU0JfUFJFRU1QVDogLyogY2FuY2VsIG9sZCBp bmZsaWdodCwgcHJlcGFyZSBmb3Igc3dpdGNoICovCj4gKwkJCXByb21vdGUgPSBnZW44X2NzYl9w YXJzZShleGVjbGlzdHMsIGJ1ZiArIDIgKiBoZWFkKTsKPiArCQlpZiAocHJvbW90ZSkgewo+ICsJ CQkvKiBjYW5jZWwgb2xkIGluZmxpZ2h0LCBwcmVwYXJlIGZvciBzd2l0Y2ggKi8KPiAgCQkJdHJh Y2VfcG9ydHMoZXhlY2xpc3RzLCAicHJlZW1wdGVkIiwgZXhlY2xpc3RzLT5hY3RpdmUpOwo+IC0K PiAgCQkJd2hpbGUgKCpleGVjbGlzdHMtPmFjdGl2ZSkKPiAgCQkJCWV4ZWNsaXN0c19zY2hlZHVs ZV9vdXQoKmV4ZWNsaXN0cy0+YWN0aXZlKyspOwo+ICAKPiAtCQkJLyogZmFsbHRocm91Z2ggKi8K PiAtCQljYXNlIENTQl9QUk9NT1RFOiAvKiBzd2l0Y2ggcGVuZGluZyB0byBpbmZsaWdodCAqLwo+ IC0JCQlHRU1fQlVHX09OKCpleGVjbGlzdHMtPmFjdGl2ZSk7Cj4gKwkJCS8qIHN3aXRjaCBwZW5k aW5nIHRvIGluZmxpZ2h0ICovCj4gIAkJCUdFTV9CVUdfT04oIWFzc2VydF9wZW5kaW5nX3ZhbGlk KGV4ZWNsaXN0cywgInByb21vdGUiKSk7Cj4gIAkJCWV4ZWNsaXN0cy0+YWN0aXZlID0KPiAgCQkJ CW1lbWNweShleGVjbGlzdHMtPmluZmxpZ2h0LAo+IEBAIC0xNTUwLDkgKzE1MjYsMTAgQEAgc3Rh dGljIHZvaWQgcHJvY2Vzc19jc2Ioc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAJ CQkJcmluZ19zZXRfcGF1c2VkKGVuZ2luZSwgMCk7Cj4gIAo+ICAJCQlXUklURV9PTkNFKGV4ZWNs aXN0cy0+cGVuZGluZ1swXSwgTlVMTCk7Cj4gLQkJCWJyZWFrOwo+ICsJCX0gZWxzZSB7Cj4gKwkJ CUdFTV9CVUdfT04oISpleGVjbGlzdHMtPmFjdGl2ZSk7Cj4gIAo+IC0JCWNhc2UgQ1NCX0NPTVBM RVRFOiAvKiBwb3J0MCBjb21wbGV0ZWQsIGFkdmFuY2VkIHRvIHBvcnQxICovCj4gKwkJCS8qIHBv cnQwIGNvbXBsZXRlZCwgYWR2YW5jZWQgdG8gcG9ydDEgKi8KPiAgCQkJdHJhY2VfcG9ydHMoZXhl Y2xpc3RzLCAiY29tcGxldGVkIiwgZXhlY2xpc3RzLT5hY3RpdmUpOwo+ICAKPiAgCQkJLyoKPiBA QCAtMTU2NywxMCArMTU0NCw2IEBAIHN0YXRpYyB2b2lkIHByb2Nlc3NfY3NiKHN0cnVjdCBpbnRl bF9lbmdpbmVfY3MgKmVuZ2luZSkKPiAgCj4gIAkJCUdFTV9CVUdfT04oZXhlY2xpc3RzLT5hY3Rp dmUgLSBleGVjbGlzdHMtPmluZmxpZ2h0ID4KPiAgCQkJCSAgIGV4ZWNsaXN0c19udW1fcG9ydHMo ZXhlY2xpc3RzKSk7Cj4gLQkJCWJyZWFrOwo+IC0KPiAtCQljYXNlIENTQl9OT1A6Cj4gLQkJCWJy ZWFrOwo+ICAJCX0KPiAgCX0gd2hpbGUgKGhlYWQgIT0gdGFpbCk7Cj4gIAo+IC0tIAo+IDIuMjMu MApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1n ZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=