From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.86_2) id 1hpYYf-0006AC-1b for mharc-qemu-riscv@gnu.org; Mon, 22 Jul 2019 09:40:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54411) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpYYc-0005wz-0v for qemu-riscv@nongnu.org; Mon, 22 Jul 2019 09:40:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hpYYa-0004eW-OE for qemu-riscv@nongnu.org; Mon, 22 Jul 2019 09:40:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49314) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hpYYU-0004Y3-UT; Mon, 22 Jul 2019 09:40:43 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3EF7A3082E1E; Mon, 22 Jul 2019 13:40:41 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-117-244.ams2.redhat.com [10.36.117.244]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 046431017E30; Mon, 22 Jul 2019 13:40:30 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 6201F113865F; Mon, 22 Jul 2019 15:40:29 +0200 (CEST) From: Markus Armbruster To: Thomas Huth Cc: Paolo Bonzini , Collin Walling , Peter Maydell , Palmer Dabbelt , "open list\:RISC-V" , Eduardo Habkost , Sagar Karandikar , "Michael S. Tsirkin" , Helge Deller , Cornelia Huck , Mark Cave-Ayland , QEMU Developers , Aurelien Jarno , "open list\:S390" , qemu-arm , Alistair Francis , Gerd Hoffmann , qemu-ppc , Richard Henderson , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Artyom Tarasenko , David Gibson References: <20190715095545.28545-1-philmd@redhat.com> <20190715095545.28545-2-philmd@redhat.com> <6d69e8ad-d720-ce04-20f2-a03193903078@redhat.com> <20190715125653.6e65d575.cohuck@redhat.com> <20190715130955.4a117388.cohuck@redhat.com> <13fce62f-234c-1b13-595f-5910c066bc4f@redhat.com> <6c39a198-e951-c0bd-1ddc-5d227afe72ff@redhat.com> <87a7dfth4i.fsf@dusky.pond.sub.org> <20190715181206.3cb1db93.cohuck@redhat.com> <799aa0f5-8850-5caa-5103-e1cf3cdb018f@redhat.com> <87h87m2knh.fsf@dusky.pond.sub.org> Date: Mon, 22 Jul 2019 15:40:29 +0200 In-Reply-To: (Thomas Huth's message of "Tue, 16 Jul 2019 17:04:24 +0200") Message-ID: <87wogayype.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Mon, 22 Jul 2019 13:40:41 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-riscv] [Qemu-devel] [qemu-s390x] [RFC PATCH 1/3] hw/Kconfig: PCI bus implies PCI_DEVICES X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jul 2019 13:40:51 -0000 Thomas Huth writes: > On 16/07/2019 15.06, Markus Armbruster wrote: [...] >> 2. We want a way to Kconfig the PCI devices that work, i.e. only the >> ones that support MSI or MSI-X. >> >> I don't like calling devices without any MSI capability "classic" or >> "conventional devices". I'd rather call them "MSI-capable" or >> "MSI/MSI-X devices". > > But you still need a config switch that you can set to enable the > non-MSI devices ... what's so wrong with "conventional" if that's even > the wording from the PCI SIG? PCI Express Base Specification, rev. 3.0, section Terms and Acronyms: conventional PCI Behavior or features that conform to the PCI Local Bus Specification. In other words, "conventional PCI" is non-Express PCI. A PCI Express device *must* support MSI or MSI-X. See PCI Express Base Specification, rev. 3.0, section 7.7. MSI and MSI-X Capability Structures. A "conventional" PCI device *may* support MSI or MSI-X. See PCI Local Bus Specification Revision 3.0 section 6.8. Message Signaled Interrupts. Conflating MSI-capable with conventional vs. Express is therefore wrong. [...] From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a5d:51d0:0:0:0:0:0 with SMTP id n16csp6917158wrv; Mon, 22 Jul 2019 06:40:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqzdz+9y6BnMMxLhw9DZ0d0uOB9SBK7vqEBUIguIJi9GPEw00V4TbGODG35Jho8ctPbqgTls X-Received: by 2002:a17:906:d8ab:: with SMTP id qc11mr53787873ejb.219.1563802848632; Mon, 22 Jul 2019 06:40:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563802848; cv=none; d=google.com; s=arc-20160816; b=ZUv5lFpJUlxKf4GL0BEFbI7nnStOTbiHokhry2rkgAP8UiwQBnPJj3uN9Ow3ZijfZe iSO4SZs8+R5zhV0QiZkTTCXOUJALQwqB6njSSnX00nxFidHu9g3lma6zhoW09xwZlUOI uwZfrqXFK2dnJWrgii38Ad8fZYVl+qROPUal9aEFQ+VpHDQjH1VmJr+NOmPY6o8mbkb5 6If71AqmJ4GVEJUr0mg48RzQa1A1+KE68naVib8PmsH7kkm7/63rscHalHLttYq7J9FN QN/hVZOnztUwC6Y/cLCd7+uC1EsT86TMhcmXLrsoTHyl0BpWZqUc2WD/u91gABOo896+ iMiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:mime-version:user-agent :message-id:in-reply-to:date:references:to:from; bh=QZtxKFJHOuFYhGMd4HERDnZ/M3IFhcth9r1KV1PrHwI=; b=ndFLZu7z95M31x+2FbwrKBQXtk29nVrwIb+T2NG+fKi6knUlwGb6Q7TJddkpnOd1Oq wLK2q7i0eQpK66neb4seuUijCPJGf85BlnE8TZEdlXak+CipISuGAauOeYA/+YUzDGDE 9I5Wn1PQ02C0RKDmI/d5X6c/eFmnWFqeQeGcGuZ+J12N/mexD7wBVwhce6z3z6eOblIz VEeZe/lOoiVLAfLGQ5z9rOSLVemo6Lt9lpU+TWT7SlzSSv8uk69VGOsYDW3aFqsX4fyA eLvJbLkGz9AO6tif2fnwU2DHdLuRftbaZzZd2cR4zFXaAvS3QY6CA8xzxFR2OIYumq4+ 9VxQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id g39si5594339edc.434.2019.07.22.06.40.48 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 22 Jul 2019 06:40:48 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:33692 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpYYZ-0005jO-Pq for alex.bennee@linaro.org; Mon, 22 Jul 2019 09:40:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54373) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpYYW-0005j9-5v for qemu-arm@nongnu.org; Mon, 22 Jul 2019 09:40:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hpYYV-0004ZZ-7q for qemu-arm@nongnu.org; Mon, 22 Jul 2019 09:40:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49314) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hpYYU-0004Y3-UT; Mon, 22 Jul 2019 09:40:43 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3EF7A3082E1E; Mon, 22 Jul 2019 13:40:41 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-117-244.ams2.redhat.com [10.36.117.244]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 046431017E30; Mon, 22 Jul 2019 13:40:30 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 6201F113865F; Mon, 22 Jul 2019 15:40:29 +0200 (CEST) From: Markus Armbruster To: Thomas Huth References: <20190715095545.28545-1-philmd@redhat.com> <20190715095545.28545-2-philmd@redhat.com> <6d69e8ad-d720-ce04-20f2-a03193903078@redhat.com> <20190715125653.6e65d575.cohuck@redhat.com> <20190715130955.4a117388.cohuck@redhat.com> <13fce62f-234c-1b13-595f-5910c066bc4f@redhat.com> <6c39a198-e951-c0bd-1ddc-5d227afe72ff@redhat.com> <87a7dfth4i.fsf@dusky.pond.sub.org> <20190715181206.3cb1db93.cohuck@redhat.com> <799aa0f5-8850-5caa-5103-e1cf3cdb018f@redhat.com> <87h87m2knh.fsf@dusky.pond.sub.org> Date: Mon, 22 Jul 2019 15:40:29 +0200 In-Reply-To: (Thomas Huth's message of "Tue, 16 Jul 2019 17:04:24 +0200") Message-ID: <87wogayype.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Mon, 22 Jul 2019 13:40:41 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-arm] [Qemu-devel] [qemu-s390x] [RFC PATCH 1/3] hw/Kconfig: PCI bus implies PCI_DEVICES X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Collin Walling , Sagar Karandikar , "Michael S. Tsirkin" , Palmer Dabbelt , Mark Cave-Ayland , QEMU Developers , Alistair Francis , Gerd Hoffmann , Helge Deller , Richard Henderson , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Artyom Tarasenko , Eduardo Habkost , "open list:S390" , qemu-arm , David Gibson , "open list:RISC-V" , Cornelia Huck , qemu-ppc , Paolo Bonzini , Aurelien Jarno Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: //MT0Mp2O+kZ Thomas Huth writes: > On 16/07/2019 15.06, Markus Armbruster wrote: [...] >> 2. We want a way to Kconfig the PCI devices that work, i.e. only the >> ones that support MSI or MSI-X. >> >> I don't like calling devices without any MSI capability "classic" or >> "conventional devices". I'd rather call them "MSI-capable" or >> "MSI/MSI-X devices". > > But you still need a config switch that you can set to enable the > non-MSI devices ... what's so wrong with "conventional" if that's even > the wording from the PCI SIG? PCI Express Base Specification, rev. 3.0, section Terms and Acronyms: conventional PCI Behavior or features that conform to the PCI Local Bus Specification. In other words, "conventional PCI" is non-Express PCI. A PCI Express device *must* support MSI or MSI-X. See PCI Express Base Specification, rev. 3.0, section 7.7. MSI and MSI-X Capability Structures. A "conventional" PCI device *may* support MSI or MSI-X. See PCI Local Bus Specification Revision 3.0 section 6.8. Message Signaled Interrupts. Conflating MSI-capable with conventional vs. Express is therefore wrong. [...] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91468C76188 for ; Mon, 22 Jul 2019 13:40:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 63BA5216C8 for ; Mon, 22 Jul 2019 13:40:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 63BA5216C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33702 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpYYk-0006LY-Fm for qemu-devel@archiver.kernel.org; Mon, 22 Jul 2019 09:40:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54388) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpYYX-0005jK-VS for qemu-devel@nongnu.org; Mon, 22 Jul 2019 09:40:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hpYYX-0004bT-4C for qemu-devel@nongnu.org; Mon, 22 Jul 2019 09:40:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49314) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hpYYU-0004Y3-UT; Mon, 22 Jul 2019 09:40:43 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3EF7A3082E1E; Mon, 22 Jul 2019 13:40:41 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-117-244.ams2.redhat.com [10.36.117.244]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 046431017E30; Mon, 22 Jul 2019 13:40:30 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 6201F113865F; Mon, 22 Jul 2019 15:40:29 +0200 (CEST) From: Markus Armbruster To: Thomas Huth References: <20190715095545.28545-1-philmd@redhat.com> <20190715095545.28545-2-philmd@redhat.com> <6d69e8ad-d720-ce04-20f2-a03193903078@redhat.com> <20190715125653.6e65d575.cohuck@redhat.com> <20190715130955.4a117388.cohuck@redhat.com> <13fce62f-234c-1b13-595f-5910c066bc4f@redhat.com> <6c39a198-e951-c0bd-1ddc-5d227afe72ff@redhat.com> <87a7dfth4i.fsf@dusky.pond.sub.org> <20190715181206.3cb1db93.cohuck@redhat.com> <799aa0f5-8850-5caa-5103-e1cf3cdb018f@redhat.com> <87h87m2knh.fsf@dusky.pond.sub.org> Date: Mon, 22 Jul 2019 15:40:29 +0200 In-Reply-To: (Thomas Huth's message of "Tue, 16 Jul 2019 17:04:24 +0200") Message-ID: <87wogayype.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Mon, 22 Jul 2019 13:40:41 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [qemu-s390x] [RFC PATCH 1/3] hw/Kconfig: PCI bus implies PCI_DEVICES X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Collin Walling , Sagar Karandikar , "Michael S. Tsirkin" , Palmer Dabbelt , Mark Cave-Ayland , QEMU Developers , Alistair Francis , Gerd Hoffmann , Helge Deller , Richard Henderson , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Artyom Tarasenko , Eduardo Habkost , "open list:S390" , qemu-arm , David Gibson , "open list:RISC-V" , Cornelia Huck , qemu-ppc , Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Thomas Huth writes: > On 16/07/2019 15.06, Markus Armbruster wrote: [...] >> 2. We want a way to Kconfig the PCI devices that work, i.e. only the >> ones that support MSI or MSI-X. >> >> I don't like calling devices without any MSI capability "classic" or >> "conventional devices". I'd rather call them "MSI-capable" or >> "MSI/MSI-X devices". > > But you still need a config switch that you can set to enable the > non-MSI devices ... what's so wrong with "conventional" if that's even > the wording from the PCI SIG? PCI Express Base Specification, rev. 3.0, section Terms and Acronyms: conventional PCI Behavior or features that conform to the PCI Local Bus Specification. In other words, "conventional PCI" is non-Express PCI. A PCI Express device *must* support MSI or MSI-X. See PCI Express Base Specification, rev. 3.0, section 7.7. MSI and MSI-X Capability Structures. A "conventional" PCI device *may* support MSI or MSI-X. See PCI Local Bus Specification Revision 3.0 section 6.8. Message Signaled Interrupts. Conflating MSI-capable with conventional vs. Express is therefore wrong. [...]