From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Jim Mattson <jmattson@google.com>
Cc: kvm list <kvm@vger.kernel.org>
Subject: Re: What's with all of the hardcoded instruction lengths in svm.c?
Date: Fri, 14 Jun 2019 19:01:48 +0200 [thread overview]
Message-ID: <87woho5ceb.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <CALMp9eTe_iSgn5ihod_B=H1JzXwc_=CW22u+5sQCyPT=EJuLPQ@mail.gmail.com>
Jim Mattson <jmattson@google.com> writes:
> On Thu, Jun 13, 2019 at 6:55 AM Vitaly Kuznetsov <vkuznets@redhat.com> wrote:
>
>> I can try sending a patch removing the manual advancement to see if
>> anyone has any objections.
>
> That would be great!
>
Turns out this is harder than I initially thought, in the emulator we
don't emulate everything (e.g. XSETVB) and emulating some instructions
(even with EMULTYPE_SKIP) gives us some unintended side-effects,
e.g. I'm currently observing a hang when trying to apply
kvm_emulate_instruction() to HLT.
Overall, I still think this is the right approach, we just need to make
EMULTYPE_SKIP skip correctly. Stay tuned...
--
Vitaly
prev parent reply other threads:[~2019-06-14 17:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 20:17 What's with all of the hardcoded instruction lengths in svm.c? Jim Mattson
2019-06-13 13:55 ` Vitaly Kuznetsov
2019-06-13 16:08 ` Jim Mattson
2019-06-14 17:01 ` Vitaly Kuznetsov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87woho5ceb.fsf@vitty.brq.redhat.com \
--to=vkuznets@redhat.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.