From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: Potential NULL pointer dereference in intel_crt_get_edid Date: Tue, 19 Mar 2019 10:32:00 +0200 Message-ID: <87wokvfenz.fsf@intel.com> References: <3c286170-5ac2-5599-bd78-3e70f0040cbc@cs.utah.edu> <20190318232631.GA27875@intel.com> <20190318235308.GB27875@intel.com> <034acd15-aa17-8881-0a33-7e6a0f01f202@cs.utah.edu> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id AF73D899C4 for ; Tue, 19 Mar 2019 08:30:17 +0000 (UTC) In-Reply-To: <034acd15-aa17-8881-0a33-7e6a0f01f202@cs.utah.edu> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Shaobo He , Rodrigo Vivi Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCAxOCBNYXIgMjAxOSwgU2hhb2JvIEhlIDxzaGFvYm9AY3MudXRhaC5lZHU+IHdyb3Rl Ogo+IEkgc2VlLiBJbiBsaWdodCBvZiB0aGlzIGNvbW1pdCwgaXMgaXQgYSBiZXR0ZXIgc29sdXRp b24gdGhhbiBhZGRpbmcgTlVMTC1jaGVja3MgCj4gaXMgdG8gcmVwbGFjZSB0aGUgaWYgYnJhbmNo IGNvbmRpdGlvbmVkIGJ5IGBXQVJOX09OYCB3aXRoIHNpbXBseSBgV0FSTmAgbGlrZSB0aGUgCj4g Zm9sbG93aW5nLAo+Cj4gc3RydWN0IGkyY19hZGFwdGVyICppbnRlbF9nbWJ1c19nZXRfYWRhcHRl cihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gCQkJCQkgICAgdW5zaWduZWQg aW50IHBpbikKPiB7Cj4gCVdBUk4oIWludGVsX2dtYnVzX2lzX3ZhbGlkX3BpbihkZXZfcHJpdiwg cGluKSwgIkludmFsaWQgcGluOiAlZFxuIiwgcGluKTsKPgo+IAlyZXR1cm4gJmRldl9wcml2LT5n bWJ1c1twaW5dLmFkYXB0ZXI7Cj4gfQoKU28gYWxsIG9mIHRoaXMgZGlzY3Vzc2lvbiBpcyBoeXBv dGhldGljYWwgaW4gdGhlIHNlbnNlIHRoYXQgaXQgcmVhbGx5CnNob3VsZCBuZXZlciBoYXBwZW4u IFlvdSBjYW4gdHJhY2sgZG93biB0aGUgYXJncyBwYXNzZWQgdG8KaW50ZWxfZ21idXNfZ2V0X2Fk YXB0ZXIoKSwgd2hpbGUgdGhlIHN0YXRpYyBhbmFseXplciBpcyB1bmFibGUgdG8gZG8KdGhhdC4K CkJSLApKYW5pLgoKCj4KPiBTaGFvYm8KPiBPbiAzLzE4LzE5IDU6NTMgUE0sIFJvZHJpZ28gVml2 aSB3cm90ZToKPj4gT24gTW9uLCBNYXIgMTgsIDIwMTkgYXQgMDU6Mzk6NDhQTSAtMDYwMCwgU2hh b2JvIEhlIHdyb3RlOgo+Pj4gSGkgUm9kcmlnbywKPj4+Cj4+PiBTb3JyeSBJJ20gYSBiaXQgbG9z dCBoZXJlLiBNYXkgSSBhc2sgd2hlcmUgdGhlIGBXQVJOYCBpcz8KPj4gCj4+IGFsb25nIHdpdGgg dGhlIHJldHVybiBOVUxMCj4+IAo+PiBzdHJ1Y3QgaTJjX2FkYXB0ZXIgKmludGVsX2dtYnVzX2dl dF9hZGFwdGUoKQo+PiAgICBpZiAoV0FSTl9PTighaW50ZWxfZ21idXNfaXNfdmFsaWRfcGluKGRl dl9wcml2LCBwaW4pKSkKPj4gICAgICAgICAgICAgICAgICByZXR1cm4gTlVMTDsKPj4gCj4+Pgo+ Pj4gVGhhbmtzLAo+Pj4gU2hhb2JvCj4+PiBPbiAzLzE4LzE5IDU6MjYgUE0sIFJvZHJpZ28gVml2 aSB3cm90ZToKPj4+PiBIaSBTaGFvYm8sCj4+Pj4KPj4+PiBuIE1vbiwgTWFyIDE4LCAyMDE5IGF0 IDA1OjAxOjEwUE0gLTA2MDAsIFNoYW9ibyBIZSB3cm90ZToKPj4+Pj4gSGVsbG8gZXZlcnlvbmUs Cj4+Pj4+Cj4+Pj4+IE15IG5hbWUgaXMgU2hhb2JvIEhlIGFuZCBJIGFtIGEgZ3JhZHVhdGUgc3R1 ZGVudCBhdCBVbml2ZXJzaXR5IG9mIFV0YWguIEkgYW0KPj4+Pj4gdXNpbmcgYSBzdGF0aWMgYW5h bHlzaXMgdG9vbCB0byBzZWFyY2ggZm9yIG51bGwgcG9pbnRlciBkZXJlZmVyZW5jZXMgYW5kCj4+ Pj4+IGNhbWUgYWNyb3NzIGEgcG90ZW50aWFsbHkgaW52YWxpZCBtZW1vcnkgYWNjZXNzIGluIHRo ZSBmaWxlCj4+Pj4+IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NydC5jOiBpbiBmdW5jdGlv biBgaW50ZWxfY3J0X2RldGVjdF9kZGNgLAo+Pj4+PiBmdW5jdGlvbiBgaW50ZWxfZ21idXNfZ2V0 X2FkYXB0ZXJgIGNhbiByZXR1cm4gYSBOVUxMIHBvaW50ZXIgd2hpY2ggaXMKPj4+Pgo+Pj4+IGlm IHRoaXMgaGFwcGVucyB3ZSd2ZSBkb25lIGEgdGVycmlibGUgam9iIG9uIGRlZmluaW5nIHRoZSBw bGF0Zm9ybS4uLgo+Pj4+Cj4+Pj4+IGRlcmVmZXJlbmNlZCBieSB0aGUgY2FsbCB0byBgZHJtX2dl dF9lZGlkYCBvciBgaW50ZWxfZ21idXNfaXNfZm9yY2VkX2JpdGAuCj4+Pj4KPj4+PiBidXQgaXQg c2VlbXMgeW91IGFyZSByaWdodC4uLiB0aGlzIHdpbGwgcmVhY2ggaTJjX3RyYW5zZmVyIGluIHRo ZSBlbmQKPj4+PiBhbmQgaXQgd2lsbCBicmVhayBldmVyeXRoaW5nIGFmdGVyIHdlIGdhdmUgdGhl IFdhcm5pbmcuLi4KPj4+Pgo+Pj4+PiBJdCBzZWVtcyB0aGF0IHRoZSByZXR1cm4gdmFsdWUgb2Yg YGludGVsX2dtYnVzX2dldF9hZGFwdGVyYCBpcyBuZXZlcgo+Pj4+PiBOVUxMLWNoZWNrZWQuIElm IHNvLCBpdCB3b3VsZCBiZSBiZXR0ZXIgdG8gcmVwbGFjZSB0aGUgYnJhbmNoIHRvIHJldHVybiBh Cj4+Pj4+IE5VTEwgcG9pbnRlciB3aXRoIHNvbWV0aGluZyBsaWtlIGBCVUdfT05gLgo+Pj4+Cj4+ Pj4gd2hhdCBhYm91dCBqdXN0IGFkZGluZyBpZiAoIWkyYykgcmV0dXJuIGZhbHNlCj4+Pj4gaW5z dGVhZCBvZiBCVUcuCj4+Pj4KPj4+PiBXZSBhbHJlYWR5IGhhdmUgdGhlIFdBUk4gdG8gZGVidWcg aWYgdGhpcyBjYXNlIGV2ZXIgaGFwcGVucy4KPj4+Pgo+Pj4+IFRoYW5rcywKPj4+PiBSb2RyaWdv Lgo+Pj4+Cj4+Pj4+Cj4+Pj4+IFBsZWFzZSBsZXQgbWUga25vdyBpZiBpdCBtYWtlcyBzZW5zZS4g SSBhbSBsb29raW5nIGZvcndhcmQgdG8geW91ciByZXBseS4KPj4+Pj4KPj4+Pj4gQmVzdCwKPj4+ Pj4gU2hhb2JvCgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIEdyYXBoaWNzIENl bnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRl bC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=