From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: Clang warning in drivers/gpu/drm/i915/i915_debugfs.c Date: Tue, 15 Jan 2019 12:53:44 +0200 Message-ID: <87won65gzr.fsf@intel.com> References: <20190108191314.GA25250@flashbox> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190108191314.GA25250@flashbox> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Nathan Chancellor , Manasi Navare , Rodrigo Vivi Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCAwOCBKYW4gMjAxOSwgTmF0aGFuIENoYW5jZWxsb3IgPG5hdGVjaGFuY2VsbG9yQGdt YWlsLmNvbT4gd3JvdGU6Cj4gSGkgYWxsLAo+Cj4gQ29tbWl0IGU4NDVmMDk5ZjFjNiAoImRybS9p OTE1L2RzYzogQWRkIFBlciBjb25uZWN0b3IgZGVidWdmcyBub2RlIGZvcgo+IERTQyBzdXBwb3J0 L2VuYWJsZSIpIGNhdXNlcyBhIENsYW5nIHdhcm5pbmc6Cj4KPiBkcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X2RlYnVnZnMuYzo0OTYxOjE3OiB3YXJuaW5nOiBhZGRyZXNzIG9mIGFycmF5ICdpbnRl bF9kcC0+ZHNjX2RwY2QnIHdpbGwgYWx3YXlzIGV2YWx1YXRlIHRvICd0cnVlJyBbLVdwb2ludGVy LWJvb2wtY29udmVyc2lvbl0KPiAgICAgICAgICAgICAgICAgaWYgKGludGVsX2RwLT5kc2NfZHBj ZCkKPiAgICAgICAgICAgICAgICAgfn4gIH5+fn5+fn5+fn5efn5+fn5+fgo+IDEgd2FybmluZyBn ZW5lcmF0ZWQuCj4KPiBEaWQgeW91IG1lYW4gdG8gZGVyZWZlcmVuY2UgaXQgb3Igc2hvdWxkIHRo YXQgcHJpbnQgc3RhdGVtZW50IGp1c3QKPiBhbHdheXMgc2hvdz8gSSBub3JtYWxseSB3b3VsZCBz ZW5kIGEgcGF0Y2ggbXlzZWxmIGJ1dCBzaW5jZSBJJ20gbm90Cj4gZmFtaWxpYXIgd2l0aCB0aGlz IGNvZGUsIEknZCByYXRoZXIgbm90IHNob290IGluIHRoZSBkYXJrIDopIGVzcGVjaWFsbHkKPiBz aW5jZSBpdCdzIGZvciBhIHRyaXZpYWwgbG9nZ2luZyBzdGF0ZW1lbnQuCgpGaXhlZCBieSBmZWQ4 NTY5MWI0MDggKCJkcm0vaTkxNTogRml4IHRoZSBzdGF0aWMgY29kZSBhbmFseXNpcyB3YXJuaW5n CmluIGRlYnVnZnMiKSwgdGhhbmtzIGZvciB0aGUgcmVwb3J0ICYgcmV2aWV3IG9uIHRoYXQgb25l LgoKQlIsCkphbmkuCgoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBHcmFwaGlj cyBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23CDBC43387 for ; Tue, 15 Jan 2019 10:51:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E75D020651 for ; Tue, 15 Jan 2019 10:51:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729073AbfAOKv5 (ORCPT ); Tue, 15 Jan 2019 05:51:57 -0500 Received: from mga01.intel.com ([192.55.52.88]:41910 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728642AbfAOKv5 (ORCPT ); Tue, 15 Jan 2019 05:51:57 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jan 2019 02:51:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,481,1539673200"; d="scan'208";a="138413820" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.72.79]) by fmsmga001.fm.intel.com with ESMTP; 15 Jan 2019 02:51:54 -0800 From: Jani Nikula To: Nathan Chancellor , Manasi Navare , Rodrigo Vivi Cc: Lyude Paul , Joonas Lahtinen , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: Clang warning in drivers/gpu/drm/i915/i915_debugfs.c In-Reply-To: <20190108191314.GA25250@flashbox> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20190108191314.GA25250@flashbox> Date: Tue, 15 Jan 2019 12:53:44 +0200 Message-ID: <87won65gzr.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 08 Jan 2019, Nathan Chancellor wrote: > Hi all, > > Commit e845f099f1c6 ("drm/i915/dsc: Add Per connector debugfs node for > DSC support/enable") causes a Clang warning: > > drivers/gpu/drm/i915/i915_debugfs.c:4961:17: warning: address of array 'intel_dp->dsc_dpcd' will always evaluate to 'true' [-Wpointer-bool-conversion] > if (intel_dp->dsc_dpcd) > ~~ ~~~~~~~~~~^~~~~~~~ > 1 warning generated. > > Did you mean to dereference it or should that print statement just > always show? I normally would send a patch myself but since I'm not > familiar with this code, I'd rather not shoot in the dark :) especially > since it's for a trivial logging statement. Fixed by fed85691b408 ("drm/i915: Fix the static code analysis warning in debugfs"), thanks for the report & review on that one. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center