From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 0/7] drm: KMS cleanup remove drm_mode_object dependency Date: Wed, 19 Dec 2018 15:07:48 +0200 Message-ID: <87woo5vf4r.fsf@intel.com> References: <20181218133749.h4bnf5n5ljsmr2kz@smtp.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6C56B6EF5D for ; Wed, 19 Dec 2018 13:06:23 +0000 (UTC) In-Reply-To: <20181218133749.h4bnf5n5ljsmr2kz@smtp.gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Shayenne Moura , Maarten Lankhorst , Maxime Ripard , Sean Paul , David Airlie Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCAxOCBEZWMgMjAxOCwgU2hheWVubmUgTW91cmEgPHNoYXllbm5lbHV6bW91cmFAZ21h aWwuY29tPiB3cm90ZToKPiBUaGlzIHBhdGNoIHNlcmllIHJlbW92ZXMgZHJtX21vZGVfb2JqZWN0 IGRlcGVuZGVuY3kgZnJvbSAKPiBkcm1fZGlzcGxheV9tb2RlIHN0cnVjdC4gVGhpcyBpcyBwYXJ0 IG9mIEtNUyBjbGVhbnVwLiAgCgpGb3IgZnV0dXJlIHJlZmVyZW5jZToKClBsZWFzZSB1c2UgZ2l0 LXNlbmQtZW1haWwgb3IgZml4IHRoZSBtYWlsIHRocmVhZGluZyBvdGhlcndpc2UuIFBhdGNoZXMK MS03IHNob3VsZCBiZSBpbiByZXBseSB0byB0aGUgY292ZXIgbGV0dGVyLgoKUGxlYXNlIGp1c3Rp ZnkgdGhlIGNoYW5nZXMgaW4gdGhlIGNvbW1pdCBtZXNzYWdlcy4gWW91ciBjdXJyZW50IGNvbW1p dAptZXNzYWdlcyBmb2N1cyBvbiAqd2hhdCogaXMgYmVpbmcgZG9uZSwgd2hpY2ggaXMgZmFpcmx5 IG9idmlvdXMgZnJvbSB0aGUKY2hhbmdlcyB0aGVtc2VsdmVzLiBQbGVhc2UgdHJ5IHRvIGRlc2Ny aWJlICp3aHkqIHRoaXMgaXMgYmVpbmcKZG9uZS4gVGhhdCdzIG1vcmUgaW1wb3J0YW50IGZvciBw b3N0ZXJpdHkuIChJbiB0aGlzIGNhc2UsIGl0J3MgYmFzaWNhbGx5CmV4cGxhaW5lZCBpbiB0aGUg RklYTUUgY29tbWVudCBiZWluZyByZW1vdmVkIGluIHBhdGNoIDcsIGFzIHdlbGwgYXMKRG9jdW1l bnRhdGlvbi9ncHUvdG9kby5yc3QuKQoKQlIsCkphbmkuCgoKPgo+IFNoYXllbm5lIE1vdXJhICg3 KToKPiAgIGRybTogbXNtOiBEZWxldGUgYmFzZS5pZCBwcmludHMKPiAgIGRybTogUmVtb3ZlIHVz ZSBvZiBkcm1fbW9kZV9vYmplY3QKPiAgIGRybTogb21hcGRybTogRGVsZXRlIGJhc2UuaWQgcHJp bnRzCj4gICBkcm06IGk5MTU6IERlbGV0ZSBiYXNlLmlkIHByaW50cyAKPiAgIGRybTogc3RpOiBE ZWxldGUgYmFzZS5pZCBwcmludHMKPiAgIGRybTogbWVzb246IERlbGV0ZSBiYXNlLmlkIHByaW50 cwo+ICAgZHJtOiBDb21wbGV0ZSByZW1vdmUgZHJtX21vZGVfb2JqZWN0IGRlcGVuZGVuY3kKPgo+ ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2NydGNfaGVscGVyLmMgICAgICAgICAgICAgICAgIHwgIDUg KystLS0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9tb2Rlcy5jICAgICAgICAgICAgICAgICAgICAg ICB8ICA5IC0tLS0tLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYyAg ICAgICAgICAgICAgIHwgIDQgKystLQo+ICBkcml2ZXJzL2dwdS9kcm0vbWVzb24vbWVzb25fZHdf aGRtaS5jICAgICAgICAgICAgIHwgIDkgKysrKy0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9tc20v ZGlzcC9tZHA0L21kcDRfY3J0Yy5jICAgICAgICAgfCAgNCArKy0tCj4gIGRyaXZlcnMvZ3B1L2Ry bS9tc20vZGlzcC9tZHA0L21kcDRfZHNpX2VuY29kZXIuYyAgfCAgNCArKy0tCj4gIGRyaXZlcnMv Z3B1L2RybS9tc20vZGlzcC9tZHA0L21kcDRfZHR2X2VuY29kZXIuYyAgfCAgNCArKy0tCj4gIGRy aXZlcnMvZ3B1L2RybS9tc20vZGlzcC9tZHA0L21kcDRfbGNkY19lbmNvZGVyLmMgfCAgNCArKy0t Cj4gIGRyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9tZHA1L21kcDVfY21kX2VuY29kZXIuYyAgfCAg NCArKy0tCj4gIGRyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9tZHA1L21kcDVfY3J0Yy5jICAgICAg ICAgfCAgNCArKy0tCj4gIGRyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9tZHA1L21kcDVfZW5jb2Rl ci5jICAgICAgfCAgNCArKy0tCj4gIGRyaXZlcnMvZ3B1L2RybS9tc20vZHNpL2RzaV9tYW5hZ2Vy LmMgICAgICAgICAgICAgfCAgNCArKy0tCj4gIGRyaXZlcnMvZ3B1L2RybS9tc20vZWRwL2VkcF9i cmlkZ2UuYyAgICAgICAgICAgICAgfCAgNCArKy0tCj4gIGRyaXZlcnMvZ3B1L2RybS9vbWFwZHJt L29tYXBfY29ubmVjdG9yLmMgICAgICAgICAgfCAgNCArKy0tCj4gIGRyaXZlcnMvZ3B1L2RybS9v bWFwZHJtL29tYXBfY3J0Yy5jICAgICAgICAgICAgICAgfCAgNCArKy0tCj4gIGRyaXZlcnMvZ3B1 L2RybS9zdGkvc3RpX2NydGMuYyAgICAgICAgICAgICAgICAgICAgfCAgNCArKy0tCj4gIGluY2x1 ZGUvZHJtL2RybV9tb2Rlcy5oICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAxMCArKysrLS0t LS0tCj4gIDE3IGZpbGVzIGNoYW5nZWQsIDM2IGluc2VydGlvbnMoKyksIDQ5IGRlbGV0aW9ucygt KQoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBHcmFwaGljcyBDZW50ZXIKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1h aWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C46FC43387 for ; Wed, 19 Dec 2018 13:06:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 462B92133F for ; Wed, 19 Dec 2018 13:06:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728407AbeLSNGX (ORCPT ); Wed, 19 Dec 2018 08:06:23 -0500 Received: from mga17.intel.com ([192.55.52.151]:28501 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727924AbeLSNGX (ORCPT ); Wed, 19 Dec 2018 08:06:23 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Dec 2018 05:06:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,372,1539673200"; d="scan'208";a="131254901" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.72.61]) by fmsmga001.fm.intel.com with ESMTP; 19 Dec 2018 05:06:20 -0800 From: Jani Nikula To: Shayenne Moura , Maarten Lankhorst , Maxime Ripard , Sean Paul , David Airlie Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 0/7] drm: KMS cleanup remove drm_mode_object dependency In-Reply-To: <20181218133749.h4bnf5n5ljsmr2kz@smtp.gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20181218133749.h4bnf5n5ljsmr2kz@smtp.gmail.com> Date: Wed, 19 Dec 2018 15:07:48 +0200 Message-ID: <87woo5vf4r.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 18 Dec 2018, Shayenne Moura wrote: > This patch serie removes drm_mode_object dependency from > drm_display_mode struct. This is part of KMS cleanup. For future reference: Please use git-send-email or fix the mail threading otherwise. Patches 1-7 should be in reply to the cover letter. Please justify the changes in the commit messages. Your current commit messages focus on *what* is being done, which is fairly obvious from the changes themselves. Please try to describe *why* this is being done. That's more important for posterity. (In this case, it's basically explained in the FIXME comment being removed in patch 7, as well as Documentation/gpu/todo.rst.) BR, Jani. > > Shayenne Moura (7): > drm: msm: Delete base.id prints > drm: Remove use of drm_mode_object > drm: omapdrm: Delete base.id prints > drm: i915: Delete base.id prints > drm: sti: Delete base.id prints > drm: meson: Delete base.id prints > drm: Complete remove drm_mode_object dependency > > drivers/gpu/drm/drm_crtc_helper.c | 5 ++--- > drivers/gpu/drm/drm_modes.c | 9 --------- > drivers/gpu/drm/i915/i915_debugfs.c | 4 ++-- > drivers/gpu/drm/meson/meson_dw_hdmi.c | 9 ++++----- > drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c | 4 ++-- > drivers/gpu/drm/msm/disp/mdp4/mdp4_dsi_encoder.c | 4 ++-- > drivers/gpu/drm/msm/disp/mdp4/mdp4_dtv_encoder.c | 4 ++-- > drivers/gpu/drm/msm/disp/mdp4/mdp4_lcdc_encoder.c | 4 ++-- > drivers/gpu/drm/msm/disp/mdp5/mdp5_cmd_encoder.c | 4 ++-- > drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 4 ++-- > drivers/gpu/drm/msm/disp/mdp5/mdp5_encoder.c | 4 ++-- > drivers/gpu/drm/msm/dsi/dsi_manager.c | 4 ++-- > drivers/gpu/drm/msm/edp/edp_bridge.c | 4 ++-- > drivers/gpu/drm/omapdrm/omap_connector.c | 4 ++-- > drivers/gpu/drm/omapdrm/omap_crtc.c | 4 ++-- > drivers/gpu/drm/sti/sti_crtc.c | 4 ++-- > include/drm/drm_modes.h | 10 ++++------ > 17 files changed, 36 insertions(+), 49 deletions(-) -- Jani Nikula, Intel Open Source Graphics Center