All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Marcin Niestrój" <m.niestroj@grinn-global.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] configs/chiliboard: remove explicit getty port
Date: Fri, 23 Nov 2018 11:12:57 +0100	[thread overview]
Message-ID: <87wop4w192.fsf@grinn-global.com> (raw)
In-Reply-To: <66d34c66-c928-e00a-d59a-e09553fc7638@mind.be>

Hi Arnout,

Arnout Vandecappelle <arnout@mind.be> writes:

> On 21/11/2018 22:01, Marcin Niestroj wrote:
>> Using default value (console) works well, so there is no reason to set
>> tty explicitly. Additionally after selecting newer kernels (tested
>> with 4.19 and 4.20-rc3) ttyO0 no longer works due to missing device
>> node.
>
>  Actually, does it still work with the 4.16 kernel? IIRC the ttyO were replaced
> by the standard ttyS ages ago (like, 3.18 or something like that). If it doesn't
> work with the 4.16 kernel, it should be applied to master.
>

Yes, it still works with 4.16. There are /dev/ttyS[0-5] and /dev/ttyO0
nodes. In case of 4.19 and 4.20 there is no /dev/ttyO0 anymore, but I
did not get into the exact reason what changed. I just checked how other
boards configure getty in Buildroot and it turns out most of them leave
the default value.

>  Anyway,
>
> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

Thanks!

Regards,
Marcin

>
>  Regards,
>  Arnout
>
>>
>> Signed-off-by: Marcin Niestroj <m.niestroj@grinn-global.com>
>> ---
>>  configs/grinn_chiliboard_defconfig | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/configs/grinn_chiliboard_defconfig b/configs/grinn_chiliboard_defconfig
>> index 81d7bae911..84f24e1cc4 100644
>> --- a/configs/grinn_chiliboard_defconfig
>> +++ b/configs/grinn_chiliboard_defconfig
>> @@ -1,7 +1,6 @@
>>  BR2_arm=y
>>  BR2_cortex_a8=y
>>  BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_16=y
>> -BR2_TARGET_GENERIC_GETTY_PORT="ttyO0"
>>  BR2_SYSTEM_DHCP="eth0"
>>  BR2_ROOTFS_POST_IMAGE_SCRIPT="board/grinn/chiliboard/post-image.sh"
>>  BR2_LINUX_KERNEL=y
>>

  reply	other threads:[~2018-11-23 10:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-21 21:01 [Buildroot] [PATCH] configs/chiliboard: remove explicit getty port Marcin Niestroj
2018-11-22 22:36 ` Arnout Vandecappelle
2018-11-23 10:12   ` Marcin Niestrój [this message]
2018-12-09 20:55 ` Peter Korsgaard
2018-12-10 11:12   ` Marcin Niestrój

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wop4w192.fsf@grinn-global.com \
    --to=m.niestroj@grinn-global.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.