From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@linux.intel.com>
Subject: Re: [RFC 2/8] drm/i915: Use the ddi_ports info to kill
 ugly CNL_WITH_PORT_F.
Date: Fri, 19 Oct 2018 10:39:46 +0300
Message-ID: <87woqegzb1.fsf@intel.com>
References: <20181018233447.5187-1-rodrigo.vivi@intel.com>
 <20181018233447.5187-3-rodrigo.vivi@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 9D6E06E20C
 for <intel-gfx@lists.freedesktop.org>; Fri, 19 Oct 2018 07:40:07 +0000 (UTC)
In-Reply-To: <20181018233447.5187-3-rodrigo.vivi@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: intel-gfx@lists.freedesktop.org
Cc: lucas.demarchi@intel.com, Rodrigo Vivi <rodrigo.vivi@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

T24gVGh1LCAxOCBPY3QgMjAxOCwgUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29t
PiB3cm90ZToKPiBOb3cgdGhhdCB3ZSBoYXZlIHRoZSBudW1iZXIgb2YgZGRpIHBvcnRzIGluZm9y
bWF0aW9uIGF2YWlsYWJsZQo+IGxldCdzIHVzZSBpdCBpbnN0ZWFkIG9mIHRoYXQgdWdseSBwbGF0
Zm9ybSBtYWNyby4KPgo+IFNpZ25lZC1vZmYtYnk6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZp
QGludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuYyAgICAg
ICAgIHwgMTAgKysrKysrKysrKwo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oICAg
ICAgICAgfCAgMiAtLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jICAgICAgICAg
fCAgNSArKy0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jICAgICAgICAgfCAg
MiArLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ob3RwbHVnLmMgICAgfCAgMiArLQo+
ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ydW50aW1lX3BtLmMgfCAgMiArLQo+ICA2IGZp
bGVzIGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0t
Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuYyBiL2RyaXZlcnMvZ3B1L2RybS9p
OTE1L2k5MTVfZHJ2LmMKPiBpbmRleCBiYWFjMzVmNjk4ZjkuLjgzYWIzMjVjNjY3NSAxMDA2NDQK
PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jCj4gKysrIGIvZHJpdmVycy9n
cHUvZHJtL2k5MTUvaTkxNV9kcnYuYwo+IEBAIC0yMzksNiArMjM5LDE0IEBAIGludGVsX3ZpcnRf
ZGV0ZWN0X3BjaChjb25zdCBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIAly
ZXR1cm4gaWQ7Cj4gIH0KPiAgCj4gK3N0YXRpYyB2b2lkIGludGVsX2FkanVzdF9za3VzX2RpZmZl
cmVuY2VzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiArewo+ICsJLyogU29t
ZSBDYW5ub25sYWtlIFNLVXMgaGF2ZSBQb3J0IEYgKi8KPiArCWlmIChJU19DQU5OT05MQUtFKGRl
dl9wcml2KSAmJgo+ICsJICAgIChJTlRFTF9ERVZJRChkZXZfcHJpdikgJiAweDAwMDQpID09IDB4
MDAwNCkKPiArCQlta3dyaXRlX2RldmljZV9pbmZvKGRldl9wcml2KS0+ZGRpX3BvcnRzID0gNjsK
PiArfQoKSSdkIGxpa2UgcmVkdWNlIHRoZSBhbW91bnQgb2YgZGV2aWNlIGluZm8gc3R1ZmYgd2Ug
YWRqdXN0IGF0IHByb2JlLCBub3QKaW5jcmVhc2UuCgpMb25nIHRlcm0sIEknZCBsaWtlIHRvIG1h
a2UgZGV2X3ByaXYtPmluZm8gYSBjb25zdCBwb2ludGVyIHRvIHRoZSBjb25zdApkYXRhIGluIGk5
MTVfcGNpLmMsIGFuZCBtYWtlIGl0IHRydWx5IGltbXV0YWJsZS4gV2UgY291bGQgaGF2ZSBhbgph
ZGRpdGlvbmFsIHJ1bnRpbWUgZGV2aWNlIGluZm8gdG8gY29tcGxlbWVudCB0aGF0LCBidXQgdGhp
cyBhcHByb2FjaApjYWxscyBmb3IgYSBtb3JlIGNvbmNyZXRlIHNwbGl0IGluIGNvbnN0IGFuZCBu
b24tY29uc3QgZGF0YSwgbm90ICJtb3N0bHkKY29uc3QgYnV0IHNvbWV0aW1lcyBtdXRhYmxlIi4K
CkkgdGhpbmsgSSd2ZSBjaGF0dGVkIGFib3V0IHRoaXMgd2l0aCBDaHJpcyB0b28uCgpCUiwKSmFu
aS4KCj4gKwo+ICBzdGF0aWMgdm9pZCBpbnRlbF9kZXRlY3RfcGNoKHN0cnVjdCBkcm1faTkxNV9w
cml2YXRlICpkZXZfcHJpdikKPiAgewo+ICAJc3RydWN0IHBjaV9kZXYgKnBjaCA9IE5VTEw7Cj4g
QEAgLTkwNCw2ICs5MTIsOCBAQCBzdGF0aWMgaW50IGk5MTVfZHJpdmVyX2luaXRfZWFybHkoc3Ry
dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJaWYgKHJldCA8IDApCj4gIAkJZ290
byBlcnJfd29ya3F1ZXVlczsKPiAgCj4gKwlpbnRlbF9hZGp1c3Rfc2t1c19kaWZmZXJlbmNlcyhk
ZXZfcHJpdik7Cj4gKwo+ICAJLyogVGhpcyBtdXN0IGJlIGNhbGxlZCBiZWZvcmUgYW55IGNhbGxz
IHRvIEhBU19QQ0hfKiAqLwo+ICAJaW50ZWxfZGV0ZWN0X3BjaChkZXZfcHJpdik7Cj4gIAo+IGRp
ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oIGIvZHJpdmVycy9ncHUv
ZHJtL2k5MTUvaTkxNV9kcnYuaAo+IGluZGV4IDdhZDIzMjg0OTI2OC4uOTllNDJkZjc5ZWQ4IDEw
MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiArKysgYi9kcml2
ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gQEAgLTI0ODUsOCArMjQ4NSw2IEBAIGludGVs
X2luZm8oY29uc3Qgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJCQkJIChk
ZXZfcHJpdiktPmluZm8uZ3QgPT0gMikKPiAgI2RlZmluZSBJU19DRkxfR1QzKGRldl9wcml2KQko
SVNfQ09GRkVFTEFLRShkZXZfcHJpdikgJiYgXAo+ICAJCQkJIChkZXZfcHJpdiktPmluZm8uZ3Qg
PT0gMykKPiAtI2RlZmluZSBJU19DTkxfV0lUSF9QT1JUX0YoZGV2X3ByaXYpICAgKElTX0NBTk5P
TkxBS0UoZGV2X3ByaXYpICYmIFwKPiAtCQkJCQkoSU5URUxfREVWSUQoZGV2X3ByaXYpICYgMHgw
MDA0KSA9PSAweDAwMDQpCj4gIAo+ICAjZGVmaW5lIElTX0FMUEhBX1NVUFBPUlQoaW50ZWxfaW5m
bykgKChpbnRlbF9pbmZvKS0+aXNfYWxwaGFfc3VwcG9ydCkKPiAgCj4gZGlmZiAtLWdpdCBhL2Ry
aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1
X2lycS5jCj4gaW5kZXggNWQxZjUzNzIzMzg4Li42M2Q2NzZkZTM4NDAgMTAwNjQ0Cj4gLS0tIGEv
ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p
OTE1L2k5MTVfaXJxLmMKPiBAQCAtMjc4Miw4ICsyNzgyLDcgQEAgZ2VuOF9kZV9pcnFfaGFuZGxl
cihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIHUzMiBtYXN0ZXJfY3RsKQo+ICAJ
CQlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+PSAxMSkKPiAgCQkJCXRtcF9tYXNrIHw9IElDTF9B
VVhfQ0hBTk5FTF9FOwo+ICAKPiAtCQkJaWYgKElTX0NOTF9XSVRIX1BPUlRfRihkZXZfcHJpdikg
fHwKPiAtCQkJICAgIElOVEVMX0dFTihkZXZfcHJpdikgPj0gMTEpCj4gKwkJCWlmIChJTlRFTF9J
TkZPKGRldl9wcml2KS0+ZGRpX3BvcnRzID49IDYpCj4gIAkJCQl0bXBfbWFzayB8PSBDTkxfQVVY
X0NIQU5ORUxfRjsKPiAgCj4gIAkJCWlmIChpaXIgJiB0bXBfbWFzaykgewo+IEBAIC00MjIwLDcg
KzQyMTksNyBAQCBzdGF0aWMgdm9pZCBnZW44X2RlX2lycV9wb3N0aW5zdGFsbChzdHJ1Y3QgZHJt
X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIAlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+PSAx
MSkKPiAgCQlkZV9wb3J0X21hc2tlZCB8PSBJQ0xfQVVYX0NIQU5ORUxfRTsKPiAgCj4gLQlpZiAo
SVNfQ05MX1dJVEhfUE9SVF9GKGRldl9wcml2KSB8fCBJTlRFTF9HRU4oZGV2X3ByaXYpID49IDEx
KQo+ICsJaWYgKElOVEVMX0lORk8oZGV2X3ByaXYpLT5kZGlfcG9ydHMgPj0gNikKPiAgCQlkZV9w
b3J0X21hc2tlZCB8PSBDTkxfQVVYX0NIQU5ORUxfRjsKPiAgCj4gIAlkZV9waXBlX2VuYWJsZXMg
PSBkZV9waXBlX21hc2tlZCB8IEdFTjhfUElQRV9WQkxBTksgfAo+IGRpZmYgLS1naXQgYS9kcml2
ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf
ZHAuYwo+IGluZGV4IDMzODRhOWJiZGFmZC4uMGVhMDQxNGNjZWY0IDEwMDY0NAo+IC0tLSBhL2Ry
aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkx
NS9pbnRlbF9kcC5jCj4gQEAgLTQwMiw3ICs0MDIsNyBAQCBzdGF0aWMgaW50IGNubF9tYXhfc291
cmNlX3JhdGUoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkKPiAgCQlyZXR1cm4gNTQwMDAwOwo+
ICAKPiAgCS8qIEZvciB0aGlzIFNLVSA4LjFHIGlzIHN1cHBvcnRlZCBpbiBhbGwgcG9ydHMgKi8K
PiAtCWlmIChJU19DTkxfV0lUSF9QT1JUX0YoZGV2X3ByaXYpKQo+ICsJaWYgKElOVEVMX0lORk8o
ZGV2X3ByaXYpLT5kZGlfcG9ydHMgPT0gNikKPiAgCQlyZXR1cm4gODEwMDAwOwo+ICAKPiAgCS8q
IEZvciBvdGhlciBTS1VzLCBtYXggcmF0ZSBvbiBwb3J0cyBBIGFuZCBEIGlzIDUuNEcgKi8KPiBk
aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfaG90cGx1Zy5jIGIvZHJpdmVy
cy9ncHUvZHJtL2k5MTUvaW50ZWxfaG90cGx1Zy5jCj4gaW5kZXggNjQ4YTEzYzYwNDNjLi4wNWQx
ZmFmNzcwNDggMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfaG90cGx1
Zy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfaG90cGx1Zy5jCj4gQEAgLTEw
MSw3ICsxMDEsNyBAQCBlbnVtIGhwZF9waW4gaW50ZWxfaHBkX3Bpbl9kZWZhdWx0KHN0cnVjdCBk
cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCWNhc2UgUE9SVF9FOgo+ICAJCXJldHVybiBI
UERfUE9SVF9FOwo+ICAJY2FzZSBQT1JUX0Y6Cj4gLQkJaWYgKElTX0NOTF9XSVRIX1BPUlRfRihk
ZXZfcHJpdikpCj4gKwkJaWYgKElTX0dFTjEwKGRldl9wcml2KSkKPiAgCQkJcmV0dXJuIEhQRF9Q
T1JUX0U7Cj4gIAkJcmV0dXJuIEhQRF9QT1JUX0Y7Cj4gIAlkZWZhdWx0Ogo+IGRpZmYgLS1naXQg
YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ydW50aW1lX3BtLmMgYi9kcml2ZXJzL2dwdS9k
cm0vaTkxNS9pbnRlbF9ydW50aW1lX3BtLmMKPiBpbmRleCAzMWE0OWJkY2YxOTMuLjgwZTE0YmUx
MTI3OSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ydW50aW1lX3Bt
LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ydW50aW1lX3BtLmMKPiBAQCAt
MzA5OSw3ICszMDk5LDcgQEAgaW50IGludGVsX3Bvd2VyX2RvbWFpbnNfaW5pdChzdHJ1Y3QgZHJt
X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIAkJICogdGltZW91dHMsIGxldHMgcmVtb3ZlIHRo
ZW0gZnJvbSB0aGUgbGlzdAo+ICAJCSAqIGZvciB0aGUgU0tVcyB3aXRob3V0IHBvcnQgRi4KPiAg
CQkgKi8KPiAtCQlpZiAoIUlTX0NOTF9XSVRIX1BPUlRfRihkZXZfcHJpdikpCj4gKwkJaWYgKElO
VEVMX0lORk8oZGV2X3ByaXYpLT5kZGlfcG9ydHMgPT0gNSkKPiAgCQkJcG93ZXJfZG9tYWlucy0+
cG93ZXJfd2VsbF9jb3VudCAtPSAyOwo+ICAKPiAgCX0gZWxzZSBpZiAoSVNfQlJPWFRPTihkZXZf
cHJpdikpIHsKCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgR3JhcGhpY3MgQ2Vu
dGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVs
LWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov
L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=