From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/3] drm/i915/execlists: Reset CSB pointers on canceling requests (wedging)
Date: Fri, 14 Sep 2018 17:17:43 +0300 [thread overview]
Message-ID: <87worouprs.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20180914080017.30308-3-chris@chris-wilson.co.uk>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> The prior assumption was that we did not need to reset the CSB on
> wedging when cancelling the outstanding requests as it would be cleaned
> up in the subsequent reset prior to restarting the GPU. However, what
> was not accounted for was that in performing the reset, we would try to
'performing the reset' could be 'preparing engine for reset'
> process the outstanding CSB entries. If the GPU happened to complete a
> CS event just as we were performing the cancellation of requests, that
> event would be kept in the CSB until the reset -- but our bookkeeping
> was cleared, causing confusion when trying to complete the CS event.
>
> v2: Use a sanitize on unwedge to avoid interfering with eio suspend
> (where we intentionally disable GPU reset).
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107925
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
I was glad to notice that there were quality comments
on resetting/clearing the csb/ports.
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-09-14 14:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-14 8:00 [PATCH 1/3] drm/i915: Limit the backpressure for i915_request allocation Chris Wilson
2018-09-14 8:00 ` [PATCH 2/3] drm/i915: Flush the tasklet when checking for idle Chris Wilson
2018-09-14 10:21 ` Tvrtko Ursulin
2018-09-14 11:40 ` Chris Wilson
2018-09-14 8:00 ` [PATCH 3/3] drm/i915/execlists: Reset CSB pointers on canceling requests (wedging) Chris Wilson
2018-09-14 14:17 ` Mika Kuoppala [this message]
2018-09-14 10:02 ` ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Limit the backpressure for i915_request allocation Patchwork
2018-09-14 10:09 ` [PATCH 1/3] " Tvrtko Ursulin
2018-09-14 11:30 ` ✓ Fi.CI.IGT: success for series starting with [1/3] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87worouprs.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.