From mboxrd@z Thu Jan  1 00:00:00 1970
From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>
Subject: Re: [PATCH v2 iproute2-next] sch_cake: Make gso-splitting configurable
Date: Mon, 13 Aug 2018 18:44:55 +0200
Message-ID: <87wosucj20.fsf@toke.dk>
References: <20180813113617.13073-1-toke@toke.dk> <f58a05f6-a544-c9b3-7ef7-ae83f37a682e@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: netdev@vger.kernel.org, Dave Taht <dave.taht@gmail.com>
To: David Ahern <dsahern@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail.toke.dk ([52.28.52.200]:33025 "EHLO mail.toke.dk"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1728293AbeHMT1x (ORCPT <rfc822;netdev@vger.kernel.org>);
        Mon, 13 Aug 2018 15:27:53 -0400
In-Reply-To: <f58a05f6-a544-c9b3-7ef7-ae83f37a682e@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

David Ahern <dsahern@gmail.com> writes:

> On 8/13/18 5:36 AM, Toke H=C3=B8iland-J=C3=B8rgensen wrote:
>> This patch makes sch_cake's gso/gro splitting configurable
>> from userspace.
>>=20
>> To disable breaking apart superpackets in sch_cake:
>>=20
>> tc qdisc replace dev whatever root cake no-split-gso
>>=20
>> to enable:
>>=20
>> tc qdisc replace dev whatever root cake split-gso
>>=20
>> Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen <toke@toke.dk>
>> Signed-off-by: Dave Taht <dave.taht@gmail.com>
>> ---
>
> applied to iproute2-next. Thanks

Great, thanks :)

> I think you also need to display it if the attribute is returned.

We already print 'split-gso' when it is set; this was previously decided
by the kernel, this change just makes it user-configurable...

-Toke