From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f72.google.com (mail-pl0-f72.google.com [209.85.160.72]) by kanga.kvack.org (Postfix) with ESMTP id C7FE36B000A for ; Thu, 19 Jul 2018 20:27:27 -0400 (EDT) Received: by mail-pl0-f72.google.com with SMTP id t19-v6so5841543plo.9 for ; Thu, 19 Jul 2018 17:27:27 -0700 (PDT) Received: from mga03.intel.com (mga03.intel.com. [134.134.136.65]) by mx.google.com with ESMTPS id f11-v6si464659pgk.403.2018.07.19.17.27.26 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Jul 2018 17:27:26 -0700 (PDT) From: "Huang\, Ying" Subject: Re: [PATCH v3 1/8] swap: Add comments to lock_cluster_or_swap_info() References: <20180719084842.11385-1-ying.huang@intel.com> <20180719084842.11385-2-ying.huang@intel.com> <20180719123908.GA28522@infradead.org> Date: Fri, 20 Jul 2018 08:27:22 +0800 In-Reply-To: <20180719123908.GA28522@infradead.org> (Christoph Hellwig's message of "Thu, 19 Jul 2018 05:39:08 -0700") Message-ID: <87wotqvjit.fsf@yhuang-dev.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ascii Sender: owner-linux-mm@kvack.org List-ID: To: Christoph Hellwig Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko , Johannes Weiner , Shaohua Li , Hugh Dickins , Minchan Kim , Rik van Riel , Dan Williams , Dave Hansen , Daniel Jordan Christoph Hellwig writes: > On Thu, Jul 19, 2018 at 04:48:35PM +0800, Huang Ying wrote: >> +/* >> + * Determine the locking method in use for this device. Return >> + * swap_cluster_info if SSD-style cluster-based locking is in place. >> + */ >> static inline struct swap_cluster_info *lock_cluster_or_swap_info( >> struct swap_info_struct *si, >> unsigned long offset) >> { >> struct swap_cluster_info *ci; >> >> + /* Try to use fine-grained SSD-style locking if available: */ > > Once you touch this are can you also please use standard two-tab > alignment for the spill-over function arguments: > > static inline struct swap_cluster_info *lock_cluster_or_swap_info( > struct swap_info_struct *si, unsigned long offset) Sure. Will change this in next version. Best Regards, Huang, Ying From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D618ECDE5F for ; Fri, 20 Jul 2018 00:27:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BE7022084E for ; Fri, 20 Jul 2018 00:27:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE7022084E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731304AbeGTBNC (ORCPT ); Thu, 19 Jul 2018 21:13:02 -0400 Received: from mga14.intel.com ([192.55.52.115]:35206 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730279AbeGTBNC (ORCPT ); Thu, 19 Jul 2018 21:13:02 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jul 2018 17:27:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,376,1526367600"; d="scan'208";a="58287692" Received: from yhuang-dev.sh.intel.com (HELO yhuang-dev) ([10.239.13.118]) by orsmga008.jf.intel.com with ESMTP; 19 Jul 2018 17:27:23 -0700 From: "Huang\, Ying" To: Christoph Hellwig Cc: Andrew Morton , , , Michal Hocko , "Johannes Weiner" , Shaohua Li , Hugh Dickins , Minchan Kim , Rik van Riel , Dan Williams , Dave Hansen , Daniel Jordan Subject: Re: [PATCH v3 1/8] swap: Add comments to lock_cluster_or_swap_info() References: <20180719084842.11385-1-ying.huang@intel.com> <20180719084842.11385-2-ying.huang@intel.com> <20180719123908.GA28522@infradead.org> Date: Fri, 20 Jul 2018 08:27:22 +0800 In-Reply-To: <20180719123908.GA28522@infradead.org> (Christoph Hellwig's message of "Thu, 19 Jul 2018 05:39:08 -0700") Message-ID: <87wotqvjit.fsf@yhuang-dev.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christoph Hellwig writes: > On Thu, Jul 19, 2018 at 04:48:35PM +0800, Huang Ying wrote: >> +/* >> + * Determine the locking method in use for this device. Return >> + * swap_cluster_info if SSD-style cluster-based locking is in place. >> + */ >> static inline struct swap_cluster_info *lock_cluster_or_swap_info( >> struct swap_info_struct *si, >> unsigned long offset) >> { >> struct swap_cluster_info *ci; >> >> + /* Try to use fine-grained SSD-style locking if available: */ > > Once you touch this are can you also please use standard two-tab > alignment for the spill-over function arguments: > > static inline struct swap_cluster_info *lock_cluster_or_swap_info( > struct swap_info_struct *si, unsigned long offset) Sure. Will change this in next version. Best Regards, Huang, Ying