From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com ([192.55.52.88]:29867 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751111AbeEUKUh (ORCPT ); Mon, 21 May 2018 06:20:37 -0400 From: Felipe Balbi To: Yoshihiro Shimoda Cc: "gregkh\@linuxfoundation.org" , "linux-usb\@vger.kernel.org" , "linux-renesas-soc\@vger.kernel.org" Subject: RE: [PATCH/RFC] usb: gadget: function: printer: avoid wrong list handling in printer_write() In-Reply-To: References: <1526632641-30086-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> <87r2m58pir.fsf@linux.intel.com> <87603h8mea.fsf@linux.intel.com> Date: Mon, 21 May 2018 13:18:50 +0300 Message-ID: <87wovx71md.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Yoshihiro Shimoda writes: > Hi, > >> From: Felipe Balbi, Sent: Monday, May 21, 2018 5:05 PM > >> seems like it would be better to just move this like before >> usb_ep_queue(): >>=20 >> modified drivers/usb/gadget/function/f_printer.c >> @@ -631,19 +631,19 @@ printer_write(struct file *fd, const char __user *= buf, size_t len, loff_t *ptr) >> return -EAGAIN; >> } >>=20 >> + list_add(&req->list, &dev->tx_reqs_active); >> + >> /* here, we unlock, and only unlock, to avoid deadlock. */ >> spin_unlock(&dev->lock); >> value =3D usb_ep_queue(dev->in_ep, req, GFP_ATOMIC); >> spin_lock(&dev->lock); >> if (value) { >> + list_del(&req->list); >> list_add(&req->list, &dev->tx_reqs); >> spin_unlock_irqrestore(&dev->lock, flags); >> mutex_unlock(&dev->lock_printer_io); >> return -EAGAIN; >> } >> - >> - list_add(&req->list, &dev->tx_reqs_active); >> - >> } >>=20 >> spin_unlock_irqrestore(&dev->lock, flags); >>=20 >> -- > > Thank you very much for your patch! This could resolve the issue. > So, should I submit this your patch as your author? you can send it with your authorship, it's totally fine :-) You can also add my: Acked-by: Felipe Balbi thanks =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlsCnQoACgkQzL64meEa mQYlYxAAlwvec3Hw7d32hm8/p++T7vYsoHvdwB/JbsadO2nmIQsQWSySsN3FKGzo CFLyC/uo7fz04I1oCkX++lPz5QL6xu36Ga4CW6uKAK5QwjFVXrgSOn+N2TV6sGeQ EFtWt4YncHheSbsu1qzO/F7c4b+NCBBRbco7OyjSFZJsc3JTmS1VtxqUQ0F0D7p/ mTgE5P79uCG/3e4GjdvPh4zqfDsizrDd6m16CzSwKvra9oITYlJNX5RhSFMwQkzh px4u9qzHiIlulUGtLBzK9Sg/dLmY42tfhYhNNwknhBaoBJ0L2BmDZ57UppGhGFhA kRshINr+gdT99QlvK9g2QXvJKnuRPiAyvDa5M9IV6BfWF/b2zb+h/5B3/Rfhk2GX 29PKPT8It8XxSTD2jS54MfUvNyN5oKaN5NCbIw/7hphyr+Ojow2PCJUpzPKi9it6 k+393woSdv1rgFwFiK7YmlU90zREkNvXFXwPpkQzdHONxkdWNhx/PTfSoOhc2FCg gFwRkOGlCG1+NIZp75NQxK9KNd7KXT9trvIQd85t/0oewVIWD3uTfzHIxPJlD4zx DicPjW6/Kg5Kv7dSeMAYzGwUcnvZP0VJUwSg/XrYsqcOpYNbELbzJx+LYtzVR+01 jDVBai7cIfMVaGdWgn1I25XOghaDxPFnNj1bdn47S3uaHfV0Fuc= =5Fsw -----END PGP SIGNATURE----- --=-=-=-- From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [PATCH/RFC] usb: gadget: function: printer: avoid wrong list handling in printer_write() From: Felipe Balbi Message-Id: <87wovx71md.fsf@linux.intel.com> Date: Mon, 21 May 2018 13:18:50 +0300 To: Yoshihiro Shimoda Cc: "gregkh@linuxfoundation.org" , "linux-usb@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" List-ID: SGksCgpZb3NoaWhpcm8gU2hpbW9kYSA8eW9zaGloaXJvLnNoaW1vZGEudWhAcmVuZXNhcy5jb20+ IHdyaXRlczoKPiBIaSwKPgo+PiBGcm9tOiBGZWxpcGUgQmFsYmksIFNlbnQ6IE1vbmRheSwgTWF5 IDIxLCAyMDE4IDU6MDUgUE0KPiA8c25pcD4KPj4gc2VlbXMgbGlrZSBpdCB3b3VsZCBiZSBiZXR0 ZXIgdG8ganVzdCBtb3ZlIHRoaXMgbGlrZSBiZWZvcmUKPj4gdXNiX2VwX3F1ZXVlKCk6Cj4+IAo+ PiBtb2RpZmllZCAgIGRyaXZlcnMvdXNiL2dhZGdldC9mdW5jdGlvbi9mX3ByaW50ZXIuYwo+PiBA QCAtNjMxLDE5ICs2MzEsMTkgQEAgcHJpbnRlcl93cml0ZShzdHJ1Y3QgZmlsZSAqZmQsIGNvbnN0 IGNoYXIgX191c2VyICpidWYsIHNpemVfdCBsZW4sIGxvZmZfdCAqcHRyKQo+PiAgCQkJcmV0dXJu IC1FQUdBSU47Cj4+ICAJCX0KPj4gCj4+ICsJCWxpc3RfYWRkKCZyZXEtPmxpc3QsICZkZXYtPnR4 X3JlcXNfYWN0aXZlKTsKPj4gKwo+PiAgCQkvKiBoZXJlLCB3ZSB1bmxvY2ssIGFuZCBvbmx5IHVu bG9jaywgdG8gYXZvaWQgZGVhZGxvY2suICovCj4+ICAJCXNwaW5fdW5sb2NrKCZkZXYtPmxvY2sp Owo+PiAgCQl2YWx1ZSA9IHVzYl9lcF9xdWV1ZShkZXYtPmluX2VwLCByZXEsIEdGUF9BVE9NSUMp Owo+PiAgCQlzcGluX2xvY2soJmRldi0+bG9jayk7Cj4+ICAJCWlmICh2YWx1ZSkgewo+PiArCQkJ bGlzdF9kZWwoJnJlcS0+bGlzdCk7Cj4+ICAJCQlsaXN0X2FkZCgmcmVxLT5saXN0LCAmZGV2LT50 eF9yZXFzKTsKPj4gIAkJCXNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJmRldi0+bG9jaywgZmxhZ3Mp Owo+PiAgCQkJbXV0ZXhfdW5sb2NrKCZkZXYtPmxvY2tfcHJpbnRlcl9pbyk7Cj4+ICAJCQlyZXR1 cm4gLUVBR0FJTjsKPj4gIAkJfQo+PiAtCj4+IC0JCWxpc3RfYWRkKCZyZXEtPmxpc3QsICZkZXYt PnR4X3JlcXNfYWN0aXZlKTsKPj4gLQo+PiAgCX0KPj4gCj4+ICAJc3Bpbl91bmxvY2tfaXJxcmVz dG9yZSgmZGV2LT5sb2NrLCBmbGFncyk7Cj4+IAo+PiAtLQo+Cj4gVGhhbmsgeW91IHZlcnkgbXVj aCBmb3IgeW91ciBwYXRjaCEgVGhpcyBjb3VsZCByZXNvbHZlIHRoZSBpc3N1ZS4KPiBTbywgc2hv dWxkIEkgc3VibWl0IHRoaXMgeW91ciBwYXRjaCBhcyB5b3VyIGF1dGhvcj8KCnlvdSBjYW4gc2Vu ZCBpdCB3aXRoIHlvdXIgYXV0aG9yc2hpcCwgaXQncyB0b3RhbGx5IGZpbmUgOi0pCgpZb3UgY2Fu IGFsc28gYWRkIG15OgoKQWNrZWQtYnk6IEZlbGlwZSBCYWxiaSA8ZmVsaXBlLmJhbGJpQGxpbnV4 LmludGVsLmNvbT4KCnRoYW5rcwo=