Re: [PATCH] drm/i915: Remove unused enable_cmd_parser modparam

[Jani Nikula <jani.nikula@linux.intel.com>]

On Thu, 17 May 2018, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> The command parser is feature complete, stable and required by
> userspace. In commit 41736a8e3331 ("drm/i915: Use the precomputed value
> for whether to enable command parsing") I accidentally removed control
> from the modparam, and as no one has complained, eemove the left
> over modparam completely!
>
> References: 41736a8e3331 ("drm/i915: Use the precomputed value for whether to enable command parsing")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>

Another one bites the dust!

Acked-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/gpu/drm/i915/i915_params.c | 3 ---
>  drivers/gpu/drm/i915/i915_params.h | 1 -
>  2 files changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
> index 66ea3552c63e..49fcc4679db6 100644
> --- a/drivers/gpu/drm/i915/i915_params.c
> +++ b/drivers/gpu/drm/i915/i915_params.c
> @@ -130,9 +130,6 @@ i915_param_named_unsafe(invert_brightness, int, 0600,
>  i915_param_named(disable_display, bool, 0400,
>  	"Disable display (default: false)");
>  
> -i915_param_named_unsafe(enable_cmd_parser, bool, 0400,
> -	"Enable command parsing (true=enabled [default], false=disabled)");
> -
>  i915_param_named(mmio_debug, int, 0600,
>  	"Enable the MMIO debug code for the first N failures (default: off). "
>  	"This may negatively affect performance.");
> diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
> index 6684025b7af8..aebe0469ddaa 100644
> --- a/drivers/gpu/drm/i915/i915_params.h
> +++ b/drivers/gpu/drm/i915/i915_params.h
> @@ -58,7 +58,6 @@ struct drm_printer;
>  	param(unsigned int, inject_load_failure, 0) \
>  	/* leave bools at the end to not create holes */ \
>  	param(bool, alpha_support, IS_ENABLED(CONFIG_DRM_I915_ALPHA_SUPPORT)) \
> -	param(bool, enable_cmd_parser, true) \
>  	param(bool, enable_hangcheck, true) \
>  	param(bool, fastboot, false) \
>  	param(bool, prefault_disable, false) \

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx