From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Martin Ågren" <martin.agren@gmail.com>,
"Git Mailing List" <git@vger.kernel.org>,
"Alexandre Julliard" <julliard@winehq.org>,
"Dorab Patel" <dorabpatel@gmail.com>,
"Eric Sunshine" <sunshine@sunshineco.com>,
"David Kågedal" <davidk@lysator.liu.se>
Subject: Re: [PATCH v2] git{,-blame}.el: remove old bitrotting Emacs code
Date: Tue, 13 Mar 2018 19:53:10 +0100 [thread overview]
Message-ID: <87woyfq02x.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <xmqqbmfr3jke.fsf@gitster-ct.c.googlers.com>
On Tue, Mar 13 2018, Junio C. Hamano jotted:
> Martin Ågren <martin.agren@gmail.com> writes:
>
>>> +Emacs's own support for Git got better than what was offered by these
>>> +modules, or was superseded by popular 3rd-party Git modes such as
>>> +Magit.
>>
>> This somehow reads like "Emacs's own support ... was superseded ...".
>> Maybe that's what you mean, but i'm not sure. Perhaps s/, was superseded
>> by/. There are also/.
>
> I think "There are also" is way better. If we really want to sy
> superseded, perhaps "The features these modules offered were
> superseded by Emacs's own support in VC mode, and popular
> third-party Git modes e.g. Magit" is what we can say.
I sent a v3 a few days ago which addressed this, it's at
20180310184545.16950-1-avarab@gmail.com
(https://public-inbox.org/git/20180310184545.16950-1-avarab@gmail.com/)
but I see that I screwd up the In-Reply-To (I still don't have this
fully automated) so that wasn't part of this thread, sorry.
That changes this wording, among other fixes (noted in the tbdiff).
next prev parent reply other threads:[~2018-03-13 18:53 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-03 3:48 [PATCH] git.el: handle default excludesfile properly Dorab Patel
2018-03-03 8:42 ` Eric Sunshine
2018-03-04 1:36 ` Dorab Patel
2018-03-04 2:12 ` Eric Sunshine
2018-03-04 2:57 ` Dorab Patel
2018-03-04 4:34 ` Eric Sunshine
2018-03-05 2:36 ` Junio C Hamano
2018-03-06 11:54 ` Alexandre Julliard
2018-03-07 21:52 ` Dorab Patel
2018-03-08 9:41 ` Ævar Arnfjörð Bjarmason
2018-03-08 9:45 ` [PATCH] git{,-blame}.el: remove old bitrotting Emacs code Ævar Arnfjörð Bjarmason
2018-03-08 17:27 ` Junio C Hamano
2018-03-10 12:30 ` [PATCH v2] " Ævar Arnfjörð Bjarmason
2018-03-10 16:50 ` Martin Ågren
2018-03-13 18:40 ` Junio C Hamano
2018-03-13 18:53 ` Ævar Arnfjörð Bjarmason [this message]
2018-03-13 22:14 ` Junio C Hamano
2018-03-08 17:55 ` [PATCH] " Kyle Meyer
2018-03-06 4:38 ` [PATCH v2] git.el: handle default excludesfile properly Dorab Patel
[not found] <EKzyQbDEJGG4Lm5YboF8xg@mail.gmail.com>
2018-03-10 18:45 ` [PATCH v3] git{,-blame}.el: remove old bitrotting Emacs code Ævar Arnfjörð Bjarmason
2018-03-27 16:57 ` Jonathan Nieder
2018-04-11 20:42 ` [PATCH v4] " Ævar Arnfjörð Bjarmason
2018-04-12 2:19 ` Junio C Hamano
2018-04-12 6:52 ` Ævar Arnfjörð Bjarmason
2018-04-12 9:23 ` Junio C Hamano
2018-04-18 20:16 ` Todd Zullinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87woyfq02x.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=davidk@lysator.liu.se \
--cc=dorabpatel@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=julliard@winehq.org \
--cc=martin.agren@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.