From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/edid: Add 6 bpc quirk for CPT panel in Asus UX303LA Date: Mon, 19 Feb 2018 12:42:52 +0200 Message-ID: <87woz99s5v.fsf@intel.com> References: <20180218085359.7817-1-kai.heng.feng@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id EA50889EB8 for ; Mon, 19 Feb 2018 10:42:56 +0000 (UTC) In-Reply-To: <20180218085359.7817-1-kai.heng.feng@canonical.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: airlied@linux.ie Cc: daniel.vetter@intel.com, Kai-Heng Feng , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gU3VuLCAxOCBGZWIgMjAxOCwgS2FpLUhlbmcgRmVuZyA8a2FpLmhlbmcuZmVuZ0BjYW5vbmlj YWwuY29tPiB3cm90ZToKPiBTaW1pbGFyIHRvIGNvbW1pdCBlMTBhZWM2NTJmMzEgKCJkcm0vZWRp ZDogQWRkIDYgYnBjIHF1aXJrIGZvciBkaXNwbGF5Cj4gQUVPIG1vZGVsIDAuIiksIHRoZSBFRElE IHJlcG9ydHMgIkRGUCAxLnggY29tcGxpYW50IFRNRFMiIGJ1dCBpdCBzdXBwb3J0Cj4gNmJwYyBp bnN0ZWFkIG9mIDggYnBjLgo+Cj4gSGVuY2UsIHVzZSA2IGJwYyBxdWlyayBmb3IgdGhpcyBwYW5l bC4KPgo+IEZpeGVzOiAxOTZmOTU0ZTI1MDkgKCJkcm0vaTkxNS9kcDogUmV2ZXJ0ICJkcm0vaTkx NS9kcDogZmFsbCBiYWNrIHRvIDE4IGJwcCB3aGVuIHNpbmsgY2FwYWJpbGl0eSBpcyB1bmtub3du IiIpCgpJbXBsaWVzCgpDYzogPHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmc+ICMgdjQuOCsKCj4gQnVn TGluazogaHR0cHM6Ly9idWdzLmxhdW5jaHBhZC5uZXQvYnVncy8xNzQ5NDIwCj4gU2lnbmVkLW9m Zi1ieTogS2FpLUhlbmcgRmVuZyA8a2FpLmhlbmcuZmVuZ0BjYW5vbmljYWwuY29tPgo+IC0tLQo+ ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2VkaWQuYyB8IDMgKysrCj4gIDEgZmlsZSBjaGFuZ2VkLCAz IGluc2VydGlvbnMoKykKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2VkaWQu YyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZWRpZC5jCj4gaW5kZXggZGRkNTM3OTE0NTc1Li5kOWM4 ZDcxOGUyNjEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9lZGlkLmMKPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vZHJtX2VkaWQuYwo+IEBAIC0xMTMsNiArMTEzLDkgQEAgc3RhdGlj IGNvbnN0IHN0cnVjdCBlZGlkX3F1aXJrIHsKPiAgCS8qIEFFTyBtb2RlbCAwIHJlcG9ydHMgOCBi cGMsIGJ1dCBpcyBhIDYgYnBjIHBhbmVsICovCj4gIAl7ICJBRU8iLCAwLCBFRElEX1FVSVJLX0ZP UkNFXzZCUEMgfSwKPiAgCj4gKwkvKiBDUFQgcGFuZWwgb2YgQXN1cyBVWDMwM0xBIHJlcG9ydHMg OCBicGMsIGJ1dCBpcyBhIDYgYnBjIHBhbmVsICovCj4gKwl7ICJDUFQiLCAweDE3ZGYsIEVESURf UVVJUktfRk9SQ0VfNkJQQyB9LAo+ICsKPiAgCS8qIEJlbGluZWEgMTAgMTUgNTUgKi8KPiAgCXsg Ik1BWCIsIDE1MTYsIEVESURfUVVJUktfUFJFRkVSX0xBUkdFXzYwIH0sCj4gIAl7ICJNQVgiLCAw eDc3ZSwgRURJRF9RVUlSS19QUkVGRVJfTEFSR0VfNjAgfSwKCi0tIApKYW5pIE5pa3VsYSwgSW50 ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752555AbeBSKm5 (ORCPT ); Mon, 19 Feb 2018 05:42:57 -0500 Received: from mga12.intel.com ([192.55.52.136]:5574 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752307AbeBSKm4 (ORCPT ); Mon, 19 Feb 2018 05:42:56 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,534,1511856000"; d="scan'208";a="31892909" From: Jani Nikula To: Kai-Heng Feng , airlied@linux.ie Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kai-Heng Feng , daniel.vetter@intel.com Subject: Re: [PATCH] drm/edid: Add 6 bpc quirk for CPT panel in Asus UX303LA In-Reply-To: <20180218085359.7817-1-kai.heng.feng@canonical.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20180218085359.7817-1-kai.heng.feng@canonical.com> Date: Mon, 19 Feb 2018 12:42:52 +0200 Message-ID: <87woz99s5v.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 18 Feb 2018, Kai-Heng Feng wrote: > Similar to commit e10aec652f31 ("drm/edid: Add 6 bpc quirk for display > AEO model 0."), the EDID reports "DFP 1.x compliant TMDS" but it support > 6bpc instead of 8 bpc. > > Hence, use 6 bpc quirk for this panel. > > Fixes: 196f954e2509 ("drm/i915/dp: Revert "drm/i915/dp: fall back to 18 bpp when sink capability is unknown"") Implies Cc: # v4.8+ > BugLink: https://bugs.launchpad.net/bugs/1749420 > Signed-off-by: Kai-Heng Feng > --- > drivers/gpu/drm/drm_edid.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index ddd537914575..d9c8d718e261 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -113,6 +113,9 @@ static const struct edid_quirk { > /* AEO model 0 reports 8 bpc, but is a 6 bpc panel */ > { "AEO", 0, EDID_QUIRK_FORCE_6BPC }, > > + /* CPT panel of Asus UX303LA reports 8 bpc, but is a 6 bpc panel */ > + { "CPT", 0x17df, EDID_QUIRK_FORCE_6BPC }, > + > /* Belinea 10 15 55 */ > { "MAX", 1516, EDID_QUIRK_PREFER_LARGE_60 }, > { "MAX", 0x77e, EDID_QUIRK_PREFER_LARGE_60 }, -- Jani Nikula, Intel Open Source Technology Center