From: Luis Henriques <lhenriques@suse.com>
To: "Yan, Zheng" <ukernel@gmail.com>
Cc: ceph-devel <ceph-devel@vger.kernel.org>,
"Yan, Zheng" <zyan@redhat.com>, Jeff Layton <jlayton@redhat.com>,
Jan Fajerski <jfajerski@suse.com>
Subject: Re: [PATCH v4 0/6] ceph: kernel client cephfs quota support
Date: Mon, 08 Jan 2018 15:00:59 +0000 [thread overview]
Message-ID: <87wp0stmxg.fsf@hermes.olymp> (raw)
In-Reply-To: <CAAM7YAm7kON+OqrBMccyDSMi6Jkm3qSLN=O0KPCjOuO+jUQojg@mail.gmail.com> (Zheng Yan's message of "Mon, 8 Jan 2018 20:55:35 +0800")
"Yan, Zheng" <ukernel@gmail.com> writes:
> On Fri, Jan 5, 2018 at 6:47 PM, Luis Henriques <lhenriques@suse.com> wrote:
<snip>
> Hi Luis.
>
> This series looks good. I will add them to our testing branch if my
> local test goes well.
Awesome, thanks a lot for your review. Please let me know if you find
any issues during testing.
>
> I also wish to do some optimization (incremental patches) to the code
>
> 1. avoid quota check if there is no quota in the filesystem. we can
> use a variable to tracker how many snaprealm have quota enabled.
> 2. save inode pointer (not increase inode's reference count) in
> ceph_snap_realm data structure. so we can avoid calling
> ceph_find_inode() in check_quota_exceeded()
Yeah, these changes seem to make sense. I'll have a look at them and
see what I can come up with.
Cheers,
--
Luis
next prev parent reply other threads:[~2018-01-08 15:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-05 10:47 [PATCH v4 0/6] ceph: kernel client cephfs quota support Luis Henriques
2018-01-05 10:47 ` [PATCH v4 1/6] ceph: quota: add initial infrastructure to support cephfs quotas Luis Henriques
2018-01-05 10:47 ` [PATCH v4 2/6] ceph: quota: support for ceph.quota.max_files Luis Henriques
2018-01-05 10:47 ` [PATCH v4 3/6] ceph: quota: don't allow cross-quota renames Luis Henriques
2018-01-05 10:47 ` [PATCH v4 4/6] ceph: quota: support for ceph.quota.max_bytes Luis Henriques
2018-01-05 10:47 ` [PATCH v4 5/6] ceph: quota: update MDS when max_bytes is approaching Luis Henriques
2018-01-05 10:47 ` [PATCH v4 6/6] ceph: quota: add quotas to the in-tree cephfs documentation Luis Henriques
2018-01-08 12:55 ` [PATCH v4 0/6] ceph: kernel client cephfs quota support Yan, Zheng
2018-01-08 15:00 ` Luis Henriques [this message]
2018-01-09 17:24 ` Luis Henriques
2018-01-10 6:08 ` Yan, Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wp0stmxg.fsf@hermes.olymp \
--to=lhenriques@suse.com \
--cc=ceph-devel@vger.kernel.org \
--cc=jfajerski@suse.com \
--cc=jlayton@redhat.com \
--cc=ukernel@gmail.com \
--cc=zyan@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.