From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 1/2] drm/i915: Pull the unconditional GPU cache invalidation into request construction Date: Mon, 20 Nov 2017 17:26:57 +0200 Message-ID: <87wp2l3r9a.fsf@gaia.fi.intel.com> References: <20171120102002.22254-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5C69689C9D for ; Mon, 20 Nov 2017 15:27:34 +0000 (UTC) In-Reply-To: <20171120102002.22254-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gQXMgdGhl IHJlcXVlc3Qgbm93IG1heSBpbXBsaWNpdGx5IGludm9rZSBhIGNvbnRleHQtc3dpdGNoLCB3ZSBz aG91bGQKPiBmb2xsb3cgdGhhdCB3aXRoIGEgR1BVIFRMQiBpbnZhbGlkYXRpb24uIEFsc28gZXZl biBiZWZvcmUgdXNpbmcgR0dUVCwgd2UKCnMvZm9sbG93L3ByZWFtcGxlPyBBcyBpdCBpcyB0aGUg Y29udGV4dC1zd2l0Y2ggeW91IGFyZSBwcmVhbXBsaW5nLgoKQWxzbyBwb2ludCB0aGF0IHRoZSBy ZXF1ZXN0IGFsbG9jYXRpb24gd2lsbCBpbnZvdGUgYSBjb250ZXh0LXN3aXRjaApidXQgb25seSBh ZnRlciBuZXh0IHBhdGNoLgoKU28gd2l0aCBzb21lIGNvbmZ1c2lvbiB1bnRhbmdsZWQgb24gdGhl c2UgZmlyc3QgbGluZXMsCgpSZXZpZXdlZC1ieTogTWlrYSBLdW9wcGFsYSA8bWlrYS5rdW9wcGFs YUBsaW51eC5pbnRlbC5jb20+CgoKPiBzaG91bGQgaW52YWxpZGF0ZSB0aGUgVExCcyBmb3IgYW55 IHVwZGF0ZXMgKGFzIHdlbGwgYXMgdGhlIHBwZ3R0Cj4gaW52YWxpZGF0ZXMgdGhhdCBhcmUgdW5j b25kaXRpb25hbGx5IGFwcGxpZWQgYnkgZXhlY2J1ZikuIFNpbmNlIHdlCj4gYWxtb3N0IGFsd2F5 cyByZXF1aXJlIHRoZSBUTEIgaW52YWxpZGF0ZSwgZG8gaXQgdW5jb25kaXRpb25hbGx5IG9uCj4g cmVxdWVzdCBhbGxvY2F0aW9uIGFuZCBzbyB3ZSBjYW4gcmVtb3ZlIGl0IGZyb20gYWxsIG90aGVy IHBhdGhzLgo+Cj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxz b24uY28udWs+Cj4gQ2M6IE1pa2EgS3VvcHBhbGEgPG1pa2Eua3VvcHBhbGFAbGludXguaW50ZWwu Y29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9leGVjYnVmZmVyLmMg ICAgICAgIHwgIDcgKy0tLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9yZW5k ZXJfc3RhdGUuYyAgICAgIHwgIDQgLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dl bV9yZXF1ZXN0LmMgICAgICAgICAgIHwgMjQgKysrKysrKysrKysrKysrKysrLS0tLS0KPiAgZHJp dmVycy9ncHUvZHJtL2k5MTUvc2VsZnRlc3RzL2h1Z2VfcGFnZXMuYyAgICAgICB8ICA0IC0tLS0K PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvc2VsZnRlc3RzL2k5MTVfZ2VtX2NvbnRleHQuYyB8ICA0 IC0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvc2VsZnRlc3RzL2k5MTVfZ2VtX3JlcXVlc3Qu YyB8IDEwIC0tLS0tLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvc2VsZnRlc3RzL2ludGVs X2hhbmdjaGVjay5jICB8ICA0IC0tLS0KPiAgNyBmaWxlcyBjaGFuZ2VkLCAyMCBpbnNlcnRpb25z KCspLCAzNyBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X2dlbV9leGVjYnVmZmVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9l eGVjYnVmZmVyLmMKPiBpbmRleCA1M2NjYjI3YmZlOTEuLmI3ODk1Nzg4YmM3NSAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9leGVjYnVmZmVyLmMKPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9leGVjYnVmZmVyLmMKPiBAQCAtMTExMSwxMCAr MTExMSw2IEBAIHN0YXRpYyBpbnQgX19yZWxvY19ncHVfYWxsb2Moc3RydWN0IGk5MTVfZXhlY2J1 ZmZlciAqZWIsCj4gIAlpZiAoZXJyKQo+ICAJCWdvdG8gZXJyX3JlcXVlc3Q7Cj4gIAo+IC0JZXJy ID0gZWItPmVuZ2luZS0+ZW1pdF9mbHVzaChycSwgRU1JVF9JTlZBTElEQVRFKTsKPiAtCWlmIChl cnIpCj4gLQkJZ290byBlcnJfcmVxdWVzdDsKPiAtCj4gIAllcnIgPSBpOTE1X3N3aXRjaF9jb250 ZXh0KHJxKTsKPiAgCWlmIChlcnIpCj4gIAkJZ290byBlcnJfcmVxdWVzdDsKPiBAQCAtMTgxOCw4 ICsxODE0LDcgQEAgc3RhdGljIGludCBlYl9tb3ZlX3RvX2dwdShzdHJ1Y3QgaTkxNV9leGVjYnVm ZmVyICplYikKPiAgCS8qIFVuY29uZGl0aW9uYWxseSBmbHVzaCBhbnkgY2hpcHNldCBjYWNoZXMg KGZvciBzdHJlYW1pbmcgd3JpdGVzKS4gKi8KPiAgCWk5MTVfZ2VtX2NoaXBzZXRfZmx1c2goZWIt Pmk5MTUpOwo+ICAKPiAtCS8qIFVuY29uZGl0aW9uYWxseSBpbnZhbGlkYXRlIEdQVSBjYWNoZXMg YW5kIFRMQnMuICovCj4gLQlyZXR1cm4gZWItPmVuZ2luZS0+ZW1pdF9mbHVzaChlYi0+cmVxdWVz dCwgRU1JVF9JTlZBTElEQVRFKTsKPiArCXJldHVybiAwOwo+ICB9Cj4gIAo+ICBzdGF0aWMgYm9v bCBpOTE1X2dlbV9jaGVja19leGVjYnVmZmVyKHN0cnVjdCBkcm1faTkxNV9nZW1fZXhlY2J1ZmZl cjIgKmV4ZWMpCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3Jl bmRlcl9zdGF0ZS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fcmVuZGVyX3N0YXRl LmMKPiBpbmRleCBjMjcyM2EwNmZiYjQuLmY3ZmMwZGYyNTFhYyAxMDA2NDQKPiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9yZW5kZXJfc3RhdGUuYwo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZ2VtX3JlbmRlcl9zdGF0ZS5jCj4gQEAgLTIwOCwxMCArMjA4LDYg QEAgaW50IGk5MTVfZ2VtX3JlbmRlcl9zdGF0ZV9lbWl0KHN0cnVjdCBkcm1faTkxNV9nZW1fcmVx dWVzdCAqcnEpCj4gIAlpZiAoZXJyKQo+ICAJCWdvdG8gZXJyX3VucGluOwo+ICAKPiAtCWVyciA9 IGVuZ2luZS0+ZW1pdF9mbHVzaChycSwgRU1JVF9JTlZBTElEQVRFKTsKPiAtCWlmIChlcnIpCj4g LQkJZ290byBlcnJfdW5waW47Cj4gLQo+ICAJZXJyID0gZW5naW5lLT5lbWl0X2JiX3N0YXJ0KHJx LAo+ICAJCQkJICAgIHNvLmJhdGNoX29mZnNldCwgc28uYmF0Y2hfc2l6ZSwKPiAgCQkJCSAgICBJ OTE1X0RJU1BBVENIX1NFQ1VSRSk7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZ2VtX3JlcXVlc3QuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3JlcXVl c3QuYwo+IGluZGV4IGUwZDYyMjEwMjJhOC4uOTFlYWUxYjIwYzQyIDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3JlcXVlc3QuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfZ2VtX3JlcXVlc3QuYwo+IEBAIC03MDMsMTcgKzcwMywzMSBAQCBpOTE1 X2dlbV9yZXF1ZXN0X2FsbG9jKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSwKPiAgCXJl cS0+cmVzZXJ2ZWRfc3BhY2UgPSBNSU5fU1BBQ0VfRk9SX0FERF9SRVFVRVNUOwo+ICAJR0VNX0JV R19PTihyZXEtPnJlc2VydmVkX3NwYWNlIDwgZW5naW5lLT5lbWl0X2JyZWFkY3J1bWJfc3opOwo+ ICAKPiAtCXJldCA9IGVuZ2luZS0+cmVxdWVzdF9hbGxvYyhyZXEpOwo+IC0JaWYgKHJldCkKPiAt CQlnb3RvIGVycl9jdHg7Cj4gLQo+IC0JLyogUmVjb3JkIHRoZSBwb3NpdGlvbiBvZiB0aGUgc3Rh cnQgb2YgdGhlIHJlcXVlc3Qgc28gdGhhdAo+ICsJLyoKPiArCSAqIFJlY29yZCB0aGUgcG9zaXRp b24gb2YgdGhlIHN0YXJ0IG9mIHRoZSByZXF1ZXN0IHNvIHRoYXQKPiAgCSAqIHNob3VsZCB3ZSBk ZXRlY3QgdGhlIHVwZGF0ZWQgc2Vxbm8gcGFydC13YXkgdGhyb3VnaCB0aGUKPiAgCSAqIEdQVSBw cm9jZXNzaW5nIHRoZSByZXF1ZXN0LCB3ZSBuZXZlciBvdmVyLWVzdGltYXRlIHRoZQo+ICAJICog cG9zaXRpb24gb2YgdGhlIGhlYWQuCj4gIAkgKi8KPiAgCXJlcS0+aGVhZCA9IHJlcS0+cmluZy0+ ZW1pdDsKPiAgCj4gKwkvKiBVbmNvbmRpdGlvbmFsbHkgaW52YWxpZGF0ZSBHUFUgY2FjaGVzIGFu ZCBUTEJzLiAqLwo+ICsJcmV0ID0gZW5naW5lLT5lbWl0X2ZsdXNoKHJlcSwgRU1JVF9JTlZBTElE QVRFKTsKPiArCWlmIChyZXQpCj4gKwkJZ290byBlcnJfY3R4Owo+ICsKPiArCXJldCA9IGVuZ2lu ZS0+cmVxdWVzdF9hbGxvYyhyZXEpOwo+ICsJaWYgKHJldCkgewo+ICsJCS8qCj4gKwkJICogUGFz dCB0aGUgcG9pbnQtb2Ytbm8tcmV0dXJuLiBTaW5jZSB3ZSBtYXkgaGF2ZSB1cGRhdGVkCj4gKwkJ ICogZ2xvYmFsIHN0YXRlIGFmdGVyIHBhcnRpYWxseSBjb21wbGV0aW5nIHRoZSByZXF1ZXN0IGFs bG9jLAo+ICsJCSAqIHdlIG5lZWQgdG8gY29tbWl0IGFueSBjb21tYW5kcyBzbyBmYXIgZW1pdHRl ZCBpbiB0aGUKPiArCQkgKiByZXF1ZXN0IHRvIHRoZSBIVy4KPiArCQkgKi8KPiArCQlfX2k5MTVf YWRkX3JlcXVlc3QocmVxLCBmYWxzZSk7Cj4gKwkJcmV0dXJuIEVSUl9QVFIocmV0KTsKPiArCX0K PiArCj4gIAkvKiBDaGVjayB0aGF0IHdlIGRpZG4ndCBpbnRlcnJ1cHQgb3Vyc2VsdmVzIHdpdGgg YSBuZXcgcmVxdWVzdCAqLwo+ICAJR0VNX0JVR19PTihyZXEtPnRpbWVsaW5lLT5zZXFubyAhPSBy ZXEtPmZlbmNlLnNlcW5vKTsKPiAgCXJldHVybiByZXE7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L3NlbGZ0ZXN0cy9odWdlX3BhZ2VzLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9zZWxmdGVzdHMvaHVnZV9wYWdlcy5jCj4gaW5kZXggMDFhZjU0MGI2ZWY5Li4xNTlhMmNiNjg3 NjUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvc2VsZnRlc3RzL2h1Z2VfcGFn ZXMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L3NlbGZ0ZXN0cy9odWdlX3BhZ2VzLmMK PiBAQCAtOTg5LDEwICs5ODksNiBAQCBzdGF0aWMgaW50IGdwdV93cml0ZShzdHJ1Y3QgaTkxNV92 bWEgKnZtYSwKPiAgCWk5MTVfdm1hX3VucGluKGJhdGNoKTsKPiAgCWk5MTVfdm1hX2Nsb3NlKGJh dGNoKTsKPiAgCj4gLQllcnIgPSBycS0+ZW5naW5lLT5lbWl0X2ZsdXNoKHJxLCBFTUlUX0lOVkFM SURBVEUpOwo+IC0JaWYgKGVycikKPiAtCQlnb3RvIGVycl9yZXF1ZXN0Owo+IC0KPiAgCWVyciA9 IGk5MTVfc3dpdGNoX2NvbnRleHQocnEpOwo+ICAJaWYgKGVycikKPiAgCQlnb3RvIGVycl9yZXF1 ZXN0Owo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9zZWxmdGVzdHMvaTkxNV9n ZW1fY29udGV4dC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvc2VsZnRlc3RzL2k5MTVfZ2VtX2Nv bnRleHQuYwo+IGluZGV4IGM4Mjc4MGE5ZDQ1NS4uNGZmMzBiOWFmMWZlIDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L3NlbGZ0ZXN0cy9pOTE1X2dlbV9jb250ZXh0LmMKPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9zZWxmdGVzdHMvaTkxNV9nZW1fY29udGV4dC5jCj4gQEAg LTE1OCwxMCArMTU4LDYgQEAgc3RhdGljIGludCBncHVfZmlsbChzdHJ1Y3QgZHJtX2k5MTVfZ2Vt X29iamVjdCAqb2JqLAo+ICAJCWdvdG8gZXJyX2JhdGNoOwo+ICAJfQo+ICAKPiAtCWVyciA9IGVu Z2luZS0+ZW1pdF9mbHVzaChycSwgRU1JVF9JTlZBTElEQVRFKTsKPiAtCWlmIChlcnIpCj4gLQkJ Z290byBlcnJfcmVxdWVzdDsKPiAtCj4gIAllcnIgPSBpOTE1X3N3aXRjaF9jb250ZXh0KHJxKTsK PiAgCWlmIChlcnIpCj4gIAkJZ290byBlcnJfcmVxdWVzdDsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvc2VsZnRlc3RzL2k5MTVfZ2VtX3JlcXVlc3QuYyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L3NlbGZ0ZXN0cy9pOTE1X2dlbV9yZXF1ZXN0LmMKPiBpbmRleCA2YmNlOTkwNTBl OTQuLmQ3YmY1M2ZmOGY4NCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9zZWxm dGVzdHMvaTkxNV9nZW1fcmVxdWVzdC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvc2Vs ZnRlc3RzL2k5MTVfZ2VtX3JlcXVlc3QuYwo+IEBAIC00NTksMTAgKzQ1OSw2IEBAIGVtcHR5X3Jl cXVlc3Qoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lLAo+ICAJaWYgKElTX0VSUihyZXF1 ZXN0KSkKPiAgCQlyZXR1cm4gcmVxdWVzdDsKPiAgCj4gLQllcnIgPSBlbmdpbmUtPmVtaXRfZmx1 c2gocmVxdWVzdCwgRU1JVF9JTlZBTElEQVRFKTsKPiAtCWlmIChlcnIpCj4gLQkJZ290byBvdXRf cmVxdWVzdDsKPiAtCj4gIAllcnIgPSBpOTE1X3N3aXRjaF9jb250ZXh0KHJlcXVlc3QpOwo+ICAJ aWYgKGVycikKPiAgCQlnb3RvIG91dF9yZXF1ZXN0Owo+IEBAIC02NzUsOSArNjcxLDYgQEAgc3Rh dGljIGludCBsaXZlX2FsbF9lbmdpbmVzKHZvaWQgKmFyZykKPiAgCQkJZ290byBvdXRfcmVxdWVz dDsKPiAgCQl9Cj4gIAo+IC0JCWVyciA9IGVuZ2luZS0+ZW1pdF9mbHVzaChyZXF1ZXN0W2lkXSwg RU1JVF9JTlZBTElEQVRFKTsKPiAtCQlHRU1fQlVHX09OKGVycik7Cj4gLQo+ICAJCWVyciA9IGk5 MTVfc3dpdGNoX2NvbnRleHQocmVxdWVzdFtpZF0pOwo+ICAJCUdFTV9CVUdfT04oZXJyKTsKPiAg Cj4gQEAgLTc5Nyw5ICs3OTAsNiBAQCBzdGF0aWMgaW50IGxpdmVfc2VxdWVudGlhbF9lbmdpbmVz KHZvaWQgKmFyZykKPiAgCQkJfQo+ICAJCX0KPiAgCj4gLQkJZXJyID0gZW5naW5lLT5lbWl0X2Zs dXNoKHJlcXVlc3RbaWRdLCBFTUlUX0lOVkFMSURBVEUpOwo+IC0JCUdFTV9CVUdfT04oZXJyKTsK PiAtCj4gIAkJZXJyID0gaTkxNV9zd2l0Y2hfY29udGV4dChyZXF1ZXN0W2lkXSk7Cj4gIAkJR0VN X0JVR19PTihlcnIpOwo+ICAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvc2Vs ZnRlc3RzL2ludGVsX2hhbmdjaGVjay5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvc2VsZnRlc3Rz L2ludGVsX2hhbmdjaGVjay5jCj4gaW5kZXggNzFjZTA2NjgwZDY2Li4xNDViZGMyNjU1M2MgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvc2VsZnRlc3RzL2ludGVsX2hhbmdjaGVj ay5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvc2VsZnRlc3RzL2ludGVsX2hhbmdjaGVj ay5jCj4gQEAgLTExNCwxMCArMTE0LDYgQEAgc3RhdGljIGludCBlbWl0X3JlY3Vyc2VfYmF0Y2go c3RydWN0IGhhbmcgKmgsCj4gIAlpZiAoZXJyKQo+ICAJCWdvdG8gdW5waW5fdm1hOwo+ICAKPiAt CWVyciA9IHJxLT5lbmdpbmUtPmVtaXRfZmx1c2gocnEsIEVNSVRfSU5WQUxJREFURSk7Cj4gLQlp ZiAoZXJyKQo+IC0JCWdvdG8gdW5waW5faHdzOwo+IC0KPiAgCWVyciA9IGk5MTVfc3dpdGNoX2Nv bnRleHQocnEpOwo+ICAJaWYgKGVycikKPiAgCQlnb3RvIHVucGluX2h3czsKPiAtLSAKPiAyLjE1 LjAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==