From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915/intel_sdvo: mark expected switch fall-throughs Date: Thu, 09 Nov 2017 10:20:53 +0200 Message-ID: <87wp2zammy.fsf@intel.com> References: <20171108202725.GA7246@embeddedor.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20171108202725.GA7246@embeddedor.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Joonas Lahtinen , Rodrigo Vivi , David Airlie Cc: intel-gfx@lists.freedesktop.org, "Gustavo A. R. Silva" , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCAwOCBOb3YgMjAxNywgIkd1c3Rhdm8gQS4gUi4gU2lsdmEiIDxnYXJzaWx2YUBlbWJl ZGRlZG9yLmNvbT4gd3JvdGU6Cj4gSW4gcHJlcGFyYXRpb24gdG8gZW5hYmxpbmcgLVdpbXBsaWNp dC1mYWxsdGhyb3VnaCwgbWFyayBzd2l0Y2ggY2FzZXMKPiB3aGVyZSB3ZSBhcmUgZXhwZWN0aW5n IHRvIGZhbGwgdGhyb3VnaC4KPgo+IEFkZHJlc3Nlcy1Db3Zlcml0eS1JRDogMTQxNDMyCj4gQWRk cmVzc2VzLUNvdmVyaXR5LUlEOiAxNDE0MzMKPiBBZGRyZXNzZXMtQ292ZXJpdHktSUQ6IDE0MTQz NAo+IEFkZHJlc3Nlcy1Db3Zlcml0eS1JRDogMTQxNDM1Cj4gQWRkcmVzc2VzLUNvdmVyaXR5LUlE OiAxNDE0MzYKPiBTaWduZWQtb2ZmLWJ5OiBHdXN0YXZvIEEuIFIuIFNpbHZhIDxnYXJzaWx2YUBl bWJlZGRlZG9yLmNvbT4KCkFja2VkLWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwu Y29tPgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc2R2by5jIHwgMTEgKysr KysrLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMo LSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zZHZvLmMgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zZHZvLmMKPiBpbmRleCA3NDM3OTQ0Li45MjFlMzcy IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nkdm8uYwo+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nkdm8uYwo+IEBAIC0xMzI3LDYgKzEzMjcsNyBA QCBzdGF0aWMgdm9pZCBpbnRlbF9zZHZvX3ByZV9lbmFibGUoc3RydWN0IGludGVsX2VuY29kZXIg KmludGVsX2VuY29kZXIsCj4gIAlzd2l0Y2ggKGNydGNfc3RhdGUtPnBpeGVsX211bHRpcGxpZXIp IHsKPiAgCWRlZmF1bHQ6Cj4gIAkJV0FSTigxLCAidW5rbm93biBwaXhlbCBtdWx0aXBsaWVyIHNw ZWNpZmllZFxuIik7Cj4gKwkJLyogZmFsbCB0aHJvdWdoICovCj4gIAljYXNlIDE6IHJhdGUgPSBT RFZPX0NMT0NLX1JBVEVfTVVMVF8xWDsgYnJlYWs7Cj4gIAljYXNlIDI6IHJhdGUgPSBTRFZPX0NM T0NLX1JBVEVfTVVMVF8yWDsgYnJlYWs7Cj4gIAljYXNlIDQ6IHJhdGUgPSBTRFZPX0NMT0NLX1JB VEVfTVVMVF80WDsgYnJlYWs7Cj4gQEAgLTIyNzQsMTUgKzIyNzUsMTUgQEAgaW50ZWxfc2R2b19n dWVzc19kZGNfYnVzKHN0cnVjdCBpbnRlbF9zZHZvICpzZHZvKQo+ICAJICovCj4gIAlzd2l0Y2gg KHNkdm8tPmNvbnRyb2xsZWRfb3V0cHV0KSB7Cj4gIAljYXNlIFNEVk9fT1VUUFVUX0xWRFMxOgo+ IC0JCW1hc2sgfD0gU0RWT19PVVRQVVRfTFZEUzE7Cj4gKwkJbWFzayB8PSBTRFZPX09VVFBVVF9M VkRTMTsgLyogZmFsbCB0aHJvdWdoICovCj4gIAljYXNlIFNEVk9fT1VUUFVUX0xWRFMwOgo+IC0J CW1hc2sgfD0gU0RWT19PVVRQVVRfTFZEUzA7Cj4gKwkJbWFzayB8PSBTRFZPX09VVFBVVF9MVkRT MDsgLyogZmFsbCB0aHJvdWdoICovCj4gIAljYXNlIFNEVk9fT1VUUFVUX1RNRFMxOgo+IC0JCW1h c2sgfD0gU0RWT19PVVRQVVRfVE1EUzE7Cj4gKwkJbWFzayB8PSBTRFZPX09VVFBVVF9UTURTMTsg LyogZmFsbCB0aHJvdWdoICovCj4gIAljYXNlIFNEVk9fT1VUUFVUX1RNRFMwOgo+IC0JCW1hc2sg fD0gU0RWT19PVVRQVVRfVE1EUzA7Cj4gKwkJbWFzayB8PSBTRFZPX09VVFBVVF9UTURTMDsgLyog ZmFsbCB0aHJvdWdoICovCj4gIAljYXNlIFNEVk9fT1VUUFVUX1JHQjE6Cj4gLQkJbWFzayB8PSBT RFZPX09VVFBVVF9SR0IxOwo+ICsJCW1hc2sgfD0gU0RWT19PVVRQVVRfUkdCMTsgLyogZmFsbCB0 aHJvdWdoICovCj4gIAljYXNlIFNEVk9fT1VUUFVUX1JHQjA6Cj4gIAkJbWFzayB8PSBTRFZPX09V VFBVVF9SR0IwOwo+ICAJCWJyZWFrOwoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJj ZSBUZWNobm9sb2d5IENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p bnRlbC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753405AbdKIIUC (ORCPT ); Thu, 9 Nov 2017 03:20:02 -0500 Received: from mga14.intel.com ([192.55.52.115]:53154 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753274AbdKIITc (ORCPT ); Thu, 9 Nov 2017 03:19:32 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,368,1505804400"; d="scan'208";a="588175" From: Jani Nikula To: "Gustavo A. R. Silva" , Joonas Lahtinen , Rodrigo Vivi , David Airlie Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: Re: [PATCH] drm/i915/intel_sdvo: mark expected switch fall-throughs In-Reply-To: <20171108202725.GA7246@embeddedor.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20171108202725.GA7246@embeddedor.com> Date: Thu, 09 Nov 2017 10:20:53 +0200 Message-ID: <87wp2zammy.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 08 Nov 2017, "Gustavo A. R. Silva" wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Addresses-Coverity-ID: 141432 > Addresses-Coverity-ID: 141433 > Addresses-Coverity-ID: 141434 > Addresses-Coverity-ID: 141435 > Addresses-Coverity-ID: 141436 > Signed-off-by: Gustavo A. R. Silva Acked-by: Jani Nikula > --- > drivers/gpu/drm/i915/intel_sdvo.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c > index 7437944..921e372 100644 > --- a/drivers/gpu/drm/i915/intel_sdvo.c > +++ b/drivers/gpu/drm/i915/intel_sdvo.c > @@ -1327,6 +1327,7 @@ static void intel_sdvo_pre_enable(struct intel_encoder *intel_encoder, > switch (crtc_state->pixel_multiplier) { > default: > WARN(1, "unknown pixel multiplier specified\n"); > + /* fall through */ > case 1: rate = SDVO_CLOCK_RATE_MULT_1X; break; > case 2: rate = SDVO_CLOCK_RATE_MULT_2X; break; > case 4: rate = SDVO_CLOCK_RATE_MULT_4X; break; > @@ -2274,15 +2275,15 @@ intel_sdvo_guess_ddc_bus(struct intel_sdvo *sdvo) > */ > switch (sdvo->controlled_output) { > case SDVO_OUTPUT_LVDS1: > - mask |= SDVO_OUTPUT_LVDS1; > + mask |= SDVO_OUTPUT_LVDS1; /* fall through */ > case SDVO_OUTPUT_LVDS0: > - mask |= SDVO_OUTPUT_LVDS0; > + mask |= SDVO_OUTPUT_LVDS0; /* fall through */ > case SDVO_OUTPUT_TMDS1: > - mask |= SDVO_OUTPUT_TMDS1; > + mask |= SDVO_OUTPUT_TMDS1; /* fall through */ > case SDVO_OUTPUT_TMDS0: > - mask |= SDVO_OUTPUT_TMDS0; > + mask |= SDVO_OUTPUT_TMDS0; /* fall through */ > case SDVO_OUTPUT_RGB1: > - mask |= SDVO_OUTPUT_RGB1; > + mask |= SDVO_OUTPUT_RGB1; /* fall through */ > case SDVO_OUTPUT_RGB0: > mask |= SDVO_OUTPUT_RGB0; > break; -- Jani Nikula, Intel Open Source Technology Center