From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47131)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1e4n0q-0001h7-Tu
	for qemu-devel@nongnu.org; Wed, 18 Oct 2017 07:59:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1e4n0n-0003o7-Th
	for qemu-devel@nongnu.org; Wed, 18 Oct 2017 07:59:53 -0400
Received: from mx1.redhat.com ([209.132.183.28]:53680)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <quintela@redhat.com>) id 1e4n0n-0003nd-Na
	for qemu-devel@nongnu.org; Wed, 18 Oct 2017 07:59:49 -0400
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com
	[10.5.11.13])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 8745613AA6
	for <qemu-devel@nongnu.org>; Wed, 18 Oct 2017 11:59:48 +0000 (UTC)
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <20171009082812.GE2196@pxdev.xzpeter.org> (Peter Xu's message of
	"Mon, 9 Oct 2017 16:28:12 +0800")
References: <20171004103933.7898-1-quintela@redhat.com>
	<20171004103933.7898-6-quintela@redhat.com>
	<20171009082812.GE2196@pxdev.xzpeter.org>
Reply-To: quintela@redhat.com
Date: Wed, 18 Oct 2017 13:59:44 +0200
Message-ID: <87wp3sll8v.fsf@secure.laptop>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 5/6] tests: Add migration compress threads
 tests
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Xu <peterx@redhat.com>
Cc: qemu-devel@nongnu.org, dgilbert@redhat.com, lvivier@redhat.com

Peter Xu <peterx@redhat.com> wrote:
> On Wed, Oct 04, 2017 at 12:39:32PM +0200, Juan Quintela wrote:
>
> [...]
>
>>  int main(int argc, char **argv)
>>  {
>> @@ -641,6 +689,9 @@ int main(int argc, char **argv)
>>      qtest_add_func("/migration/precopy/tcp", test_precopy_tcp);
>>      qtest_add_func("/migration/deprecated/unix", test_deprecated_unix);
>>      qtest_add_func("/migration/xbzrle/unix", test_xbzrle_unix);
>
> Nits: Not sure whether we can have better naming for the tests?  Say:
>
>   /migration/precopy/unix
>   /migration/precopy/tcp
>   /migration/deprecated-cmds
>   /migration/xbzrle
>   /migration/compression
>
> I'm fine with existing naming as well.
>
> For the deprecated commands test, not sure whether we can just send
> those commands and query using "query-migrate-parameters" to make sure
> they are setup and valid.  I assume it can be faster than real
> migrations.

Yeap, having done that because I wanted people to say what they thought
before I invested too much time.

>> +    if (0) {
>
> Is this intended? :)

I think I put that on the cover letter.  It is not working reliabely to
me, and as this was more an RFC than anything else ....

Thanks, Juan.