From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from alexa-out.qualcomm.com ([129.46.98.28]:40891 "EHLO alexa-out.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756206AbdJKI2r (ORCPT ); Wed, 11 Oct 2017 04:28:47 -0400 From: Kalle Valo To: Bjorn Andersson CC: Jia-Ju Bai , "k.eugene.e@gmail.com" , "wcn36xx@lists.infradead.org" , "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" Subject: Re: [PATCH] wcn36xx: Remove unnecessary rcu_read_unlock in wcn36xx_bss_info_changed Date: Wed, 11 Oct 2017 08:28:42 +0000 Message-ID: <87wp42qe9y.fsf@kamboji.qca.qualcomm.com> (sfid-20171011_103052_306058_6AE0997C) References: <1507467969-24016-1-git-send-email-baijiaju1990@163.com> <20171011065445.GP1165@minitux> In-Reply-To: <20171011065445.GP1165@minitux> (Bjorn Andersson's message of "Tue, 10 Oct 2017 23:54:45 -0700") Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: Bjorn Andersson writes: > On Sun 08 Oct 06:06 PDT 2017, Jia-Ju Bai wrote: > >> No rcu_read_lock is called, but rcu_read_unlock is still called. >> Thus rcu_read_unlock should be removed. >>=20 > > Thanks, not sure how I could miss that one. Kalle can you please include > this in a v4.14-rc pull request? > > > : > > Fixes: 39efc7cc7ccf ("wcn36xx: Introduce mutual exclusion of fw configura= tion") > >> Signed-off-by: Jia-Ju Bai > > Acked-by: Bjorn Andersson Ok, I'll queue this to 4.14. --=20 Kalle Valo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757410AbdJKI2w (ORCPT ); Wed, 11 Oct 2017 04:28:52 -0400 Received: from alexa-out.qualcomm.com ([129.46.98.28]:40891 "EHLO alexa-out.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756206AbdJKI2r (ORCPT ); Wed, 11 Oct 2017 04:28:47 -0400 X-IronPort-AV: E=Sophos;i="5.43,360,1503385200"; d="scan'208";a="6213247" X-IronPort-AV: E=McAfee;i="5900,7806,8680"; a="1013690735" X-MGA-submission: =?us-ascii?q?MDFK79BVwoxppryrLG5i4Jmf8CMTU832W6Yg3i?= =?us-ascii?q?ivSz9d01YpMEsc/0jTvC8IXWeq6WCTBxPv+fw61rjGPg5TEH9d1XvfyK?= =?us-ascii?q?SuWfGoV7eE8MroqHTlx+FeeF2ilAVdr/afzoKGBiNkAbRiwKFZeD9S0A?= =?us-ascii?q?sB?= From: Kalle Valo To: Bjorn Andersson CC: Jia-Ju Bai , "k.eugene.e@gmail.com" , "wcn36xx@lists.infradead.org" , "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" Subject: Re: [PATCH] wcn36xx: Remove unnecessary rcu_read_unlock in wcn36xx_bss_info_changed Thread-Topic: [PATCH] wcn36xx: Remove unnecessary rcu_read_unlock in wcn36xx_bss_info_changed Thread-Index: AQHTQmryr2j5WpfR80KT3/iXuZ1qgQ== Date: Wed, 11 Oct 2017 08:28:42 +0000 Message-ID: <87wp42qe9y.fsf@kamboji.qca.qualcomm.com> References: <1507467969-24016-1-git-send-email-baijiaju1990@163.com> <20171011065445.GP1165@minitux> In-Reply-To: <20171011065445.GP1165@minitux> (Bjorn Andersson's message of "Tue, 10 Oct 2017 23:54:45 -0700") Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.251.52.12] Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v9B8Sw3C025461 Bjorn Andersson writes: > On Sun 08 Oct 06:06 PDT 2017, Jia-Ju Bai wrote: > >> No rcu_read_lock is called, but rcu_read_unlock is still called. >> Thus rcu_read_unlock should be removed. >> > > Thanks, not sure how I could miss that one. Kalle can you please include > this in a v4.14-rc pull request? > > > : > > Fixes: 39efc7cc7ccf ("wcn36xx: Introduce mutual exclusion of fw configuration") > >> Signed-off-by: Jia-Ju Bai > > Acked-by: Bjorn Andersson Ok, I'll queue this to 4.14. -- Kalle Valo